Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 11:32:07 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Yong Wu <yong.wu@mediatek.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>, iommu@lists.linux.dev,
        iommu@lists.linux-foundation.org,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        mingyuan.ma@mediatek.com, yf.wang@mediatek.com,
        libo.kang@mediatek.com, chengci.xu@mediatek.com,
        youlin.pei@mediatek.com, anan.sun@mediatek.com,
        xueqi.zhang@mediatek.com, Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH v4 3/6] iommu/mediatek: Add error path for loop of
 mm_dts_parse
Message-ID: <20220830083206.GT2030@kadam>
References: <20220824064306.21495-1-yong.wu@mediatek.com>
 <20220824064306.21495-4-yong.wu@mediatek.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220824064306.21495-4-yong.wu@mediatek.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D7CtLa4FF5R6xkt4OWWqt46EeSZdI+GJy//W8D/zxmKzY+z+TW3TY0zr+CWR?=
 =?us-ascii?Q?5572IQZhl8GTexxoXDxZimjlIS27ceMtAn/lGXrQ+X/JTPX3B5Kum8LxrRc+?=
 =?us-ascii?Q?IKGnvWFu7zEniI4S1ZcoRFn+j2AmsauBV53oTUhCoX/Nze9WWNzs3SjDF2b9?=
 =?us-ascii?Q?YN8bs5L8oMyPLqOvQJIm1TyTHZI0hyvDZq9TpAfxJgLMgTvZZixZ29nzUw4v?=
 =?us-ascii?Q?0RJXJLktR/icYHbrnZqjLlwT4/c2WiqSoxKCkMGMlFryELIWr/SWcovvsMKO?=
 =?us-ascii?Q?0PorA1vj9nJ3dR/dfi5KmoRt9of8XFW9Qc3f3gmhksz+m9Q5027zqLY5ruyw?=
 =?us-ascii?Q?wJuNRwo1mrHT72GYEqqeXpggd5d1x1ZjElwb4ktZkAl/Qb32mJe5hWuV0CHG?=
 =?us-ascii?Q?uGa2H2nqCg9ztGs3xOmX3vJ6XT7g/jq2j4YFYy3ZOMVZj9KO5RvJVCjImVSg?=
 =?us-ascii?Q?/k6+bzXKP6e0CFH9JA7pyf+N3tkLUswjT9pPvUUDco55db9vSjZN7O9ZgxYB?=
 =?us-ascii?Q?BUA4L5J08LXILBguesl9Fqv6cbqf9c5qNp3Fm0BWJYofnZfLu7HB3bfmnmYO?=
 =?us-ascii?Q?D7eDX8htVNnVJnmQuidKgY+jvk5kW+CGuRprHxpPOjzsVnEBjAj5AyMg9QjK?=
 =?us-ascii?Q?iEWb6fh5bk7sxZFfbFzshDBV7GwvJx4lZOuV2hMaqJM9qSyZgzhmNFKInInu?=
 =?us-ascii?Q?BaIkYSqsZRk47l7Bprr6LO+ywasmCl8jmqds6Js0FgCunxm7ZT1rJ85dK+yu?=
 =?us-ascii?Q?YJ4rqpewE02CY4fVUe7Go2K342lvpXtmkTWe50hOg2AtVZV4zJJo91g6r7Ur?=
 =?us-ascii?Q?wZy7SMZ+6imIo2XEOUuFi/u89CbLsY0lK45fMvy5Bf0sK3nhdo1JYTgBXOy2?=
 =?us-ascii?Q?m6XTdahaOkaZJ2Cq27lnJme+n0ho0nn1FOCRcB6LHxXzKCeyaZFg2wz599f1?=
 =?us-ascii?Q?YIBR579F+bvR9QVzwY/hjf73IIMb3Rl2fDr/bJUOhOJV2vZTed+lqWDX+MEa?=
 =?us-ascii?Q?vmUXQKY2KRYT8LM2JqHO9dbG1Uz9Y94vAMSadx+3UHpWG2ysbso5teyiDzAn?=
 =?us-ascii?Q?d9z4enh7UZXk9AJcvu1Mas9lZBZ+8XW80hoU7V6AiOtKgNhIwUvyk2H0GSCB?=
 =?us-ascii?Q?v2i/osllstY5YAqC7BztGUeznPm5VioYxf5XZdzyC+tWFg1W7FHbf/unCq5D?=
 =?us-ascii?Q?eZooM0q31iLuGk+IT510ocjFbgPqEMCGTi81pYhEFc1HxlIj+5eHSUbBBmKS?=
 =?us-ascii?Q?pR/BNeuO6vyjrXM6uCCJBUSSNM7GvwhjoiUPENpb2EM8uI+stBjAknDAdIwk?=
 =?us-ascii?Q?odzXCoIyBSjKqnnobb30Le+PPfVqNIwCHIUxrA2bO7asU2NY/yADJ2YSk2yI?=
 =?us-ascii?Q?NPKFye6kOQzp+ltNLf8uLrhC+hoya2xAUCrFtm/rBYvixCtQrQ21Ice/1j3G?=
 =?us-ascii?Q?UBigSWa349h59YEXtiCXkQDZQT6JrLvcO0JwNiGfUcgADXJQStbMhE2a4rIJ?=
 =?us-ascii?Q?MZJkYVCYUreLh9//6K7+kvIHt0bmlI/8TG0AG2UDzzl1oYLuZGz+WI5pStTm?=
 =?us-ascii?Q?pp+AUF++oMIv0IyFsaiRpT6Zd2w/xm4Yi+vJEOKkxR89f0MDzOjTkGx6E0Bo?=
 =?us-ascii?Q?Tg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 03a9ae8f-58ad-4a7d-f81c-08da8a622e9f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 08:32:32.1572
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HoPsiP3tnijN+IGuEg/fuQA92IO5NlpXRnlmHOFj2YsWGJc1nj1mPa69F2voM5ngYWSR3lNvo7Dz/zrmCleLNwjcpGUwP+tWYYvUiAYho08=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1237
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-30_04,2022-08-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208300041
X-Proofpoint-GUID: uMsHMasyWkuM-nJ8FFIQqI1iCPS50Ngr
X-Proofpoint-ORIG-GUID: uMsHMasyWkuM-nJ8FFIQqI1iCPS50Ngr
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 24, 2022 at 02:43:03PM +0800, Yong Wu wrote:
> The mtk_iommu_mm_dts_parse will parse the smi larbs nodes. if the i+1
> larb is parsed fail, we should put_device for the 0..i larbs.
> 
> There are two places need to comment:
> 1) The larbid may be not linear mapping, we should loop whole
>    the array in the error path.
> 2) I move this line position: "data->larb_imu[id].dev = &plarbdev->dev;"
>    That means set data->larb_imu[id].dev before the error path.
>    then we don't need "platform_device_put(plarbdev)" again while
>    probe_defer case. All depend on "put_device" in the error path in error
>    cases.

I don't understand what you're saying here.  There is still a
platform_device_put(plarbdev) on the success path after
component_match_add().

So if we fail when i == 2 then we do:

	put_device(data->larb_imu[2].dev);

But for the previous iterations has both platform_device_put()
and put_device() called for them.

regards,
dan carpenter