Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3972549rwe; Tue, 30 Aug 2022 02:08:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR5M4pp0WWk0k+eqGuP40P+iTfaEhNEuJSdAk2B2Neq/r9bmJAFm3NYcMxxkYNEBNAZhn8Dg X-Received: by 2002:a05:6402:e86:b0:440:d1be:20c7 with SMTP id h6-20020a0564020e8600b00440d1be20c7mr19733680eda.349.1661850528581; Tue, 30 Aug 2022 02:08:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661850528; cv=none; d=google.com; s=arc-20160816; b=pWuabMoPLyI7FEd4I2JnRtEZNpEGTgE9DNfc9ppj0nCoxl8o46dEn+Dekxb/TwRQg1 5w+axCLVO7Rjmq0db9ca6pnaq74eZ2lqv02R0+utXqSR9bQfhnhUxZ6j/OlYmPgO4K5g T4/pcm1FoXRaiyljuvwEwWBwDEH77IDK352ZCncUjv41o6Ao6gN5vcvBbu05aropj6RU OVXY2vR1TvAZ0pB2KOSanxEdJ+5GagE/Z0kCY4T18O1qwbPh/Oh6Egp6ENb4CwpE8IRk Tq0MyLHEvCeGaxHTJKz2iPBB0zI70FTRV2SgrIE00pYsxZoApcAZ0NtFxlPEX2bCGmNR uLRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=7iCvOssdkyuxbhoQt5lAWcL9dGnbKNvL6gaRHI/rUIE=; b=iE0Vh9MtrWO6Pi7V3ozwMui88gnf/nq+7XssN2Yz8LJSf6RW+uV623LCA4q47fWvGJ lxUytNq6VEoxw/q7MCHy+DNBqj9WMCaVyi0Xj6ADKC32LfP9+aoz5jitRs+beiajq2a5 gepsivXUwxf1ONCs0CDE/2erdcSc2Fg7ziDCAFFuoV5pbYRw7244sQtNIJqMLf1nze6s eZEZzErAxaPp8S/grXkuoHIknNDEnQpVgikhVW1mSF4mJnvXeD22x0/Wy9mLeRwK2lxK ef0eHvJJjTq3t5S5GsW1EzuoJZs7W5tU4GInMuQh5wfsFjVA/MKlFWuOCnNDxus4bf65 O5GA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=e1waB5CI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr17-20020a170907721100b00741a1f9d045si2504302ejc.911.2022.08.30.02.08.23; Tue, 30 Aug 2022 02:08:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sifive.com header.s=google header.b=e1waB5CI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231651AbiH3Isv (ORCPT + 99 others); Tue, 30 Aug 2022 04:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231340AbiH3Ist (ORCPT ); Tue, 30 Aug 2022 04:48:49 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A9BBBBA43 for ; Tue, 30 Aug 2022 01:48:48 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id t5so13229236edc.11 for ; Tue, 30 Aug 2022 01:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=7iCvOssdkyuxbhoQt5lAWcL9dGnbKNvL6gaRHI/rUIE=; b=e1waB5CIdo3f9+WqVOb5fZZ2HpfISqnyynQUiahYiWLbFsihpG9YE7QGYopiztHtXQ YXEVdbX5AT4GycNvKMv93DvvepUVg+cxuEJlA0UotKWcwF/kSBe2qXUNXMGy9guT6bV5 AWSQtUErN9c0DciG1ox0ijf+yrYasDH4uJBLnx8hbOrv6gv7x85Jec8rXbrE0LjZj9sk 93q8Ykimr38kngAzUz8DKwDpkYE3jYvNo7+WdsjBp53wMiCrqp/oeTJzQjx6/W2HSGhW u4Y5/h24B6BB5dnDQ/Ib5Lz38xBIe+zaPEQSgnFMnVmjsBqoTuzLc4NulAl2wPP3JkyF Ynjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=7iCvOssdkyuxbhoQt5lAWcL9dGnbKNvL6gaRHI/rUIE=; b=rz+vuZw9o0N9mbuyPFoi1EcVK2vlWh9gE/xSs23PXV9P0YnEmCmkpeTkLYz4OKg6Dm Wc5Eqqno9bEkn4P6Kbprd4+oAOYhVSyXWNGZpRnomdulzdjEGuXwePFgZcbgeGOWMzLa OWZ2OQdSf7WYdfZWjkt8cmubJB0A+ZSP53apvBEectlub0K5TxCVj+riP4eftwDnKeaL gQW0jEfAEUAmjJsVg5cwQ040rlMMGqAMdU57qY7N9R6MECJ8Q09mxw/pu5yt3MChCN9A X0jXdtQCo4sjE/ZTRV2fz+NWJcA+2rRmC971O2MkNjpa7cAlUweGN7TuQbA1Fydz1KOZ epJw== X-Gm-Message-State: ACgBeo0zLRifF+on5o0sF1xj0xmnBf5k/hTsQipPUyhu/NqzZ23Rzexf 6xckaDoGQmA55Wt/ocoiHkFjFVZY+EanO3Yj3ALCxn5wUis5Lw== X-Received: by 2002:a05:6402:4446:b0:43b:e1f4:8525 with SMTP id o6-20020a056402444600b0043be1f48525mr19520149edb.236.1661849326660; Tue, 30 Aug 2022 01:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20220802175755.6530-1-sudip.mukherjee@sifive.com> <20220826180327.yazfoydjiyygd7qf@mobilestation> In-Reply-To: <20220826180327.yazfoydjiyygd7qf@mobilestation> From: Sudip Mukherjee Date: Tue, 30 Aug 2022 09:48:35 +0100 Message-ID: Subject: Re: [PATCH 00/11] Add support for enhanced SPI for Designware SPI controllers To: Serge Semin Cc: Serge Semin , Mark Brown , Rob Herring , Krzysztof Kozlowski , Greentime Hu , Jude Onyenegecha , William Salmon , Adnan Chowdhury , Ben Dooks , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jeegar Lakhani Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 7:03 PM Serge Semin wrote: > > Hello Sudip > > On Tue, Aug 02, 2022 at 06:57:44PM +0100, Sudip Mukherjee wrote: > > Some Synopsys SSI controllers support enhanced SPI which includes > > Dual mode, Quad mode and Octal mode. DWC_ssi includes clock stretching > > feature in enhanced SPI modes which can be used to prevent FIFO underflow > > and overflow conditions while transmitting or receiving the data respectively. > > This is only tested on controller version 1.03a. > > > I've deliberately collected all the generic comments here so you'd be > aware of the required changes in total, because I very much doubt all > of them could be fixed at once via a single patchset iteration. But as > soon as all of them are fixed we'll get a very nice and neat solution > for the eSPI feature. > Thanks a lot for the summary here Sergey. I am sure I will have a few questions for you after I start with the changes. -- Regards Sudip