Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3986218rwe; Tue, 30 Aug 2022 02:29:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR7fgKa9kYlturvw41BJ706cEF7FulU3rtzU66BBSX7/7ds0sFcUujwS47FNMbDK/5NResiQ X-Received: by 2002:a17:907:7b94:b0:731:1b11:c241 with SMTP id ne20-20020a1709077b9400b007311b11c241mr16863726ejc.676.1661851766382; Tue, 30 Aug 2022 02:29:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661851766; cv=none; d=google.com; s=arc-20160816; b=ULLZEZahEMH9cA20U3X3dl/zvxAzTbFnS4UbuBCI8YnUQEtIpplzscrtQohlgFUiPK AwaPwSIzGNaQoIFNlMLCTUggIsI36EjzRlGehl4vyS9aC/NqOA2E4TsVsNsIGUUtLKLk maVlzE1zVcpkiykOKqYKNP20YWRLL3sH2sv14MQPtKBi96Hp3ouyUrJYlnWkixz83uyB NsWSTTM8iK8GEHn/N3G4yyuO1II3zbjexR+lHNdqPztr1tU9ZFGvi8rcSQAnfmu9N0L6 5NzpD6mCdiKbGFF4WM3hZ+Qoi5vFVL5wrYyyTEd6CiyaQiJHdG999evRHYNUZHpGZ2Z+ QqaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=lk9AD6Iinu8TmKUXaLXt2GoA2UZOaPcy4jcHDhlLVXI=; b=X9gnpJyGstRToO4XE787bPTFAOxnoxTKXunEsXjdQ/tpu5d16grMT3gBDjHsSf4IaA EJQ8Lo0qBwRn7S7fMd5fmVZLh5FepzCaDTsbKBLYzT6mcJmKC+LI+1LTDHlJN/mmD7FY Ws+UCVuUitohB/pxDO5zh9V0czNfEEPdirwrK7n7wTNK6ZzbsIr9UXjIawAm4ZKLTPho laWr+NlK53YwD27ITI5g2scGKrom6+YTTY2SbyVl9mZb3nyshw6e4dncgY2ovaPFb6V4 2jXHCo7ttw/BERJWKHthu1vvn2dPimh4zkP2FfHD+XGk0R0uV5kVmm4sS7B9+4VS9UZn dYEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=I9oUDCAE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h3-20020a17090634c300b0073d4db38fdesi7258719ejb.475.2022.08.30.02.28.47; Tue, 30 Aug 2022 02:29:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=I9oUDCAE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbiH3IQO (ORCPT + 99 others); Tue, 30 Aug 2022 04:16:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231300AbiH3IQI (ORCPT ); Tue, 30 Aug 2022 04:16:08 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A54B7B78F for ; Tue, 30 Aug 2022 01:16:07 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3A4296601E8E; Tue, 30 Aug 2022 09:16:05 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1661847366; bh=RhuI1yWgn6gBmBPlwuNO0blBF1o/qMPbrqYFzGXSElc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I9oUDCAEb9L0xz0DoNFHbqEET2qL1Ufphb+wJ8rP9EgCO/z/ANEHOT9UkG/LBRDwS oITPjXyUNlvIFwVc0RFlLK7qJTFrzAs/gnFnDEEupkCPEGCi8oandZaRei1xIHsPuH ulV+22EC5nFoI2olm6FomJ9ebFU0CWHsvsOWbWCfBtVBk/iTuLbJgRHAGeQXmBnVDx s3/Z4e1iZ8Nao3dY6kaf9UTPqO26x0gZXuj4ae7GCqLWy6YdTttt77s9R6h1tBrOyI krCPKCybm6XUoR/GTi+V/oLbpPD//aIOO+fh/uB1T7BpRsqLxY2AFD4+NsVmd5JVQ7 ocVQ9+UvWrGCg== Message-ID: Date: Tue, 30 Aug 2022 10:16:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 5/6] iommu/mediatek: Improve safety for mediatek,smi property in larb nodes Content-Language: en-US To: Yong Wu , Joerg Roedel , Matthias Brugger , Will Deacon Cc: Robin Murphy , iommu@lists.linux.dev, iommu@lists.linux-foundation.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mingyuan.ma@mediatek.com, yf.wang@mediatek.com, libo.kang@mediatek.com, chengci.xu@mediatek.com, youlin.pei@mediatek.com, anan.sun@mediatek.com, xueqi.zhang@mediatek.com, Guenter Roeck , Dan Carpenter References: <20220824064306.21495-1-yong.wu@mediatek.com> <20220824064306.21495-6-yong.wu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220824064306.21495-6-yong.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 24/08/22 08:43, Yong Wu ha scritto: > No functional change. Just improve safety from dts. > > All the larbs that connect to one IOMMU must connect with the same > smi-common. This patch checks all the mediatek,smi property for each > larb, If their mediatek,smi are different, it will return fails. > Also avoid there is no available smi-larb nodes. > > Suggested-by: Guenter Roeck > Signed-off-by: Yong Wu Reviewed-by: AngeloGioacchino Del Regno