Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a0425472-00ed-81dc-e98d-fbccc1e95575@sifive.com>
Date:   Tue, 30 Aug 2022 08:59:43 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.1
Subject: Re: [PATCH 0/3] Rename sifive L2 cache to sifive CCACHE
Content-Language: en-GB
To:     Zong Li <zong.li@sifive.com>, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com,
        paul.walmsley@sifive.com, aou@eecs.berkeley.edu,
        greentime.hu@sifive.com, conor.dooley@microchip.com,
        devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20220829062202.3287-1-zong.li@sifive.com>
From:   Ben Dooks <ben.dooks@sifive.com>
In-Reply-To: <20220829062202.3287-1-zong.li@sifive.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 29/08/2022 07:21, Zong Li wrote:
> Since composible cache may be L3 cache if private L2 cache exists, we
> should use its original name "composible cache" to prevent confusion.
> 
> This patchset contains the modification which is related to ccache, such
> as DT binding and EDAC driver.
> 
> Greentime Hu (1):
>    soc: sifive: l2 cache: Rename SiFive L2 cache to composible cache.
> 
> Zong Li (2):
>    dt-bindings: sifive-ccache: rename SiFive L2 cache to composible cache
>    EDAC/sifive: use sifive_ccache instead of sifive_l2
> 
>   ...ifive-l2-cache.yaml => sifive-ccache.yaml} |   6 +-
>   drivers/edac/Kconfig                          |   2 +-
>   drivers/edac/sifive_edac.c                    |  12 +-
>   drivers/soc/sifive/Kconfig                    |   7 +-
>   drivers/soc/sifive/Makefile                   |   2 +-
>   drivers/soc/sifive/sifive_ccache.c            | 221 ++++++++++++++++
>   drivers/soc/sifive/sifive_l2_cache.c          | 237 ------------------
>   include/soc/sifive/sifive_ccache.h            |  16 ++
>   include/soc/sifive/sifive_l2_cache.h          |  16 --
>   9 files changed, 253 insertions(+), 266 deletions(-)
>   rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive-ccache.yaml} (92%)
>   create mode 100644 drivers/soc/sifive/sifive_ccache.c
>   delete mode 100644 drivers/soc/sifive/sifive_l2_cache.c
>   create mode 100644 include/soc/sifive/sifive_ccache.h
>   delete mode 100644 include/soc/sifive/sifive_l2_cache.h

Is this series available on a git branch anywhere, I have at least
one other cleanup I was doing in a similar move to rename and make
it usable as the l3 cache.

I gave the series a quick review and did not find any issues so far.

-- 
Ben