Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220826095615.74328-1-jinpu.wang@ionos.com> <20220826095615.74328-3-jinpu.wang@ionos.com>
 <YwtM+/nB1F6p1Ey3@unreal> <CAMGffEmffkW0fHrjx84gQ6FnWuwriRUg=HSdwzU4W_sZLdiT7g@mail.gmail.com>
 <Ywyr0+b350SZrznw@unreal> <CAMGffE=m_Na9n-oHkxm6C2C1sC3U9LkN_7k8Xx9g9SG2ifDjrw@mail.gmail.com>
 <Yw3D7TVgkANv7PDI@unreal>
In-Reply-To: <Yw3D7TVgkANv7PDI@unreal>
From:   Jinpu Wang <jinpu.wang@ionos.com>
Date:   Tue, 30 Aug 2022 10:23:46 +0200
Message-ID: <CAMGffEmyhXEN99_yJpiGJFOtAKGEThz=c2MLw8qbWVn70XnSdA@mail.gmail.com>
Subject: Re: [PATCH 2/2] RDMA: dma-mapping: Return an unsigned int from ib_dma_map_sg{,_attrs}
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Christoph Hellwig <hch@lst.de>, jgg@ziepe.ca,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 30, 2022 at 10:01 AM Leon Romanovsky <leon@kernel.org> wrote:
>
> On Mon, Aug 29, 2022 at 03:19:14PM +0200, Jinpu Wang wrote:
> > On Mon, Aug 29, 2022 at 2:06 PM Leon Romanovsky <leon@kernel.org> wrote:
> > >
> > > On Mon, Aug 29, 2022 at 11:40:40AM +0200, Jinpu Wang wrote:
> > > > On Sun, Aug 28, 2022 at 1:09 PM Leon Romanovsky <leon@kernel.org> wrote:
> > > > >
> > > > > On Fri, Aug 26, 2022 at 11:56:15AM +0200, Jack Wang wrote:
> > > > > > Following 2a047e0662ae ("dma-mapping: return an unsigned int from dma_map_sg{,_attrs}")
> > > > > > change the return value of ib_dma_map_sg{,attrs} to unsigned int.
> > > > > >
> > > > > > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > > > > > Cc: Leon Romanovsky <leon@kernel.org>
> > > > > > Cc: Christoph Hellwig <hch@lst.de>
> > > > > > Cc: linux-rdma@vger.kernel.org
> > > > > > Cc: linux-kernel@vger.kernel.org
> > > > > >
> > > > > > Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> > > > > > ---
> > > > > >  drivers/infiniband/core/device.c | 2 +-
> > > > > >  include/rdma/ib_verbs.h          | 6 +++---
> > > > > >  2 files changed, 4 insertions(+), 4 deletions(-)
> > > > >
> > > > > You forgot to change ib_dma_map_sgtable_attrs() and various
> > > > > ib_dma_map_sg*() callers.
> > > > No, they are different.
> > > > ib_dma_map_sgtable_attrs and dma_map_sgtable return negative on errors.
> > >
> > > It is not the point. You changed ib_dma_virt_map_sg() to be unsigned,
> > > so now the following lines are not correct:
> > >
> > >   4138         int nents;
> > >   4139
> > >   4140         if (ib_uses_virt_dma(dev)) {
> > >   4141                 nents = ib_dma_virt_map_sg(dev, sgt->sgl, sgt->orig_nents);
> > >
> > > "int nents" should be changed to "unsigned int".
> > >
> > > Thanks
> > ok, I can do it.
> > just to check if we are on the same page:
> > For all the callers of ib_dma_map_sg,  would it be better to fix it
> > one patch per driver or do it in a single bigger patch.
> > I feel it's better to do it per driver, and there are drivers from
> > different subsystems e.g. nvme/rds/etc.
>
> I don't know, everything here looks not nice to me.
>
> After commit 2a047e0662ae ("dma-mapping: return an unsigned int from dma_map_sg{,_attrs}"),
> all callers left in limbo state where they expect that dma_map_sg{,_attrs} will return
> upto INT_MAX. However now, the API can return upto UINT_MAX, which is not the case now
> due to internal implementation of dma_map_sg_*(), but can be changed any second.
>
> Can we simply revert that commit and restore the "int" return type?
> I don't see any benefit in having "unsigned int" if compiler doesn't enforce it.
I feel different, the dma_map_sg api since the kernel 2.x, is
documented in DMA-API.txt[1]:
"

int
dma_map_sg(struct device *dev, struct scatterlist *sg,
int nents, enum dma_data_direction direction)

Returns: the number of physical segments mapped (this may be shorter
than <nents> passed in if some elements of the scatter/gather list are
physically or virtually adjacent and an IOMMU maps them with a single
entry).

Please note that the sg cannot be mapped again if it has been mapped once.
The mapping process is allowed to destroy information in the sg.

As with the other mapping interfaces, dma_map_sg can fail. When it
does, 0 is returned and a driver must take appropriate action. It is
critical that the driver do something, in the case of a block driver
aborting the request or even oopsing is better than doing nothing and
corrupting the filesystem.

"
It seems the return range for dma_map_sg never returns a negative
value. I think it's just the API
should have been defined to return "unsigned int"  IMHO. We should
update the documentation in the Documentation there
too. in core-api/dma-api.rst


[1] https://elixir.bootlin.com/linux/v2.6.39.4/source/Documentation/DMA-API.txt


>
> Thanks
>
> >
> > Thx!
> >
> >
> > >
> > > > >
> > > > > Thanks
> > > > Thanks!