Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <80280240-8769-ea25-6348-b5f60d34ef5f@gmail.com>
Date:   Tue, 30 Aug 2022 10:56:05 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH] soc: mediatek: mtk-svs: Explicitly include bitfield
 header
Content-Language: en-US
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= 
        <nfraprado@collabora.com>
Cc:     kernel@collabora.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20220829204439.3748648-1-nfraprado@collabora.com>
 <5a8a2b0d-fa7c-e8c6-bb04-152f8c17aa76@gmail.com>
 <ea7b7b08-cb9a-b6a3-bc7a-050616696e89@collabora.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
In-Reply-To: <ea7b7b08-cb9a-b6a3-bc7a-050616696e89@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 30/08/2022 10:06, AngeloGioacchino Del Regno wrote:
> Il 30/08/22 09:37, Matthias Brugger ha scritto:
>>
>>
>> On 29/08/2022 22:44, Nícolas F. R. A. Prado wrote:
>>> Commit a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros
>>> where possible") introduced the use of FIELD_GET and FIELD_PREP macros,
>>> which are defined in the bitfield header. Add an explicit include for it
>>> so we're sure to have the symbols defined independently of the config.
>>>
>>> Fixes: a92438c5a30a ("soc: mediatek: mtk-svs: Use bitfield access macros 
>>> where possible")
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>>
>>> ---
>>>
>>>   drivers/soc/mediatek/mtk-svs.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
>>> index 64dba9f830f3..f67f3e971653 100644
>>> --- a/drivers/soc/mediatek/mtk-svs.c
>>> +++ b/drivers/soc/mediatek/mtk-svs.c
>>> @@ -3,6 +3,7 @@
>>>    * Copyright (C) 2022 MediaTek Inc.
>>>    */
>>> +#include <linux/bitfield.h>
>>>   #include <linux/bits.h>
>>
>> What do we need the bits.h for?
>>
> 
> bits.h has the definition for GENMASK(h, l), used in this file :-)
> 

Right, seems that some other include includes bits.h as well, as compilation 
does not break. But we probably don't want to rely on that for the future.

Applied thanks.

> Cheers,
> Angelo
> 
>> Regards,
>> Matthias
>>
>>>   #include <linux/clk.h>
>>>   #include <linux/completion.h>
> 
>