Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp3992535rwe; Tue, 30 Aug 2022 02:37:53 -0700 (PDT) X-Google-Smtp-Source: AA6agR6bSwkyG5alxl6GVRARypvJ2Be7gq7h03xWd3lPExmUkAcJbLsALVHJsgj4i08QnClNHOBs X-Received: by 2002:a05:6402:2945:b0:446:1144:f1aa with SMTP id ed5-20020a056402294500b004461144f1aamr19239529edb.79.1661852273158; Tue, 30 Aug 2022 02:37:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661852273; cv=none; d=google.com; s=arc-20160816; b=aGbFJTxEPEbXvGxCvPBxGfBvF189LdoCbmR/mu0FafR8o79MjcGYjzIHMlCUQ6ts5z sxm+ucS88rKmWreAMjVVpTYPaZlXExJ0ERzQQuzRbjppYDZgucgnYEl+FnjHs5WVAK8w OuLMddqpNHAhschC+uFaCAVNJNVD8EMTDV35sgXFZr0bAAFlQlwnGg33sdhybokojy4e WtszBWHerJqx2yHS4j7ojhtD8O8N05ZNm9y0hrsmcYi5EDpGgagrQ8KhgbUaQ5M1bo2A Dif+R0aAYZijTzzCS8YZTrYPfFxMmPBJXCHfizSxs813EPi86MqzlemZKEs4DzLGm15d 1+lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7DbBF1+oaDwBQvC8cRC9cxy+Yq2Vsxw50yfZErPMASA=; b=qCQ5Jp+H3wd1SgZo/CVysmw1oxpc/gDFIEf1Js4pJzp0ARMBRdFam/bg9Koqe7HzEO /lHyr29WPG7RaTooHOnMzzujOFnzoFpDKdhsMncdmjDPYEWGXEoXwMPO5JKTPWQ5bXWw /2LA+ttq/9rh+3WCwtggKB+WGU2PJVyUXBicPXaggLB8JnezTT/mUqIPmyyaVPnbzfx0 KWR2K0QzyndkvAnPjnKn1peS/EgsRO8TH8xfzliRrGLgLJATlLXr5bE7MpnVAFuy/ECX 9l+H0nh9FH+QsoPIZAWsyt2LmmiZr7gcKqyG2EgaxJGDCKcHXwwZeChlQ//L3SDop6S/ DVRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QHRjtpH1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa16-20020a1709076d1000b00729c19c5106si8630883ejc.999.2022.08.30.02.37.27; Tue, 30 Aug 2022 02:37:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=QHRjtpH1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231489AbiH3Icz (ORCPT + 99 others); Tue, 30 Aug 2022 04:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbiH3Icy (ORCPT ); Tue, 30 Aug 2022 04:32:54 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CD0C6D568 for ; Tue, 30 Aug 2022 01:32:53 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id fa2so2745753pjb.2 for ; Tue, 30 Aug 2022 01:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=7DbBF1+oaDwBQvC8cRC9cxy+Yq2Vsxw50yfZErPMASA=; b=QHRjtpH1TXzAXZ6WC+IKgw21HECpC8KBem/uLNhOg0vQcIwSamzdyqro17MpnY/0/W LvlANBt2PduRRiB5Tn9XQ7zQhJhU0LUUjVom+bXKdg1086zex3X82U0Flur5UsOQGzO6 +QtnBOATJesYl7DjuZ6hl6yl71xHogrA8gWVPHIyO+eFfj+Dlki/SmrZ7f23827S/0eB 1scPzxQu5OlizfrcK9q5M7lPlo34XwwKNqOkED0Fm/1/xzBF1PdLS68DXQokPtbCXS7a QNO3pOGfxSo+Dlx/pulyQ4IE6dQroCZGR2024tTr5rgb15rzKV9xwSxEjE4wMy/Y7K+j DJqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=7DbBF1+oaDwBQvC8cRC9cxy+Yq2Vsxw50yfZErPMASA=; b=8DT6RIAe0bJcplP3HJZydjLqjPaeycFYFcqQkyKq1RISzEjsBEEbmkFz3Kfq2XjjEo 8GkDHAv7CYBkGDwQmZ+3FLMhWtc4FF8fqFaKll69MZIjtgOlObTxwtdkrhXrmcmHAVzJ 78Diy7A8rNNQ1lRn1nYq/sLScuw9hZlkyebknFW7lt9/DvWN6nuj9SMS7AaoXPNJUjmW JkJ50acne4Cus2RNLwJ7eqbZ/OTOSdzyJlPu0sqKoCKYrG7d+rVb1nWSN+R6c5VPb1k9 QGi+yLmsJd1OUA9IU3Li7FJ/TXzFude9PswJK9efCC/McFsMxRBsFGNatGe27Zcq2B8L kGqQ== X-Gm-Message-State: ACgBeo36J/D9TjCLUgYic1czwpjir8bhJyjeILii/mbKq0lQMmTrDYw3 ESfBHPO680VqLhxN0uieGQq8n0tJgXw= X-Received: by 2002:a17:902:c949:b0:172:d2cd:a9b2 with SMTP id i9-20020a170902c94900b00172d2cda9b2mr20599799pla.38.1661848372968; Tue, 30 Aug 2022 01:32:52 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id e15-20020a170902784f00b00172f4835f65sm7032761pln.271.2022.08.30.01.32.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 01:32:52 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ye.xingchen@zte.com.cn To: alexander.deucher@amd.com Cc: christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch, tao.zhou1@amd.com, YiPeng.Chai@amd.com, Hawking.Zhang@amd.com, rajib.mahapatra@amd.com, Jack.Xiao@amd.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Subject: [PATCH linux-next] drm/amdgpu: Remove the unneeded result variable 'r' Date: Tue, 30 Aug 2022 08:32:43 +0000 Message-Id: <20220830083243.276646-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ye xingchen Return the value sdma_v4_0_start() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c index 65181efba50e..0cf9d3b486b2 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c @@ -2002,7 +2002,6 @@ static int sdma_v4_0_sw_fini(void *handle) static int sdma_v4_0_hw_init(void *handle) { - int r; struct amdgpu_device *adev = (struct amdgpu_device *)handle; if (adev->flags & AMD_IS_APU) @@ -2011,9 +2010,7 @@ static int sdma_v4_0_hw_init(void *handle) if (!amdgpu_sriov_vf(adev)) sdma_v4_0_init_golden_registers(adev); - r = sdma_v4_0_start(adev); - - return r; + return sdma_v4_0_start(adev); } static int sdma_v4_0_hw_fini(void *handle) -- 2.25.1