Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bd59ecdaadfb5d515a487cf235f5339ce8808f9c.camel@redhat.com>
Subject: Re: Commit 'r8152: fix a WOL issue' makes Ethernet port on Lenovo
 Thunderbolt 3 dock go crazy
From:   Maxim Levitsky <mlevitsk@redhat.com>
To:     Thorsten Leemhuis <regressions@leemhuis.info>,
        Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, Hayes Wang <hayeswang@realtek.com>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>
Date:   Tue, 30 Aug 2022 12:28:52 +0300
In-Reply-To: <d88838ed-f49a-ac9f-5b4c-8e58cabf76fb@leemhuis.info>
References: <3745745afedb2eff890277041896356149a8f2bf.camel@redhat.com>
         <339e2f94-213c-d707-b792-86d53329b3e5@leemhuis.info>
         <8c214c0b-4b8f-5e62-5aef-76668987e8fd@leemhuis.info>
         <20220825091343.2e5f99dd@kernel.org>
         <d88838ed-f49a-ac9f-5b4c-8e58cabf76fb@leemhuis.info>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 2022-08-26 at 09:49 +0200, Thorsten Leemhuis wrote:
> On 25.08.22 18:13, Jakub Kicinski wrote:
> > On Thu, 25 Aug 2022 09:26:21 +0200 Thorsten Leemhuis wrote:
> > > On 24.08.22 13:16, Thorsten Leemhuis wrote:
> > > > Hi, this is your Linux kernel regression tracker.
> > > > 
> > > > Quick note before the boilerplate: there is another report about issues
> > > > caused by cdf0b86b250fd3 also involving a dock, but apparently it's
> > > > ignored so far:
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=216333  
> > > 
> > > TWIMC, apparently it's the same problem.
> > > 
> > > Fun fact: Hayes discussed this in privately with the bug reporter
> > > according to this comment:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=216333#c3
> > > 
> > > Well, that's not how things normally should be handled, but whatever, he
> > > in the end recently submitted a patch to fix it that is already merged
> > > to net.git:
> > > 
> > > https://lore.kernel.org/lkml/20220818080620.14538-394-nic_swsd@realtek.com/
> > 
> > Yup, it will be part of 6.0-rc3. 

Thank you all very much! -rc3 indeed works for me!

Best regards,
	Maxim Levitsky

> 
> Great. BTW, a small note for Hayes and reviewers: The commit
> b75d61201444 ("r8152: fix the RX FIFO settings when suspending") links
> to the report with a "BugLink" tag. You want to use plain "Link:" tags
> instead, as explained in the documentation. Also: a "BugLink" tag not
> that long ago made Linus write:
> 
> ```
> please stop making up random tags that make no sense.
> 
> Just use "Link:"
> ```
> 
> Quote from:
> https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/
> 
> Ciao, Thorsten
>