Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4019031rwe; Tue, 30 Aug 2022 03:13:17 -0700 (PDT) X-Google-Smtp-Source: AA6agR7eN/4i4n4XkYT3J+xjJ6imSwT0SAL7eH/9aNVZySIQZLjTSBMPPKBYFMhe41fmU8x9uXT5 X-Received: by 2002:a17:90a:1b6e:b0:1f5:1902:af92 with SMTP id q101-20020a17090a1b6e00b001f51902af92mr23280299pjq.238.1661854396807; Tue, 30 Aug 2022 03:13:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661854396; cv=none; d=google.com; s=arc-20160816; b=OeYjcomoSAHNSrSPyz65AmkxqiOMwb9QW3c5LCtmWUivZyCR4jP2NFWFi2xEqtKKVU +IVmvz04sIUVsX+T6DH7Nz33blVm53e/23ndjYmr6wo7gCKo8kFSnMQtM9f4K+6lv6Sd t8iIY1CLOIV6/LHYaPFXDBBR/TlHVHNxq7t5zpBmF8/msCt+WGuFsyzSOm8e7WHb03Vv NTpG6DAAZ48q8nLABCobcoUijQ+SUEY9ExAOpgbNcu68SszIyEQX0r5wFEcO0iiH445C RBSmHuTNqSVx4Zo2rKER0mj0i3yL1MHAKPUEARcghMgwU5RZFfHctxJvUjAA1pNMwE1O B4nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=g77AlX2Rbe+FjV2n+wD84q1l3nUQ3jiyIttZF++KeBI=; b=MpVyiZuvC4GcXJqaX4mv4Xe+yFRyL27xn/3vb3TJ/HmmxLtwh3dsBZLJy8Ew1IQ3Fq YG/WdW0zQsNEeRi/WLM4i0fwAzRfsHBYFwslBKeAUVg1Mrfzvxn2HUwh2n5A61KkgiMm wNx1tw0t7oaccIEuMoT82vFzxwBEeuunKnJqOOeEnpNC+Nwl96cZFuHpZ1fs4mJg3JqJ BNA/RBXfkv29AQgY8G4al/Ar9qL0mES4fLq3s6GlaRXD/BfpmwXxfz0C64HsDnAtC7SD OfXP0ujv1UYX8nxBZeVqrKnVtt+yiEinRkUobW+gqDhI5wI1przW+DYkiy6U9+7xgSjK mKnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=AddUnld3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s36-20020a634524000000b0042b57d7bc18si1674989pga.414.2022.08.30.03.12.56; Tue, 30 Aug 2022 03:13:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=AddUnld3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbiH3JqV (ORCPT + 99 others); Tue, 30 Aug 2022 05:46:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229698AbiH3JqS (ORCPT ); Tue, 30 Aug 2022 05:46:18 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7A26A2DA1; Tue, 30 Aug 2022 02:46:16 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C5ACD6601BF7; Tue, 30 Aug 2022 10:46:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1661852775; bh=yjC89saAgBju8ExXt9nwpmDQQR18E9xc86/sSTGhJEQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=AddUnld3tR1MuhWklJh9cxZbTR0S+J3RifWNZeGGGLhVFmcYSHF1zPBERasbYg8uN nxo1Mu92N1gD7OLNFVmCQ0aQV/o/+8bDqhHwHt4boW1gIEhHwQsd/AJmoW2HZZEP1T LI4jeTLXV2F7hvbYf6eGChkbWyi0fTFpivZt42XKQR/K59b7xtQlAofjYQijtWtkvv Jq1HEqkVE4IfUeUTE4TISKWbnoGYlGBJKrmhYkxuds42KygoG3eLOQkOcDGs61UJ41 0txWtrYR1/UujPChcQVQSk+xxth56j0rqCPnGGkQqBeqW4A1Mo7BnmVrMyN9umw8hs fDhQkmniXhTTQ== Message-ID: Date: Tue, 30 Aug 2022 11:46:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/4] spi: mt7621: Fix an error message in mt7621_spi_probe() Content-Language: en-US To: Christophe JAILLET , broonie@kernel.org, matthias.bgg@gmail.com, gregkh@linuxfoundation.org, neil@brown.name, blogic@openwrt.org Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <928f3fb507d53ba0774df27cea0bbba4b055993b.1661599671.git.christophe.jaillet@wanadoo.fr> From: AngeloGioacchino Del Regno In-Reply-To: <928f3fb507d53ba0774df27cea0bbba4b055993b.1661599671.git.christophe.jaillet@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 27/08/22 13:42, Christophe JAILLET ha scritto: > 'status' is known to be 0 at this point. The expected error code is > PTR_ERR(clk). > > Switch to dev_err_probe() in order to display the expected error code (in a > human readable way). > This also filters -EPROBE_DEFER cases, should it happen. > > Fixes: 1ab7f2a43558 ("staging: mt7621-spi: add mt7621 support") > Signed-off-by: Christophe JAILLET > Reviewed-by: Matthias Brugger Reviewed-by: AngeloGioacchino Del Regno