Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 12:24:29 +0200
From:   Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To:     Maurizio Lombardi <mlombard@redhat.com>
Cc:     vbabka@suse.cz, linux-mm@kvack.org, rientjes@google.com,
        penberg@kernel.org, iamjoonsoo.kim@lge.com,
        akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de
Subject: Re: [PATCH RFC] mm: slub: fix flush_cpu_slab()/__free_slab()
 invocations in task context.
Message-ID: <Yw3lXaDTfvJcEM4Q@linutronix.de>
References: <20220829154805.1205507-1-mlombard@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220829154805.1205507-1-mlombard@redhat.com>
Precedence: bulk

On 2022-08-29 17:48:05 [+0200], Maurizio Lombardi wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index 862dbd9af4f5..d46ee90651d2 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -2681,30 +2681,34 @@ struct slub_flush_work {
>  	bool skip;
>  };
> =20
> +static void flush_cpu_slab(void *d)
> +{
> +	struct kmem_cache *s =3D d;
> +	struct kmem_cache_cpu *c =3D this_cpu_ptr(s->cpu_slab);
> +
> +	if (c->slab)
> +		flush_slab(s, c);
> +
> +	unfreeze_partials(s);
> +}
=E2=80=A6
> @@ -2721,13 +2725,18 @@ static void flush_all_cpus_locked(struct kmem_cac=
he *s)
>  	lockdep_assert_cpus_held();
>  	mutex_lock(&flush_lock);
> =20
> +	if (in_task()) {
> +		on_each_cpu_cond(has_cpu_slab, flush_cpu_slab, s, 1);

This blocks with disabled preemption until it completes flush_cpu_slab()
on all CPUs. That function acquires a local_lock_t which can not be
acquired from in-IRQ which is where this function will be invoked due to
on_each_cpu_cond().

Couldn't we instead use a workqueue with that WQ_MEM_RECLAIM bit? It may
reclaim memory after all ;)

Sebastian