Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4066577rwe; Tue, 30 Aug 2022 04:10:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR4XZIAgnUqwPiFPlHBbiVV9f1QAejNV2kQBWqddTaEdiPc6n0jsJnRhbwjad2zqtmyXq3uz X-Received: by 2002:a17:902:76c6:b0:175:395c:b650 with SMTP id j6-20020a17090276c600b00175395cb650mr7497plt.98.1661857805080; Tue, 30 Aug 2022 04:10:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661857805; cv=none; d=google.com; s=arc-20160816; b=kWMMqMTPPSxS6+ZV5ZBOHLjuFT1uVxVPbseNClaPtt+BQXQplIPf0Q7YMYpxiugchs bYncg1kGavECiCdbTnWeFDhxSkrToxqd55s+0n/bzEtt6ZxnBF3uvAh9R4mfTr4i/W4o rRA2cKv5il2HpApiOeBCw5w4+4JFEemTQlxROScHVPXYQO2e2tSK3hCknbrsOm7mkPCr MZh1umTDvib3RXF/wFk3BjxPEWOoMKCF6r8cBkBZvnKilZiNtlf6u2QcoFy98VeG7Sw1 u0ya65XKoiWJALBAonvkvY6eCugdj5Qx5S8dfRffb658S8lxq/HxB/U5q/zkmJWal9+S 5h/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :organization:in-reply-to:subject:cc:to:from:dkim-signature; bh=UCQ79Eh7YtMFKMX+TXJJISTw4b4NrPr18tZuwR0tEgo=; b=T9J5NX7zXRV0Z80Q/VWONgCHzxk6fn+jUze1n2C8IE/5yYYmKI2VkiB1GO7l0L55IS DnP0LbK0nvoPidebxFfFsLDqYrsQ/4ndsBak56thoT7tOd26IoLN82ofzE/3wOOjWvlN i92GiKyIx/WY4qM0YGMySGE6QNk5eRCiITqsrMTKk/R5rp08eTZ8mO0ba14+koC+IeSR s3n9z893A779Dfs8qE/aviitJiyFIRhl7JSvzrdnXf5saDwNPxb8jnI3viXb490HxWCi WMLLInuUQs9pELd7XjljQvG3L/MVgmB9izv4I89Sb324SSK5JjzgJSIX+5kXSMedF9XE VNmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZPqfZqh9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a1709027c0500b001731029cd79si7002671pll.208.2022.08.30.04.09.52; Tue, 30 Aug 2022 04:10:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ZPqfZqh9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229890AbiH3Kn2 (ORCPT + 99 others); Tue, 30 Aug 2022 06:43:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229541AbiH3KnY (ORCPT ); Tue, 30 Aug 2022 06:43:24 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7947D9D67C for ; Tue, 30 Aug 2022 03:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661856203; x=1693392203; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=1JuE3MlMyluva+oTcotxIb88e/kWe/AXbzFxNtVjZ48=; b=ZPqfZqh9kdZL496Ur0JCehwqJi1G0tc2+qDvcTklIgdLwBpDkPOOgYhf 5M5ipuSPOnFQHg9tm8m1AFYeSB6xsbvGB6D+mhKHBhMxDAsRouB1Yv3u/ Pm56NHCxBkJW/MhGnX5vC/AEKCh6PF9uUiuzgtcD7zdOvcN4r0xG58NNA qJMQKaSsiMV11gO9bcBzeqTYe8rtco1D346odGxS2KjJbiAAMj8pLAbyc 8kd7FpnV68i2gAgJtyqfXWIa/nI3oKagteHhWEW0u7ldRYAen8NBhkswf r1HqJK4Mo/JuJ4StBZnG8U5hH8NC/EUo5HxdE1ZHbxCLaq6NHpPwZJnDP Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10454"; a="293885984" X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="293885984" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:23 -0700 X-IronPort-AV: E=Sophos;i="5.93,274,1654585200"; d="scan'208";a="672807662" Received: from amrabet-mobl.ger.corp.intel.com (HELO localhost) ([10.252.41.211]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 03:43:15 -0700 From: Jani Nikula To: Geert Uytterhoeven , Maxime Ripard Cc: Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , Linux ARM , Phil Elwell , Intel Graphics Development , Dave Stevenson , DRI Development , Dom Cobley , Linux Kernel Mailing List , Nouveau Dev , linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski Subject: Re: [PATCH v2 14/41] drm/modes: Move named modes parsing to a separate function In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-14-459522d653a7@cerno.tech> Date: Tue, 30 Aug 2022 13:43:07 +0300 Message-ID: <87czcidnb8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2022, Geert Uytterhoeven wrote: > On Mon, Aug 29, 2022 at 3:13 PM Maxime Ripard wrote: >> +#define STR_STRICT_EQ(str, len, cmp) \ >> + ((strlen(cmp) == len) && !strncmp(str, cmp, len)) > > This is not part of the move, but newly added. The same construct is also duplicated elsewhere in the series, and I kept being confused by it. The above is precisely the same as: str_has_prefix(str, cmp) == len Which is more intuitive and available in string.h instead of being a local duplicate. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center