Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758198AbXFOCAq (ORCPT ); Thu, 14 Jun 2007 22:00:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751245AbXFOCAj (ORCPT ); Thu, 14 Jun 2007 22:00:39 -0400 Received: from netrider.rowland.org ([192.131.102.5]:4319 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751168AbXFOCAi (ORCPT ); Thu, 14 Jun 2007 22:00:38 -0400 Date: Thu, 14 Jun 2007 22:00:35 -0400 (EDT) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: "Rafael J. Wysocki" cc: David Brownell , Andrew Morton , Greg KH , LKML , Pavel Machek Subject: Re: [PATCH -mm 6/7] PM: Remove power_state.event checks from suspend core code In-Reply-To: <200706150046.13650.rjw@sisk.pl> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1439 Lines: 34 On Fri, 15 Jun 2007, Rafael J. Wysocki wrote: > On Thursday, 14 June 2007 16:21, David Brownell wrote: > > On Wednesday 13 June 2007, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > The suspend routines should be called for every device during a system sleep > > > transition, regardless of the device's state, so that drivers can regard these > > > method calls as notifications that the system is about to go to sleep, rather > > > than as directives to put their devices into the 'off' state. > > > > Did you audit all the drivers to make sure this won't break things? > > Like for example through inappropriate pci_save_state() calls? > > I did, but not very carefully. > > > I'd really expect this patch would break things... > > Well, in that case I'll have a closer look at them. It might not be all that bad. One would expect problems to occur only in cases where devices were already suspended at the time of a system sleep transition. Since relatively few drivers currently implement runtime PM -- and those that do are likely to be more careful about not blindly making state changes -- there might not be too much trouble. Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/