Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
CC:     Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 14/14] iio: hmc425a: simplify using
 devm_regulator_get_enable()
Thread-Topic: [PATCH v3 14/14] iio: hmc425a: simplify using
 devm_regulator_get_enable()
Thread-Index: AQHYtAEA9W3+BCv32EieMGPzk+WDc63HZFsQ
Date:   Tue, 30 Aug 2022 11:49:07 +0000
Message-ID: <SN4PR03MB678420C67AA8988CF706198399799@SN4PR03MB6784.namprd03.prod.outlook.com>
References: <cover.1660934107.git.mazziesaccount@gmail.com>
 <8b1193fdefb231a6d721e2bded52c48e56039c20.1660934107.git.mazziesaccount@gmail.com>
In-Reply-To: <8b1193fdefb231a6d721e2bded52c48e56039c20.1660934107.git.mazziesaccount@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?d2BPRi8zRANe9CnlPryclAcec7ytC6v8UfcucqIf93DmQiHD88A8aYOBr7?=
 =?iso-8859-1?Q?xPj6w7gV9dy199xQEqa13/Q7Sg/gqhXQuJNrxR2kdRkatH9gBGYgTU/jt9?=
 =?iso-8859-1?Q?mIit9kliN/LCt1vCZuS2/3/VkayzvGer8YKc5BwinJKSFQJYPO62RuLpjK?=
 =?iso-8859-1?Q?fJdpcpdNiuYRxSvHtvf8toNpgOITSQbmt0EsXR4YX0RQFaFRkQOq0PB768?=
 =?iso-8859-1?Q?ZPURGgF1iiJc1Q1UFR/dDXz3HW3U2mrW1SLGexvNZwSYY4pJTm6ECmtr8k?=
 =?iso-8859-1?Q?dG2XYDX8mle1u4KA8MLJoSCkrc3Wt9eHltNSE0sNl15P7COpgXdBq0vpc2?=
 =?iso-8859-1?Q?Tjx7MueXXp/8JsX+fpqNBdq53IqmUHctD4DxOmLy5uvx7TAVYJjEEMW22d?=
 =?iso-8859-1?Q?rMVb4j1QZIlYdpDDNdTynMaAZ1J5QTppH8m1Yb8aMID5pgGg1cumCS+k5Y?=
 =?iso-8859-1?Q?78GxA408gauJkOD2I0fO4k5eyXkzNs7V2JShHCCPKwnL2tDc9rDZuFENEI?=
 =?iso-8859-1?Q?ZqAp965kJ+Jak9NZi2+JcLmWoGNHfBodIJrQnsR3i1+ei5I9UPLxJZiz1D?=
 =?iso-8859-1?Q?uPnNeh7YU7tXbnIQiSfOXIxhUBkzzTXan0bu+T8xeHB6DqIHQ4I7YTg3fo?=
 =?iso-8859-1?Q?/i4ATYNh2ClUC1C6r9PmoOwJOdYt9FbvbNkLesoiVz6J2QvkcqeeRRDFSm?=
 =?iso-8859-1?Q?EpI1vY9h29MzDwK0vDDVC2HAwqQjVxpVcKuLHPfWuWm5bRt9PGW7FVsUB2?=
 =?iso-8859-1?Q?mIXGTKj9VWQvAANoMGoF4ze2SP+wNwsKI+ngzYBYmGHDQvgH+MntTuOxQE?=
 =?iso-8859-1?Q?ss6JZXqWYx3DBNo9PQOoLchicjWp9Vu+LEfzs5HPIAA3IvOPyofRFDO+ol?=
 =?iso-8859-1?Q?YIERhm6jjMjpYHcKM9d5eST5xssrMpmpKf4luxp8BxJEc5PygAkV9QpZBg?=
 =?iso-8859-1?Q?RVM1lKHDibAxfjLR7EtVxUml2H+jhfXtfs4PETvW9MEKyGOAYe9xlkpI/H?=
 =?iso-8859-1?Q?dN4R06yM/AHqM8dH0uWsdPdZuV+tuFWLywpGz9eONMWO6+WGop7Vi7LFtt?=
 =?iso-8859-1?Q?fkCKPsZyVQNvexNuRjid4GVYvgg62ErH+x0AEFVY5A+EHesCeozw6dgsXB?=
 =?iso-8859-1?Q?2xX9mxmeGixpb/ohvGQR6pF44mVu3HdZrRljOiuWavJK3PKebTI7Q+1LNu?=
 =?iso-8859-1?Q?vERuU8Ihk+0ROY0oVIP2KOyNUdSGHirc5d1p9+6m20zCp9N7cnD6SHkaTt?=
 =?iso-8859-1?Q?cqaItSfptLmCTVUwMc60d0ilzptvKrgIwmxeuKpnqmcobBY1k5eFarzQ3X?=
 =?iso-8859-1?Q?g7DZMTRUGfy1bon6WUaor3nT/ke1h3s/3VbjsYUVMZv3SLnL3u857Qn2qG?=
 =?iso-8859-1?Q?eDUb+lwfo16tQXD9N6lr1ItlIJQSIsvXgiOzA5jV83TQQIiQ+czHYZg2PF?=
 =?iso-8859-1?Q?pX0BI4TtEI2aV/jraN2IaI6mABOBzGP22GcbBjwTHkV0YiUlHb9jwQBUK3?=
 =?iso-8859-1?Q?xh/1ZqLzv38CnmUAgXocgEx32n0j5QYJbGZy8NzzKC+zwo+FcMjjVxmoBn?=
 =?iso-8859-1?Q?ErGqkolHu2gW3B7GmtI51jCXB09xcv0ZcgQ2eN8dY9bpYxTpOTxIzrp560?=
 =?iso-8859-1?Q?ZsMP9mi1QY9ZU7qrPWYbOmR03T1hvWQYM7pbM8seMVqWef70kIg8zSWfTf?=
 =?iso-8859-1?Q?Y3ymAGVxyg+V+8I7fzOi+ojIfNFQkZzVuTVIiYN4?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR03MB6784.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d971729-2301-4f7c-de5a-08da8a7da535
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 11:49:07.3037
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: A+iNrO1um7AjFHTkpmAu4tnKLZtijKrXFaoe49JgPTsw7zNBgfM3u7s6aGIyVCPUdSHXJWxiBd03mz4t5JM8qg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5139
X-Proofpoint-ORIG-GUID: wmqod9lXlfK0ADE_vCoxrgFu6dJxOK55
X-Proofpoint-GUID: wmqod9lXlfK0ADE_vCoxrgFu6dJxOK55
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-30_06,2022-08-30_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015
 mlxlogscore=781 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0
 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208300058
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> From: Matti Vaittinen <mazziesaccount@gmail.com>
> Sent: Friday, August 19, 2022 9:21 PM
> To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Jonathan Cameron
> <jic23@kernel.org>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v3 14/14] iio: hmc425a: simplify using
> devm_regulator_get_enable()
>=20
> [External]
>=20
> Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> add_action_or_reset(regulator_disable)' and use the
> devm_regulator_get_enable() and drop the pointer to the regulator.
> This simplifies code and makes it less tempting to add manual control
> for the regulator which is also controlled by devm.
>=20
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>=20
> ---

Acked-by: Nuno S=E1 <nuno.sa@analog.com>

(I see that in this patch you are not using dev_err_probe(). Maybe some
consistency in the series and where applicable would be appropriate :))