Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4113672rwe; Tue, 30 Aug 2022 05:02:57 -0700 (PDT) X-Google-Smtp-Source: AA6agR5Gv1WFV9fQAAoP1J8BnTSpdwPTJjMXiVLaav28Xvs0fASTRh0VpuXBeDC16iu2AISr6+mz X-Received: by 2002:a05:6a00:1943:b0:536:2bef:2f93 with SMTP id s3-20020a056a00194300b005362bef2f93mr20495038pfk.34.1661860977084; Tue, 30 Aug 2022 05:02:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661860977; cv=none; d=google.com; s=arc-20160816; b=u1MqVcl1rYfevZSpujZz1VlW0d8tqAoz2DivRL1mYxst9lhDi7HP/4M75+WVjykeSV VFu/hCHPWnZNlP56j0ONQiwZgD+xWH4w26nawZisukHWOlALLqlVTuoziZlEfroc1snO VpzxbvNazyESNXVKyvC9NMFrMOl5uMbutTJdWiDPmOYnazVm0Jr/wJcQSBKBdZ3mprev r1r2eVkXJ/ECJVjh/wHtbL3rbYVBLjUCu8M9Z3NT2uc2+/Bh8BksWw8V9TedCFRxLMGc HcqUu8s8oNoziu6npOM/B4nrJETREOALzoR2gSp4ZXBjcXQWF+WKNSORyirOPSKCjdgp rgzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=BYPKBaVzqChOBBkldjgsHTMpEu1dO1kgOIrcOiNxLbs=; b=OhVoAOXCsqLfZYDhGDGpdYyOT5zpflfgzTCi/NBQrpJHvCGqQ0Jaud0RkiXNNzMAXj cSc2j2nR2o3XmGAcc2gcY19bGHP9kQJeJ8E047Hv4j/o+8whLmgaGRHzWssJQAJ1lppn RDgZzka6rsK51/lrR/vcJfm5V/4fBCY8iRgQfhwgKb9AulOq+tb/LuM/SCFC8DmO9LQc czUx3XZSsYAPVXgyj2vAg4Qx9V9CrfZ4+KcKjBsE5rTa/FmUkDPMYKWhiryiV2muo+Z8 sHPS8XG2YE6ojWq8WFcBVhh+LVoAsQgN3OwlrDzdpXrYFqhBAvQFGwcEKG4scRdCGane LJkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r5-20020a170902e3c500b00175374e34cfsi291155ple.452.2022.08.30.05.02.45; Tue, 30 Aug 2022 05:02:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbiH3LtI (ORCPT + 99 others); Tue, 30 Aug 2022 07:49:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiH3LtG (ORCPT ); Tue, 30 Aug 2022 07:49:06 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 525A5A7AAC for ; Tue, 30 Aug 2022 04:49:05 -0700 (PDT) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MH58j0p05zkWTJ; Tue, 30 Aug 2022 19:45:25 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 30 Aug 2022 19:49:03 +0800 Received: from [10.174.178.55] (10.174.178.55) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 30 Aug 2022 19:49:02 +0800 Subject: Re: [PATCH v2] ARM: Add sanity check for dev->periphid in amba_probe() To: Linus Walleij , "Russell King (Oracle)" CC: Saravana Kannan , , , , Kefeng Wang References: <20220830065413.638-1-thunder.leizhen@huawei.com> <2452e7b0-d4fd-2e27-a336-bf87b85a8d50@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <81775dd3-d9ef-36d7-bdc7-b578c5d617a5@huawei.com> Date: Tue, 30 Aug 2022 19:49:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.55] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/30 19:19, Linus Walleij wrote: > On Tue, Aug 30, 2022 at 12:37 PM Russell King (Oracle) > wrote: > >>> ... ... >>> driver_probe_device(drv, dev); >>> ...... >>> dev->bus->probe >> >> And that makes no sense, is an already known issue, and there is a patch >> to fix it: >> >> https://lore.kernel.org/all/20220817184026.3468620-1-isaacmanjarres@google.com/ > > This patch to the driver core fixes my QEMU issue as well, I'll try > to reply in-thread. Thanks for pointing this out Russell! OK, so that my patch can be dropped. > > Yours, > Linus Walleij > . > -- Regards, Zhen Lei