Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-841-g7899e99a45-fm-20220811.002-g7899e99a
Mime-Version: 1.0
Message-Id: <78451bb1-e4d2-457a-adf7-8fb61be0fb3e@www.fastmail.com>
In-Reply-To: <4ff2a310-c8ba-ccf2-8d51-5181b83685c7@loongson.cn>
References: <1661766931-7277-1-git-send-email-yangtiezhu@loongson.cn>
 <d1a52fa2-380a-421b-8c46-5150a39be484@www.fastmail.com>
 <4ff2a310-c8ba-ccf2-8d51-5181b83685c7@loongson.cn>
Date:   Tue, 30 Aug 2022 13:37:05 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Tiezhu Yang" <yangtiezhu@loongson.cn>,
        "Huacai Chen" <chenhuacai@kernel.org>,
        "WANG Xuerui" <kernel@xen0n.name>
Cc:     loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] LoongArch: Fix warning: #warning syscall fstat not implemented
Content-Type: text/plain
Precedence: bulk

On Mon, Aug 29, 2022, at 4:34 PM, Tiezhu Yang wrote:
>
> I read the commit message in the commit 82b355d161c9 ("y2038: Remove
> newstat family from default syscall set"), I am not quite sure whether
> we should check __ARCH_WANT_NEW_STAT first, like this:
>
>    #ifndef __ARCH_WANT_NEW_STAT
>    #define __IGNORE_fstat
>    #endif

No, the #ifdef is not needed here, the entry just means we
no longer warn about the missing syscall because it has
been replaced by statx and this is true regardless of
__ARCH_WANT_NEW_STAT.

       Arnd