Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <31aeee3c-f4f1-16a8-272b-96da5d4a565e@suse.com>
Date:   Tue, 30 Aug 2022 13:54:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] usb: add quirks for Lenovo OneLink+ Dock
Content-Language: en-US
To:     JFLF <jflf_kernel@gmx.com>, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220824160946.10128-1-jflf_kernel@gmx.com>
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <20220824160946.10128-1-jflf_kernel@gmx.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjhhWmdhK3hWQlFlUElNa3VYTzlFNDEyRTIzRmhkN1pVeXNpeDdxL3BwTUZu?=
 =?utf-8?B?bGtiZ0xLam5SQlE2eXhkVW45Z3hwdEd4T1NiaHh1Q01UUlZmYVlhMUR3WDJj?=
 =?utf-8?B?YjVwRVYwVGNQWjI3V0IwWGY5WGx2TTZwVHJRSktIVGZxODluZFU2RUhKOFlO?=
 =?utf-8?B?ZWFoQWR3VStJUzVIOW5GQTArdk9nUm5Fd2xLelh1cmdseFZtaGI4TEg4MlZW?=
 =?utf-8?B?aE1JZnJmVVJ3eXdIRjZFUENMeHdNU1lHeE1jcTZzM2hBWlEzN2NpRTZGVmhu?=
 =?utf-8?B?RzI4OStEa28wY1lwMjNWQWNxazQ0TGIxN09MRmRhdGpLU2lsamFJRVkvYzVv?=
 =?utf-8?B?cE1YNmtGSWRpSGVtVzZScXZGT3FFSnN0ME1GSWYyRXhXbGpwRHVTUGI3MjRU?=
 =?utf-8?B?TXhTNXNZZy9FelZFZnFidHNJejdnTVVKdGp5amd6dVlCVU9pVWZJZU1RbEJo?=
 =?utf-8?B?dTB1aFB6eGMvQkM3djVoZDl6THNaOTJQeGhQNGY1Y2xyVWR1QmVBcjFTdmNv?=
 =?utf-8?B?eEgvWmZvemVITU1vcDduRHRYUjBKZjV0QTc5YVFzV05Halh2QVV5UU1lWU1z?=
 =?utf-8?B?MUcwbjJnSW9ER0tBd0NmU3orS001ZWJZUVhCWDQ1KzI3VHZtV2puSkZPd1lh?=
 =?utf-8?B?NWgvY3ZqWHpST3NDNVVRSk1Td1R1VFExK0RreWNtTHBCMURjbVVNb0p2RHgy?=
 =?utf-8?B?V2hzbnBQMDVRbjh4OTk5ZXNBcFFab0paUDl2REdRUWFoY2xRd2xRcHhrajZU?=
 =?utf-8?B?RXlXTnp0N2MzMExYamkwdG1UZUNJdkVHcFN2Z08zbDJ4d1Jyd0YrZ1JuZVRv?=
 =?utf-8?B?alpOOEdBdnFVWnM5NUdXdSt4emxHdVZhQlBYUVJ3cGdUdzB3ZGJBNHhxeDBZ?=
 =?utf-8?B?Rjd1MjNTVHhDK0dveHhQM0NtSG1RQzVmdjJJenBHTHcrRThFdTJ3aHByd0dO?=
 =?utf-8?B?Q3NsZVEwL041MGVoTVlYTFU5M29DWTAvZjVnT0c5eDJ3eGtKUVVYZkhhdWtC?=
 =?utf-8?B?d0V5WmpscDJPVkh0RCtlOElyN1ZWODhmR25LazJHSHFZQUNxd3crM3R2NSti?=
 =?utf-8?B?Tk1QWUxSM0tHVmEzcjJGbHg1aUxmRFp6YkV4N2F6YUFYOEdaUWJGTHRBR3Iz?=
 =?utf-8?B?eEorUm9SY3g0Zkl3aUJvRkwzZkxVZWdpaVc0YXlTNmwzb1c1Tm9HRENndy80?=
 =?utf-8?B?R1V3QU5Zd0NjM1NCaHN3NllDYlRwM2dUTC9POUYxSGYwK2xnVW55N0dwZzg3?=
 =?utf-8?B?V0F6VnAwYTdoZkVzRmc3MVZLMzErRTZvZmUvY3k4YVZWbEl5Z2ZQYWFVRnlz?=
 =?utf-8?B?Wm4yS0NpV3pQMVR2VGM3TTluK1JUaFJmclNub1FOaklrbEIvTXk2dGdLVUEw?=
 =?utf-8?B?Tk9obUFlY0NjNm9wSk1hMXdxOFdoVWQveUI0UHgzMVdicGp5UFJuQ050T3Nk?=
 =?utf-8?B?d2QzVHNkcXBTYStYN0dhdFRiQmZ1WDNyZUNCVWEwTE5Kcm0zbHJzZHBsVEVO?=
 =?utf-8?B?U3pmcVNiZURzUXlMU2djYU5EOHNKalpNcHVXckQwR0M0NTJranlBUm1QV0ha?=
 =?utf-8?B?MkxRVit3TGgwOVVQRzVvTlFiUXUvM1Z1dHByeU9XaHhjdlUvM2tpSFhhQ25a?=
 =?utf-8?B?NEM4ckJZQjAxME5NTU9WV2pEcEtyWmJlYWpkcVdyRU1HNjNaRitRdjQxaUNJ?=
 =?utf-8?B?VUlKeDlhNjB4UmFseDIwaDhnNVVwR0dPN0FSUTl5d3dhMHJKanZxblpQY2Ey?=
 =?utf-8?B?K3Y0MVBZNWpBZEtKNXF1cHUrZlFVSG1SeHVBZkFaY0NBeWhZM2VYNnJyZW14?=
 =?utf-8?B?Nllsd0xYUWZiY0NPcno5a1lTWkNwWjlpVlRKeDFRN0U3TEllVldEMG9RaUUw?=
 =?utf-8?B?ZkZmTmZhZmZWUGE0THNndnJ6ZmNlMmIyOFBlQUdxdFBJekxYTHBNWXdVL2hn?=
 =?utf-8?B?V0lvTDNiU2F1aFFiSG1yUGZ1TnU2L085eEUxaTNiL0RDMFczMCtmUG1BMndk?=
 =?utf-8?B?NEJqL0xpb0lDK2R0b29ha1BIc1JrQWZFa1lDSjNHK2xwTEw3NXdGaWJBVUlM?=
 =?utf-8?B?dEVhZEZaVjQ2SjhTRE1kQlFEMnNBS2YwLzF5cVdodGNVRU9MU2hvZWw0Ly82?=
 =?utf-8?B?ZUdqOEZMUXJnTmxyUHNNZDdlZ3hlTnVkcDREUGZKMTVJNVRaUTczbG50SmNp?=
 =?utf-8?Q?LxbTlCDD5eMzGgdz/737s7Y=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6d0b878-309f-4516-699e-08da8a7e6ea7
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB7104.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 11:54:45.4730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rDT0N8C75ESQuvptj1sPl+f8Q/SiVMjM2BJLlfWzQj8wvSLODxEY2+qTXxjCimL5Ux5n5pKiNxsTT9qYRCJT/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7200
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24.08.22 18:09, JFLF wrote:

> By process of elimination the controllers themselves were identified as
> the cause of the problem. Through trial and error the issue was solved
> by using USB_QUIRK_RESET_RESUME for both chips.

Hi,


aside from the aspects of getting this properly signed off and merged,
this opens up a question. What does resetting a hub do to its children?
That is if the request to wake up comes from a child, do we

a) lose state in the child?
b) retain the knowledge which port requested the wakeup?

How far has this patch been tested?

	Regards
		Oliver