Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Matti Vaittinen <mazziesaccount@gmail.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
CC:     Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 11/14] iio: ad7606: simplify using
 devm_regulator_get_enable()
Thread-Topic: [PATCH v3 11/14] iio: ad7606: simplify using
 devm_regulator_get_enable()
Thread-Index: AQHYtADN/0Q916d43E+uEs0Mg2tsBK3HY/Wg
Date:   Tue, 30 Aug 2022 11:46:38 +0000
Message-ID: <SN4PR03MB6784BE44D4A6DCECA0859C5F99799@SN4PR03MB6784.namprd03.prod.outlook.com>
References: <cover.1660934107.git.mazziesaccount@gmail.com>
 <521c52f5a9bdc2db04d5775b36df4b233ae338da.1660934107.git.mazziesaccount@gmail.com>
In-Reply-To: <521c52f5a9bdc2db04d5775b36df4b233ae338da.1660934107.git.mazziesaccount@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?oygkEZ57NhAaljJPWe4sSQnINFU7mX/mOr9KBBIlZOTlwCwdVnBki4sBGp?=
 =?iso-8859-1?Q?/ZaNHlVuzbjezOdFCCcWdPSCWkXSfHW6CqILOjTAh0DBMWGuTTxUTqzZpu?=
 =?iso-8859-1?Q?3N9Ue1aj3l55mlEEjwLxFlJQ9GclgsHcJUzCqVVof/2qWt4cfnC6FaoX+x?=
 =?iso-8859-1?Q?UBTGcapnYWTQmGZI1UI9sbCDKSUwb3HOY6Af1G1DdYR1uhgL4gj54mn7dE?=
 =?iso-8859-1?Q?J+nRAdCTHVguWxPFM/50R2a4NeTtBm1BPcg9F2hZF/VlZr14wE3QJuJSTD?=
 =?iso-8859-1?Q?Ae8zn0kZuFEHg3B8TytIqjQ1bNjKCZ/miIcbyjn8rCckdiipVvwegubqYr?=
 =?iso-8859-1?Q?3yS8IoJr9xhiVvFSlajyUqYJi8MpgWD3Paj456kkmWegIVWME+uPyMXod7?=
 =?iso-8859-1?Q?AKEigs24072RrY867MzCoVUh3u7t0iiqEgJkC2ZaNaA/FaeU41Qc+8G/vt?=
 =?iso-8859-1?Q?JR+nLpOoZWuz4BAfSFDLdq9/xqpGXHcnoXsilL7VxLHREdnFUxU4ueOhjY?=
 =?iso-8859-1?Q?i1faOlQBZ+9edXB6uXDnEuq2ffrhX7xD6Ln5H/F4XKtmU/9zXKTLJ5VHuN?=
 =?iso-8859-1?Q?ikIKBWHZyvtZt3Gi2sy3NGcdwwcyims2m78XfbI2BfwZQAziW+OkmcQtnB?=
 =?iso-8859-1?Q?sPsR/ga2doGEdmDxD8KI30qnz+GxCelT8d5ip1urxIjxYA0mJqzc1XOygF?=
 =?iso-8859-1?Q?oN/rSOY9GPDKNbSWi54TwPQEzjqwa1dex4N4dZDFWGfKj1oDH4q328//gK?=
 =?iso-8859-1?Q?Gvo6Nw+r3wW00Q0Ec/eTDOfwIyPfcFn37Jc9n7WWrrAM2AHJhf1jKNDGaA?=
 =?iso-8859-1?Q?KOpE+ahZaJppk+BCsJqXr3wRdKSMHMiL4QPdGT5/0Mv5L3jnoK/97lO28w?=
 =?iso-8859-1?Q?6QoH5NldbReebf672QXNeWxximksk/TioIqKPq+Y9AyYCVdNn8wGaeUXWA?=
 =?iso-8859-1?Q?wWy+2BFIzYuBou6kGPU2/8cEr8rP7TpBTweb1d3Ama+wsErX4iQKJaZGdS?=
 =?iso-8859-1?Q?Pp0CSaiWGdQUSKfXl5Knd1KOuikpveEseIyUa7pKadPbD1F/U2MsmfFdv8?=
 =?iso-8859-1?Q?Lp1F2+0HDKaF2+uUuJLpWYu9b7kgU5ODNIjaTvIRyAog4bEZLly8oZRNeK?=
 =?iso-8859-1?Q?hJKZUlohduTYIZMAdoMJL7EjxFO2Q/JDT+OpGq+WD0IxqW4Eej7+3Rnb0d?=
 =?iso-8859-1?Q?TkZ4p77oskmM1tysvC4QfPzSxrH6zMzzSn0ziSPRbHTw+G3L4kw9wXeojG?=
 =?iso-8859-1?Q?WA58DEWy3Bxhv8oliySvlqHc4L6nAIw20QrXn4OIsBu7g6ThdZkb+zHT1B?=
 =?iso-8859-1?Q?GYZF0qMYS3bnx73RABgC6Oz8AVkiH3v7EkdfRvEHy8k+1N4+Q3kVA+GKs9?=
 =?iso-8859-1?Q?Y5q2fHO3yBgSCua0TLgO0TIkXm0CLAj+PAsQbPv/Z7RJiuCKhHmvWLeBMp?=
 =?iso-8859-1?Q?FoQ5QG2vBGibwgcd71LoTxfbXZDnV1ZAFd4aiN8O3lYgUkc6/DYNbL0kFL?=
 =?iso-8859-1?Q?O/Z3XdNWk5BzHYPwZ5XWs2wcWKL6+KvymrEdIKs7ehoE40+QR4vVRP+CZZ?=
 =?iso-8859-1?Q?PGf1c5KWl0sXo9aCt4lm5ZYxAfoz4t81DlGrLAT0Ac/3s1VDiroAIWezhR?=
 =?iso-8859-1?Q?nRzPNeBqXT4bHBUOp70DImF+3/EdAR+KdbMcJ/N/AlXu51ePFoOiLBZ4rc?=
 =?iso-8859-1?Q?J6lzA1f8CHtm5l7ma3UTm1a0bX7HpzkmOsLgLjbs?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN4PR03MB6784.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59011f84-1a14-447b-961e-08da8a7d4c73
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2022 11:46:38.3910
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 8Ea4OQP3t0cxgKwdU7JqOBK2xmlwUMd6ZoEtpK3xY+YIIGhyeSfJVaGANyIITSMI8z7pqh0UrNpvfCgdnr+iFw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5853
X-Proofpoint-ORIG-GUID: ebnYtGt62cKxwxv1Q_aPrvA_mipGpwBR
X-Proofpoint-GUID: ebnYtGt62cKxwxv1Q_aPrvA_mipGpwBR
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-30_06,2022-08-30_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015
 mlxlogscore=867 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0
 adultscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208300058
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Matti Vaittinen <mazziesaccount@gmail.com>
> Sent: Friday, August 19, 2022 9:20 PM
> To: Matti Vaittinen <mazziesaccount@gmail.com>; Matti Vaittinen
> <matti.vaittinen@fi.rohmeurope.com>
> Cc: Lars-Peter Clausen <lars@metafoo.de>; Hennerich, Michael
> <Michael.Hennerich@analog.com>; Jonathan Cameron
> <jic23@kernel.org>; linux-iio@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH v3 11/14] iio: ad7606: simplify using
> devm_regulator_get_enable()
>=20
> [External]
>=20
> Drop open-coded pattern: 'devm_regulator_get(), regulator_enable(),
> add_action_or_reset(regulator_disable)' and use the
> devm_regulator_get_enable() and drop the pointer to the regulator.
> This simplifies code and makes it less tempting to add manual control
> for the regulator which is also controlled by devm.
>=20
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>=20
> ---

The commit message could state that while doing the change, dev_err_probe()
was also introduced. Bah, anyways:

Acked-by: Nuno S=E1 <nuno.sa@analog.com>