Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4159754rwe; Tue, 30 Aug 2022 05:46:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR6YWpEC6LvB/1mZMrUW1RTAWKh2ei74n6ZkYatg40xHmEaonKlBBBL5p6DsqWGw+MsmRGWF X-Received: by 2002:a05:6402:11d1:b0:43e:33b:93fa with SMTP id j17-20020a05640211d100b0043e033b93famr20825487edw.419.1661863584977; Tue, 30 Aug 2022 05:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661863584; cv=none; d=google.com; s=arc-20160816; b=eFJ4O+7S8BVkcvttSD/Qv4H65Ytn0/tLMBRQ+XJMhUtcbnFW4b0nVwABRan48yEKJw aMFhz0cu+dyaeOlhujo0Ro3SyKyY0LiCnJqWxqd8WQjW1u0N/vg8g8hMKAeq+h+u3aA1 3GhqK9uJKjI3eNq508WjwEVKnGDN32htDHZ+gz2EHibsIOVDQUG0CxYmEwEqsHOU6HCo e2R+JloJ0N/W/o6ERo0AnWwtoYaPJQSwKcGhBgi+1cPT67rtRKgoBHBq6ueCgCh8RiZ7 5tZmTsfQ6FMRYOZWsdgUXH4iWGqkcjH3n5vT9qBJcaTmQHx0Rv+ux+kCZrkv9/XHNv2N NAcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=RosJjL90cAKk8uSdr9CJIuOaF3I17DjvXgS99fE9MgU=; b=0Y/8JG0VmOguDWRExEby516OGm8cy5T0BMFq0k/xhsl9OgueGdVQgYwxrXDtRn03o2 3mAKhQsckW9ijOC6E7By8Ld4XjVhMt15vyvIkT2Wt1mknFmUv5HcTauPA2G2vRWMV0Rh MYNh9RGwobZw8I/tqP7aIVq+Gu6DYh9hKAT8eu3RtodenM9TKf9DjnLYzuLTPesyI299 iKR9OUXCzWgkv4t9lDMS5kk2XRhV6PO8UvrzZ4J4nYZcnLaukkkqE/FNyGDE8uKyFuyZ eStZHhLsb3skHR4a+vZW6k2gAjHwvIg/7FghzR7xRo/joa2dXSsCiQdg/x+EKKxMOmaO 7YZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IGahwIj8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m10-20020a056402430a00b00448b1b2d946si2325350edc.261.2022.08.30.05.45.58; Tue, 30 Aug 2022 05:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IGahwIj8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229881AbiH3MoZ (ORCPT + 99 others); Tue, 30 Aug 2022 08:44:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbiH3MoW (ORCPT ); Tue, 30 Aug 2022 08:44:22 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FBF2FB0EA; Tue, 30 Aug 2022 05:44:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A68EBB81B31; Tue, 30 Aug 2022 12:44:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED835C433D7; Tue, 30 Aug 2022 12:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661863458; bh=MZQXd4iBfxW6ysVrR9tBCuwjlhyECO+K8YtLNNSq1Lo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IGahwIj84I+2asPqCN04jkMh7YuHrFE6KFmvJpgjuFNOJgB/bRA0EQvLZAlOQXxK8 Pf+vq0B3KQXonc1GRuBQHKB6cezzIuGn8JmEpxa4zvCUBqsWl2X3JC4MwReOicjFy5 W2PGSrGX5txNpphH/Hs1wBM5ApMpgL90upGbBxiA= Date: Tue, 30 Aug 2022 14:44:15 +0200 From: Greg KH To: Ray Chi Cc: mathias.nyman@linux.intel.com, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, albertccwang@google.com, badhri@google.com, pumahsu@google.com Subject: Re: [PATCH] usb: core: stop USB enumeration if too many retries Message-ID: References: <20220826075839.292615-1-raychi@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220826075839.292615-1-raychi@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 26, 2022 at 03:58:39PM +0800, Ray Chi wrote: > If a broken accessory connected to a USB host, usbcore might > keep doing enumeration retries and it will take a long time to > cause system unstable. > > This patch provides a quirk to specific USB ports of the hub to > stop USB enumeration if needed. Where does it ever allow the port to handle new devices in the future if the device is removed and then a new one is added back? Or is the port just now dead for forever? thanks, greg k-h