Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4165755rwe; Tue, 30 Aug 2022 05:53:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR60AV9eZd1CygY2eVaJRgkwwkSGI7l07NV2QXKSkoWe+PcyeAusRihq5sWTYQXskk3AC7c9 X-Received: by 2002:a17:907:b0c:b0:73d:dc7f:4b8 with SMTP id h12-20020a1709070b0c00b0073ddc7f04b8mr15484433ejl.183.1661864004835; Tue, 30 Aug 2022 05:53:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661864004; cv=none; d=google.com; s=arc-20160816; b=uBmYrFCM+6FY4Iaba8PBSEtrd1k4yJgogu/cbCQ+aiux6SZ/4heVP/EkPD65C2dL1u TGx1Y/g3lHVJkOAZDSA8alqirSzNVDO86WN5zKAH22tnYdHAUTTaui/WOc2gOlHp+IT0 veZVPHxpqnDk2+kchFj4X59vZZAtHyWYdfYCUJzUMHVxupfrGrqSzbaraJwdbDVz8LzA cgaSN9ErLdooQ58GT504eATRrVZARLydYx58IuuFnwhI7iAGhlTwuxlgU93xZJ44bq5w U3+y7MEuE7+98SPkpvuhqJPg+G/tISS9Dk6Zm6fqmdmNjoYK3fhlX0JizgO0zaM5bBn6 RufQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=bxEv67fSzvy2QdFJ3FHWnxcO/blrsBvebrDHnbUNosA=; b=w3l+/NHViB3LFfkf622JRGgDTLiCkV9JvprsLks0Z1g/KKnNuY8LfRAMeGHqWJEK6b bxCv+sCmSBbk7m114RAZdhFq2bkeH7bukZd+Vx+l6JsNXvJI9IgqgxwRlWZWsZUYr6Cd 76+fwxTlbdxoy55NsWGDek4cuUtlPrE72a0Be8S+AX9U9s9whF3rsgRGFlIarq/LgRbQ MMoZMuqxipqdTys5ajfoLM+lsBXZ+QP/FUUVpw5kK3veouE9GDieRBNV3U/trlnBzk68 o/BTOGHAOWDW+LnwbwMG1m723Tlya6tgQvHIdxUxELPjFck6YNMYmAZoisCv6salcKj2 4XKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Kyt2axUo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c6-20020aa7c746000000b00445bd289a71si1404118eds.322.2022.08.30.05.52.58; Tue, 30 Aug 2022 05:53:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Kyt2axUo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbiH3MsL (ORCPT + 99 others); Tue, 30 Aug 2022 08:48:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229770AbiH3MsH (ORCPT ); Tue, 30 Aug 2022 08:48:07 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E17212F546; Tue, 30 Aug 2022 05:48:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 33539B81B31; Tue, 30 Aug 2022 12:48:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B690C433D6; Tue, 30 Aug 2022 12:48:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661863683; bh=OAh+DLRsxby01KGNRIxvYJEv80iev1FoY/1ihc89qeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Kyt2axUo3wku6Kk3CgkAayyGli93rvZpbgEBOq6hOY3guD66TdeR02kLDabuHbj5G olUUtuZmmu4CEkPwNGffuxvD4B541E91LtD8pqzBB6xeRb65tHn+DQwTIuZA/ZtuQJ ZDNKMpRvi9e4Z7782wlHSxvrTPoc/c/mU5ycgh24= Date: Tue, 30 Aug 2022 14:48:00 +0200 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Jiri Slaby , "open list:SERIAL DRIVERS" , Stephen Warren , Alan Cox , Laxman Dewangan , Thierry Reding , Linux Kernel Mailing List Subject: Re: [PATCH 1/3] serial: Create uart_xmit_advance() Message-ID: References: <20220825091707.8112-1-ilpo.jarvinen@linux.intel.com> <20220825091707.8112-2-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 03:38:27PM +0300, Andy Shevchenko wrote: > On Tue, Aug 30, 2022 at 3:31 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Aug 25, 2022 at 12:17:05PM +0300, Ilpo J?rvinen wrote: > > > A very common pattern in the drivers is to advance xmit tail > > > index and do bookkeeping of Tx'ed characters. Create > > > uart_xmit_advance() to handle it. > > > > > > Fixes: e9ea096dd225 ("serial: tegra: add serial driver") > > > Fixes: 2d908b38d409 ("serial: Add Tegra Combined UART driver") > > > > This commit only adds a new function, it does not "Fix" anything :( > > I'm wondering how to tell stable maintainers about dependencies of > (not yet applied) patches? In practice I saw that contributors use > Fixes tag for the entire chain (for the preparatory patches + the real > fix) when it's not easy / in a nice way to rebase to have a one-patch > fix followed by refactoring, etc. It's as if no one has ever had this issue before and wrote it down for all to read and know what to do in the future. {sigh} Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. If you don't know the git id, just use the subject line and it should work the same. greg "why even write documentation?" k-h