Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kamlesh Gurudasani <kamlesh@ti.com>
To:     Jayesh Choudhary <j-choudhary@ti.com>, <nm@ti.com>,
        <vigneshr@ti.com>, <devicetree@vger.kernel.org>
CC:     <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <j-choudhary@ti.com>
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am64-main: Enable crypto
 accelerator
In-Reply-To: <20220711085743.10128-3-j-choudhary@ti.com>
References: <20220711085743.10128-1-j-choudhary@ti.com>
 <20220711085743.10128-3-j-choudhary@ti.com>
Date:   Tue, 30 Aug 2022 19:37:02 +0530
Message-ID: <87wnapsu49.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Jayesh Choudhary <j-choudhary@ti.com> writes:

> From: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Add the node for SA2UL.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> [s-anna@ti.com: drop label, minor cleanups]
> Signed-off-by: Suman Anna <s-anna@ti.com>
> [j-choudhary@ti.com: disable rng-node, change flag to shared]
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> index ada00575f0f2..06fada0d82b1 100644
> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
> @@ -1308,4 +1308,24 @@
>  		interrupt-names = "int0", "int1";
>  		bosch,mram-cfg = <0x0 128 64 64 64 64 32 32>;
>  	};
> +
> +	crypto: crypto@40900000 {
> +		compatible = "ti,am64-sa2ul";
> +		reg = <0x00 0x40900000 0x00 0x1200>;
> +		power-domains = <&k3_pds 133 TI_SCI_PD_SHARED>;
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges = <0x00 0x40900000 0x00 0x40900000 0x00 0x30000>;
> +		dmas = <&main_pktdma 0xc001 0>, <&main_pktdma 0x4002 0>,
> +		       <&main_pktdma 0x4003 0>;
> +		dma-names = "tx", "rx1", "rx2";
> +
> +		rng: rng@40910000 {
> +			compatible = "inside-secure,safexcel-eip76";
> +			reg = <0x00 0x40910000 0x00 0x7d>;
> +			interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&k3_clks 133 0>;
> +			status = "disabled"; /* Used by OP-TEE */
> +		};
> +	};
>  };

Both patches look good to me.

Reviewed-by: Kamlesh Gurudasani <kamlesh@ti.com>