Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4273444rwe; Tue, 30 Aug 2022 07:27:51 -0700 (PDT) X-Google-Smtp-Source: AA6agR5+m+VMQprIkLfQIK4dCmPwWcm0tc5aQX7t1/hdM/7yTYMCTtsbOaOafe41zCe68P6Asq5T X-Received: by 2002:a17:907:2d8a:b0:730:6880:c396 with SMTP id gt10-20020a1709072d8a00b007306880c396mr16716177ejc.192.1661869671637; Tue, 30 Aug 2022 07:27:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661869671; cv=none; d=google.com; s=arc-20160816; b=xYxEJYdXmballJjGTWNAd8t7bijlhpIFlGBGlvoi8Fs3bEkXlnafc/kIbyueKH3DaI 70/59kUsNyRFPARk6wfVAUoTH+5zu59LFzaFQOIGx/r0plNf20Y3ZQNS79814VwAzfvg 0KXexYdZn1czats01kDtAZYdlXluuJBhEcSlrRwOh9djltykflQOYyoF3MqVQ1ew39LW yJyLCHrp7nnsfHBCZZNdkNET60f6rd4TycYAIkq5E5C4aanf3XHZft0GQdg8fRUCq31a BD3YoatPGywRHUqhoLX07oA1vkbG6ae7hzkUVU33TWM5ubiwqWWav3iRmslkyFKaZhM1 7Utw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=JpguWKHCz7w89q6BLLDu3VHzbooJ+x9K5EqEg9fOx8M=; b=kFBN5ZMCMN8lOA5SB64MvH4W7NzqPzd5o/MGLD7GqXVoQ0Nkar3hLUtDBAFRIBgJff BnLgtoyA6QrAmg6b9hH5SJTzQ2kALjQNzFKUdQS0I6yie+YJz5QbN/ViWpA5JxPQd8ho FXhg8A9obRFPjKhdqG3eEhQw/t86J6sGL1Z9+qQy/m5QWq/XaGmHuOeWqx4Ynpog6ENu 43KSozMyT4XbG0dzCn5ZDk8EBKEIFjHsHKQR3zwMpi3bJaAZnFVrwEWW3waN6IkI/azW K75/JZUFnwejwFxREMIbkgcqtPh45TZ0eFSY8XYAJGiPNPJiregFKCJaY9eju0LozRtx Q/8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=c2pG9ATJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l26-20020aa7c3da000000b004485eaacabasi3917580edr.23.2022.08.30.07.27.26; Tue, 30 Aug 2022 07:27:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=c2pG9ATJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229916AbiH3Nfg (ORCPT + 99 others); Tue, 30 Aug 2022 09:35:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbiH3Nfc (ORCPT ); Tue, 30 Aug 2022 09:35:32 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB95D4B0C1; Tue, 30 Aug 2022 06:35:30 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id c7so7594069wrp.11; Tue, 30 Aug 2022 06:35:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc; bh=JpguWKHCz7w89q6BLLDu3VHzbooJ+x9K5EqEg9fOx8M=; b=c2pG9ATJI7Vfg1cNbQDHpSFAphTLeHsKffxD2fhvclwhvmDc8MNye2JlUVbiFLEwyI an267YrcHIQxDvJJq3UfNMKVtHmyVegrYXiT4eFRoLbf/ApQADUClSgf4SzlghwDphB9 51BBe9PZr82GWYUQesDCcL1ol9dmIXPPk5QuqUPcvBNRfEGjiKk61hLof6VNvEefWiIx qth/JeKZSuuSYcwR+WN474a/hSBvgy1rEXHXQ2rREECA7TUQtAmg8P+ewovvPqo+XA3P 2IFOLOKpg2HDOEYA55JiuKtODLt/IPk6TT02zC/Pp9HEpi0LrMYw4DJrNU0qvfCH3eMI LAcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc; bh=JpguWKHCz7w89q6BLLDu3VHzbooJ+x9K5EqEg9fOx8M=; b=En/AB4WfGo3pxQzTf9JEOzDOH5l3+wpIOaRZNUtwt57YPdK6zeYNU5Wx5g7CLoTqTx Zs+/mzRzYSJIspXp+qsX4uONawrE7eiamRZcoAaEa9Axqk4LSDadu0y0MBabgC7E4UBF HwNovwMAAFoYxkN3zUvDae75LlvUTBkVlRDbXtRItJZFR63z/it3ao41RgVIajkJIfNv ZbkpoIlMMlrTValGZRmrgsYfPRB/tUxbrXJSgmuJA+kQXnmBM9PO3JrLS3ytSTUUsKix q6kuOoXrN/E1yeDtqeZylt3FT+bORUhACXT0QE+whv0crxcwExUXx3yL138i9G5QojcG Fz9w== X-Gm-Message-State: ACgBeo1XA5fBYB4TflJ51Xj6hqMfyfxTinztMyAtQzZqy3PtQBlsfXtG WYMG4br2zOXss2hNwBG9ai4= X-Received: by 2002:a5d:51d2:0:b0:226:cfa4:a998 with SMTP id n18-20020a5d51d2000000b00226cfa4a998mr8880175wrv.689.1661866529306; Tue, 30 Aug 2022 06:35:29 -0700 (PDT) Received: from elende (elende.valinor.li. [2a01:4f9:6a:1c47::2]) by smtp.gmail.com with ESMTPSA id n5-20020a05600c3b8500b003a319b67f64sm3752650wms.0.2022.08.30.06.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 06:35:28 -0700 (PDT) Sender: Salvatore Bonaccorso Date: Tue, 30 Aug 2022 15:35:27 +0200 From: Salvatore Bonaccorso To: martin-eric.racine@iki.fi, 1017425@bugs.debian.org Cc: Peter Zijlstra , Ben Hutchings , x86@kernel.org, Linux Kernel Mailing List , stable@vger.kernel.org, regressions@lists.linux.dev, Daniel Sneddon , Pawan Gupta Subject: Re: Bug#1017425: [PATCH] x86/speculation: Avoid LFENCE in FILL_RETURN_BUFFER on CPUs that lack it Message-ID: References: <9395338630e3313c1bf0393ae507925d1f9af870.camel@decadent.org.uk> <166062224255.2056.9595118849979455037.reportbug@pxeth.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, On Tue, Aug 30, 2022 at 03:18:51PM +0300, Martin-??ric Racine wrote: > On Tue, Aug 30, 2022 at 3:00 PM Peter Zijlstra wrote: > > On Tue, Aug 30, 2022 at 02:42:04PM +0300, Martin-??ric Racine wrote: > > > On Fri, Aug 19, 2022 at 3:15 PM Peter Zijlstra wrote: > > > > > > > > On Fri, Aug 19, 2022 at 01:38:27PM +0200, Ben Hutchings wrote: > > > > > > > > > So that puts the whole __FILL_RETURN_BUFFER inside an alternative, and > > > > > we can't have nested alternatives. That's unfortunate. > > > > > > > > Well, both alternatives end with the LFENCE instruction, so I could pull > > > > it out and do two consequtive ALTs, but unrolling the loop for i386 is > > > > a better solution in that the sequence, while larger, removes the need > > > > for the LFENCE. > > > > > > Have we reached a definitive conclusion on to how to fix this? > > > > https://git.kernel.org/tip/332924973725e8cdcc783c175f68cf7e162cb9e5 > > Thanks. > > Ben: When can we expect an updated kernel to security-updates at Debian? When the update is ready to go. Likely the update for the next point release for bullseye will contain the fix for this issue. Regards, Salvatore