Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4394103rwe; Tue, 30 Aug 2022 09:18:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR7kQhx+pG2sdGg7qQQyONumhFu7z5fxEvSdpP8AMvzJ2mcstjo9RfLDHcIJzrg1+GQBSJWr X-Received: by 2002:a50:9f4f:0:b0:447:8aff:d312 with SMTP id b73-20020a509f4f000000b004478affd312mr20757441edf.110.1661876308257; Tue, 30 Aug 2022 09:18:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661876308; cv=none; d=google.com; s=arc-20160816; b=eE1KCuuXDyqrOueKfRtsN/esfTIk5Zl2HDG3s7bVCJ9P+aYJ5HtB5bC3UwuoXAL7B6 UjEDD0QTmPpn3gFE28RGVz3PwkSwLYOTSLavBqFj5yJnUYmpwcjKl5TpybkZJgcR/PL2 QNTM8MFunY5cEMKHYsswZWb/WWCDOvG9dIIA6ynTmbZtHj7c75rmJUS0NI9Qn1+R4PQV kiPKCyt5Lrc02yC5oGCR7h9L25wFwtiGFWayHpCvQVLp9loQ5Nmh0z8gUEUMQ7C8JRnb il4ACpHvfpNC1EMsbgc+KDNoAe3PBqKI7y17ZxM9l5kP4J5ci6p0SoQ0sAYFc0zWh0xi AAVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7qC3cqqs7nGripS3o4XTPyKh3VYcgOs8YLPKbS6t11w=; b=pnouLbWk/9YMA3QUDIti6nQJv1HbtRtbOPY9zYkqsA5Gr4w6wd4RPtLyg913imG48+ 2RwLQbyf6xIu+MV3bfR41IH4fi2xmCFTjTC97U/5qkB+B2yRpBSJ+ta1V4U7n671mLAu At81uscEEyG9ioSwvQDWntkChYJjc0MkH7LsZ7L9yzll0VafEoodPnVf14+jt+gu0R3+ x7OCJPwlodwi7SMFTiiO/EkfkLI+ujrhjeUKx6kU06spztrSH3TAT40ga6Rmk9Bd0Bl0 tjWvfx12tnWwzjqIbDwj9pbzpRy4JyWj2cbIj3ngR5qQPOOWdZzOg+/wmosEDd980CHI N42A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cMw3OyAn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r11-20020a50c00b000000b0044202417985si608368edb.108.2022.08.30.09.17.50; Tue, 30 Aug 2022 09:18:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=cMw3OyAn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229908AbiH3POM (ORCPT + 99 others); Tue, 30 Aug 2022 11:14:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229608AbiH3POL (ORCPT ); Tue, 30 Aug 2022 11:14:11 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFFBF122BD3; Tue, 30 Aug 2022 08:14:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661872449; x=1693408449; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MZ2ZerYuF3A2KgxxfSjNdhOa11NynO633L1K+Ai+Uz0=; b=cMw3OyAn6N4dEtGDxEAaQT3Dlr85eJtz8Oka3BwzjS+SlZZW42olMRTE 28CINRO+tv/5h0DDF26Qs1oMbeJMb+RQQSlfru5nB1mvuBeZOiTXE2Rvy jm0Hwf90GlaFTL9Jkbqu6L4cbeZNZnG9SK2fKFu2z4bneCknVgilJ2ERN RkRY6x/NJLp2LNSx/3HbzAEYqNSXFWs2WPFGjR9HQFF0ywgXw+9woHy+4 8OjW+Gqczmcn/DVemHOEJ1IxwgI9EYCSP0oaOVBkgdg1vORhsjCVBDFol EuSf3m17DxzdcMT7cY3nfmb47Bw1lkDQdOHwhFonVhEeoUnEkGBTjKXul g==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="381499167" X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="381499167" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 08:14:08 -0700 X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="644863987" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 08:14:06 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oT2wF-0060Qb-29; Tue, 30 Aug 2022 18:14:03 +0300 Date: Tue, 30 Aug 2022 18:14:03 +0300 From: Andy Shevchenko To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown , Andy Shevchenko , Mika Westerberg Subject: Re: [PATCH v1 1/2] ACPI: PMIC: Use sizeof() instead of hard coded value Message-ID: References: <20220830135532.28992-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830135532.28992-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 04:55:31PM +0300, Andy Shevchenko wrote: > It's better to use sizeof() of a given buffer than spreading > a hard coded value. It seems I have noticed more to convert. But I will wait for others to comment on the published version. -- With Best Regards, Andy Shevchenko