Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 10:43:33 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Neha Malcom Francis <n-francis@ti.com>
CC:     <afd@ti.com>, <devicetree@vger.kernel.org>, <kristo@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
        <vigneshr@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j7200-main: Add main domain watchdog
 entries
Message-ID: <20220830154333.cwxji4hx7iggsm3w@boondocks>
References: <20220822235006.7081-1-afd@ti.com>
 <20220830041822.7435-1-n-francis@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220830041822.7435-1-n-francis@ti.com>
User-Agent: NeoMutt/20171215
Precedence: bulk

On 09:48-20220830, Neha Malcom Francis wrote:
> From: Andrew Davis <afd@ti.com>
> 
> From: Gowtham Tammana <g-tammana@ti.com>
> 
> Add DT entries for main domain watchdog instances.
> 
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
> Reviewed-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Reviewed-by: Neha Francis <n-francis@ti.com>

NAK - Please follow the standard patch guidelines for From, and handoff
etc.
> ---
>  arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> index 16684a2f054d..cf657ac0bd6a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j7200-main.dtsi
> @@ -739,6 +739,24 @@ main_gpio6: gpio@630000 {
>  		clock-names = "gpio";
>  	};
>  
> +	watchdog0: watchdog@2200000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x0 0x2200000 0x0 0x100>;
> +		clocks = <&k3_clks 252 1>;
> +		power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 252 1>;
> +		assigned-clock-parents = <&k3_clks 252 5>;
> +	};
> +
> +	watchdog1: watchdog@2210000 {
> +		compatible = "ti,j7-rti-wdt";
> +		reg = <0x0 0x2210000 0x0 0x100>;
> +		clocks = <&k3_clks 253 1>;
> +		power-domains = <&k3_pds 253 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 253 1>;
> +		assigned-clock-parents = <&k3_clks 253 5>;
> +	};
> +
>  	main_r5fss0: r5fss@5c00000 {
>  		compatible = "ti,j7200-r5fss";
>  		ti,cluster-mode = <1>;
> -- 
> 2.36.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D