Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 18:05:46 +0200
From:   Oleksij Rempel <o.rempel@pengutronix.de>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Arun.Ramadoss@microchip.com, andrew@lunn.ch,
        linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com,
        vivien.didelot@gmail.com, san@skov.dk, linux@armlinux.org.uk,
        f.fainelli@gmail.com, kuba@kernel.org, edumazet@google.com,
        pabeni@redhat.com, netdev@vger.kernel.org,
        Woojung.Huh@microchip.com, davem@davemloft.net
Subject: Re: [Patch net-next v2 0/9] net: dsa: microchip: add support for
 phylink mac config and link up
Message-ID: <20220830160546.GB16715@pengutronix.de>
References: <20220724092823.24567-1-arun.ramadoss@microchip.com>
 <20220830065533.GA18106@pengutronix.de>
 <67690ec6367c9dc6d2df720dcf98e6e332d2105b.camel@microchip.com>
 <20220830095830.flxd3fw4sqyn425m@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220830095830.flxd3fw4sqyn425m@skbuf>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Aug 30, 2022 at 12:58:30PM +0300, Vladimir Oltean wrote:
> Hello,
> 
> On Tue, Aug 30, 2022 at 08:15:59AM +0000, Arun.Ramadoss@microchip.com wrote:
...
> > Hi Oleksij,
> > Is this Bug related to fix in 
> > https://lore.kernel.org/lkml/20220829105810.577903823@linuxfoundation.org/
> > . 
> > It is observed in ksz8794 switch. I think after applying this bug fix
> > patch it should work. I don't have ksz8 series to test. I ran the
> > regression only for ksz9 series switches. 
> 
> I find it unlikely that the cited patch will fix a NULL pointer
> dereference in ksz_get_gbit(). But rather, some pointer to a structure
> is NULL, and we then dereference a member located at its offset 0x5, no?
> 
> My eyes are on this:
> 
> 	const u8 *bitval = dev->info->xmii_ctrl1;
> 
> 		data8 |= FIELD_PREP(P_GMII_1GBIT_M, bitval[P_GMII_NOT_1GBIT]);
> 							   ~~~~~~~~~~~~~~~~
> 							   this is coincidentally
> 							   also 5

ack.

> See, looking at the struct ksz_chip_data[] array element for KSZ8873
> that Oleksij mentions as broken, I do not see xmii_ctrl1 and xmii_ctrl2
> as being pointers to anything.
> 
> 	[KSZ8830] = {
> 		.chip_id = KSZ8830_CHIP_ID,
> 		.dev_name = "KSZ8863/KSZ8873",
> 		.num_vlans = 16,
> 		.num_alus = 0,
> 		.num_statics = 8,
> 		.cpu_ports = 0x4,	/* can be configured as cpu port */
> 		.port_cnt = 3,
> 		.ops = &ksz8_dev_ops,
> 		.mib_names = ksz88xx_mib_names,
> 		.mib_cnt = ARRAY_SIZE(ksz88xx_mib_names),
> 		.reg_mib_cnt = MIB_COUNTER_NUM,
> 		.regs = ksz8863_regs,
> 		.masks = ksz8863_masks,
> 		.shifts = ksz8863_shifts,
> 		.supports_mii = {false, false, true},
> 		.supports_rmii = {false, false, true},
> 		.internal_phy = {true, true, false},
> 	},
> 
> Should we point them to ksz8795_xmii_ctrl0 and ksz8795_xmii_ctrl1? I don't know.
> Could you find out what these should be set to?

xmii_ctrl0/1 are missing and it make no sense to add it.
KSZ8873 switch is controlling CPU port MII configuration over global,
not port based register.

I'll better define separate ops for this chip.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |