Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4397005rwe; Tue, 30 Aug 2022 09:21:26 -0700 (PDT) X-Google-Smtp-Source: AA6agR7WMpB489PMlekN/L/KtwO/7GwMFp+wn+yeZz3LmNqN4ucJhtpC0+ofk1/EneclMeGyyD3z X-Received: by 2002:a17:907:272a:b0:741:8105:49e2 with SMTP id d10-20020a170907272a00b00741810549e2mr7828411ejl.171.1661876485905; Tue, 30 Aug 2022 09:21:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661876485; cv=none; d=google.com; s=arc-20160816; b=WjD8TMQ9BrL4uI51qJ8OJzo814UCHspb4RctYTQaa11dMPj9mbEbkRrcIRqAInoAIG OHXHe/mWQCKRrizuBY+fOoY6zL+b0dnsDRRbTD8YANkfw/DwvBxE7UE1gxpv9qXnPfmP VoL6uM8YMSymeMMRnMyA2xfIY+Zs35UFWd0T0ONSOrtp8Sx/3h/OOAUGQhPm+vuRMoQB SF/8LfrkYIJX2efUZHPRKW3xzeUh4MOL7/zeLzqXZX0bctHmj1cfaFtDIBlZh5scc+0Z 4zclmJLOow/H8z9s4ZoNDzGH6jaiHJ+pZ9qqCEIj4PRZwNe4g+pbf75siMWRxVIRwRig atAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Z0/Ubngx7Rd7BOFwF6Nv7y8NUPvSEx2rhy2J3cUSUqk=; b=rPCNvx9aQCgPbCG1buahZeTVhgUHLJM3f/QSN77Vni7Vt0LUp/ODsKEtNhbhqrxwUy +DmL3Yw674FNDNUKFKDijQ9yoWS3rJeDjnauLna+m9zKzD4tr/ETEvehRZQ+AEt7NrYc ks85U4EMTB20QZtKS3LMw8Ye3gT5wYj4x5fqYBZJ48xIh5dCZdROjmIEnhrCc0WePBIf P7XvT13bVoNnNAQxTjfnnycKb39DGYoq380Ox0wnoaAuSj1KnxOB5KvdMBmvjTI7j5M1 W6pN6zuKO0CaX/A6BMLnSNLd/OK0/RCK64QN0FBXrWiIaDx/RjWwC6ZTuq6M23zO77oh xE+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=icGeuF+G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a056402084c00b0044874e5ca89si5282183edz.112.2022.08.30.09.21.00; Tue, 30 Aug 2022 09:21:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=icGeuF+G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230522AbiH3QIU (ORCPT + 99 others); Tue, 30 Aug 2022 12:08:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230511AbiH3QIP (ORCPT ); Tue, 30 Aug 2022 12:08:15 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B9BFF7B07; Tue, 30 Aug 2022 09:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661875694; x=1693411694; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Z0/Ubngx7Rd7BOFwF6Nv7y8NUPvSEx2rhy2J3cUSUqk=; b=icGeuF+GCrIT6iD5/50/L9kqm/z1O+EApORnk9e5VBue5dJ+a/eM8OZg YebevJNym6yXKQwjRzT9fWTCAr+RV1bf4LQi4oJFuY2VA84E0iVzdgOHq QZgBqasWV6uY5ucAyTLfAnZ3yoWI+fqst+wzSm7mb/TxAF4xFvGKrmyX4 6Tzzszh1glmEGC1J0HM93b8n6FXTEynbD/BbDpzWjFONUvLYjPQLPkNss c/10YQ8w8GHck7j1iSBzcN0jRGqRXJscykc1f7GkzZYU4o4Un+iKsiFjJ tdJd3L4IM2UmMxBydc1JlUPBU6I2PEzdzxzRpHapI6U4eaxqJFBbPf8Tt A==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="295218911" X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="295218911" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 09:05:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="680087910" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2022 09:05:48 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 13D11AD; Tue, 30 Aug 2022 19:06:02 +0300 (EEST) Date: Tue, 30 Aug 2022 19:06:02 +0300 From: Mika Westerberg To: Andy Shevchenko Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Andy Shevchenko Subject: Re: [PATCH v1 2/2] ACPI: PMIC: Replace open coded be16_to_cpu() Message-ID: References: <20220830135532.28992-1-andriy.shevchenko@linux.intel.com> <20220830135532.28992-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830135532.28992-2-andriy.shevchenko@linux.intel.com> X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Aug 30, 2022 at 04:55:32PM +0300, Andy Shevchenko wrote: > + > +#include Isn't there as well? Is there something that prevents using it? Otherwise looks good to me.