Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 19:10:57 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v1 1/2] ACPI: PMIC: Use sizeof() instead of hard coded
 value
Message-ID: <Yw42ka9czLbBmTtp@smile.fi.intel.com>
References: <20220830135532.28992-1-andriy.shevchenko@linux.intel.com>
 <Yw4zaBJu81SvkFMM@black.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yw4zaBJu81SvkFMM@black.fi.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Aug 30, 2022 at 06:57:28PM +0300, Mika Westerberg wrote:
> On Tue, Aug 30, 2022 at 04:55:31PM +0300, Andy Shevchenko wrote:
> > It's better to use sizeof() of a given buffer than spreading
> > a hard coded value.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thanks! As I replied to this, I'm preparing a v2 which will cover more
conversions. I won't use your tag because it will cover just like a half of it.

-- 
With Best Regards,
Andy Shevchenko