Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c84fa46d-8f37-c449-06ea-5da795f091e8@fb.com>
Date:   Tue, 30 Aug 2022 09:41:06 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.13.0
Subject: Re: [PATCH bpf-next v1] bpftool: Add support for querying cgroup_iter
 link
Content-Language: en-US
To:     Hao Luo <haoluo@google.com>, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
Cc:     Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, KP Singh <kpsingh@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Stanislav Fomichev <sdf@google.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Yosry Ahmed <yosryahmed@google.com>,
        Quentin Monnet <quentin@isovalent.com>
References: <20220829231828.1016835-1-haoluo@google.com>
From:   Yonghong Song <yhs@fb.com>
In-Reply-To: <20220829231828.1016835-1-haoluo@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amI3Z0FGYVoycTUxV2lIVHBKRUlHdzBvSHRTVHZKdmZCZG9MK01uUnIwNnNJ?=
 =?utf-8?B?N3RiTkJiREdXUnlhV1YvWU9HVTNJU1Nvb3pEM1NEYXFjdzZiMHFLVURZMXNq?=
 =?utf-8?B?d2lRT3RlV3AycEVucCtaZVVKdXBuOVBPWG90UURRaGI4b3NUdldKR1hJSTBq?=
 =?utf-8?B?MzRnZk5vQXc1T1NHd3FkWWVQSlAzWEJBeERTM1BNWHZWUHFBTUpZZDdVTHQ5?=
 =?utf-8?B?b25EUXc3dXBUcDdtREhidHo2aHptMHJkd1J5QjRlejNYaGpDM1BLa1BmNis3?=
 =?utf-8?B?cTdkdmVxMDFxVUJCSUZHRmNaK241ZFFxbzdKRmRKbkQ1QXdoa0FGeEFaMVZY?=
 =?utf-8?B?YnZqd3RJNUNjOFJ6UG1VZ3NOdXZmWTkxQlhIcFNGaTJ2aUE3MkhVREhPb0hp?=
 =?utf-8?B?SVpqWHhVRlBac2RuWkFtQUNsTkVkUXBFbEx0bXhCKzZGalJmdGROWjlKb3Ux?=
 =?utf-8?B?Ny9mdGtZUnNjSUtsWXA1ckVDMnNxUTIzQ1h4ZVJRNTNqSTVQblkzSHd5djJE?=
 =?utf-8?B?SW9CdGZZQ2VtMVdvSUFIKzNIMmpKcXZBOUVIcHgvT2MyUGN3a05PMVdhWEsx?=
 =?utf-8?B?aFU5YWNQNEMvSUVzOHdCSUVXTjd0L3hPUXlXZnFKUWxOQURYMzZScXFUOVVw?=
 =?utf-8?B?UXZ3WVllSzVPOVJYNDNXQm5FWE1sYUxteWl3YnJIK1N2aEp2b0REdCtLOXN5?=
 =?utf-8?B?TmVVbWVKNm9hVjduWXR6TUpsMnhFZGw3UGV0SjlaZU52cTVpLzdScW5NN0dv?=
 =?utf-8?B?a3hFOHBGWWhOWitHbmd4S2VZNTZqZzcvazg5UEhQV0Zsd2tROWNxcjRubWo1?=
 =?utf-8?B?LzJlNm1MS1hSTE1QZERVQmJrZnBYQXA4cG1WOTRCbG1zdy9lLzZnNnpxaFk2?=
 =?utf-8?B?TCt4MCtUMENOT1J3eW56dHFTUGJKN1VLa2dmR05YVjVnWWNnWlcyVHFSTTY3?=
 =?utf-8?B?emFhMjFRYVE5aFppdFlyT1g3N2ZNdnlhMm1iTFhqQ0hWQ2Q1MmpMemw1OEUw?=
 =?utf-8?B?cGw1SjkrQXgwRWkvUk5uVUYxa1FyQ1lHeENIcnZnQ3ZkTHhGZjdMci9XTUpO?=
 =?utf-8?B?UVdOUTdMeFZoMjZzSDJ5TlRLZVg4Vk9Mb3o5cUtHck9lZmYyLzlncmtTNHpm?=
 =?utf-8?B?Yy9vb0o0Z3JjYldrWWFiOEUwTndGQzErZ2cwZFJSUlRWc1E2bDNpWTJ2SDE3?=
 =?utf-8?B?Ni8xR0tqV3Uzb1N1Q3ZXUHU3K3VmaHQ5VXQ3Tzl3ejhVUjh2K3EwbnVIRlBh?=
 =?utf-8?B?R2czM0VFVnd3cjR5N0JUOUtaQWdISUVFdUc3VHF3eVByMUVuVE4vZ2RlYzlJ?=
 =?utf-8?B?TVI3N09KU05BUlYvNUMxaUFhVGtoMW9sY1BoZkVJQWtlM0hxd3pnTzRFSjhv?=
 =?utf-8?B?ZTNvbndpb0V5N2Jnc1NVM3h6dGk5RmRnSUVoRVlOY3VjTFpmbzJ4am1xcE9l?=
 =?utf-8?B?aHFpWHcvankxOEsyeVhNNzRnaFZmY0lVWGxHWGE4R09hS1RoOElFdGx0czVB?=
 =?utf-8?B?WFpScGpKMW1JdFdMdUVxUFBLeHc1Z2ttSWlkTGM1UzJRSlk4cisyK1dDV0J0?=
 =?utf-8?B?dWs0ZHhGZzJZMjB6UDlYSHREeUxLWUVvaTFmNmZmRjltUHRPUDdnWWJIT1Z6?=
 =?utf-8?B?Zm9MQlV0N3lHVkdzUW8zZFJxVUJiS2QxSmo1eVNyeWlCTmxoUFluUEZ3eVl2?=
 =?utf-8?B?UTlra3ZSWDArWngvdkg5VEtYOG51NHpTOTRVMURyQVpHOENkcFBWVndOS04x?=
 =?utf-8?B?SXBaWVg0TDJRaTdPVzlLSFB4OTkrT05nNUVIOStYVG1BZkZlWEtkc0kraXgx?=
 =?utf-8?B?QjV3Z0I0dTcxRlNqajVMaHV0MzVESlN4OTloSGhxZE45TCtNR0pXeEU3c1dv?=
 =?utf-8?B?aW82UTRUdkp4YXFpYlVxb2o2K0ZpOEMzMkRRNmgwM1pDcXYzUTdYWVBqWDlW?=
 =?utf-8?B?cXBucngyVnUwRlhNT2dvT2xIQ0dmSGRIUkg3cEpRaXoxSFNvN0FBbmJBSitv?=
 =?utf-8?B?ZVh0aW1EWkZkY1dLYkw2UjhDeS8xbDRUYyt4dFpGSC90Sm11THVKd29KdlZG?=
 =?utf-8?B?eGRCZXNuZXMzVWtEVVNaRklEK1F4d0VJS2hPRUozbDNJQnRrREFUcHpReGJv?=
 =?utf-8?B?NUszZlhtY2hpWmhJcXhmU2VkVi92cjNHdEVlMjJTNGdWL2ZGRE5OdXJmV0JU?=
 =?utf-8?B?U0E9PQ==?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 71ad9c88-afb2-4d64-e378-08da8aa670bb
X-MS-Exchange-CrossTenant-AuthSource: SN6PR1501MB2064.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 16:41:09.3161
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 31qv6yrnTTY1u3GLxkC0rxnsIqkZi4EmJNDKJ+fsmIQYFs5iefQ12Ll9HNg5QyCQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1584
X-Proofpoint-ORIG-GUID: Gi3FLUjfe3q6GB1a1ur0kaR5FHe8OvGn
X-Proofpoint-GUID: Gi3FLUjfe3q6GB1a1ur0kaR5FHe8OvGn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-30_10,2022-08-30_01,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/29/22 4:18 PM, Hao Luo wrote:
> Support dumping info of a cgroup_iter link. This includes
> showing the cgroup's id and the order for walking the cgroup
> hierarchy. Example output is as follows:
> 
>> bpftool link show
> 1: iter  prog 2  target_name bpf_map
> 2: iter  prog 3  target_name bpf_prog
> 3: iter  prog 12  target_name cgroup  cgroup_id 72  order self_only
> 
>> bpftool -p link show
> [{
>          "id": 1,
>          "type": "iter",
>          "prog_id": 2,
>          "target_name": "bpf_map"
>      },{
>          "id": 2,
>          "type": "iter",
>          "prog_id": 3,
>          "target_name": "bpf_prog"
>      },{
>          "id": 3,
>          "type": "iter",
>          "prog_id": 12,
>          "target_name": "cgroup",
>          "cgroup_id": 72,
>          "order": "self_only"
>      }
> ]
> 
> Signed-off-by: Hao Luo <haoluo@google.com>

Acked-by: Yonghong Song <yhs@fb.com>