Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <fa41ea6d-7cd4-a0c0-b026-f295fbb6570e@oracle.com>
Date:   Tue, 30 Aug 2022 09:47:48 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Subject: Re: [PATCH 5/7] mm/hugetlb: convert hugetlb_delete_from_page_cache()
 to use folios
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        mike.kravetz@oracle.com, vbabka@suse.cz,
        william.kucharski@oracle.com, dhowells@redhat.com,
        peterx@redhat.com, arnd@arndb.de, ccross@google.com,
        hughd@google.com, ebiederm@xmission.com
References: <20220829230014.384722-1-sidhartha.kumar@oracle.com>
 <20220829230014.384722-6-sidhartha.kumar@oracle.com>
 <Yw2DWCHlivGge03V@casper.infradead.org>
From:   Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <Yw2DWCHlivGge03V@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0ZybFNpUG4vOFcvb0RXUUJTREozM1BQOHZ4OUhxcjQ4R0o2STJHNkhnQUls?=
 =?utf-8?B?ZXlxYkN0THl5T2MwY05wQTRXRmJ6bGp3MkZNY3czb0ZCazJNbzRSTVVRRDBy?=
 =?utf-8?B?MTZvRlFQaldOTmtodjRieGZDVElpQVI1SkdQOVZrQlpKWGxSY1YwcmF5eDJV?=
 =?utf-8?B?bTlzdy9BMStlMHQvMDQ4YUJ4YVF1dDEySFJtcCttWU1McFNlYk5xYlFZMWpJ?=
 =?utf-8?B?aGRnbDNLM2Q2cG93c2JoVmZUWE1zai8wK0lXczFocTJCbFlrYkQrazNRN2ZV?=
 =?utf-8?B?a09QL3pJUHRxT3U5QXFkRlUrYWdRMlVXRytFSjRqYmJvNlphaUhFNTRhUG1y?=
 =?utf-8?B?TkVHMzJER0l4aDRNQ1lHc3lrMjZERGs3eHBQTGo2VkFENW1ic0RnQy82QjhI?=
 =?utf-8?B?S3lxL0ViNHB6RThDdUM0TzlFZEEwbnA4dFM3V1FsNktQbGp1NE5vM2ZjMVpj?=
 =?utf-8?B?bG8vVE0xMUpQOXkvNmp6QktUczhObkJuTGo4RVNEUmVvWFJZN0Uzd200UC9o?=
 =?utf-8?B?dlB4Y0tvazFrRTBkOUw4UURWaG91am5MUUx5bTRaMUUyaGFpV1JPbnRSRnd0?=
 =?utf-8?B?d21KaG5lSUJGNDdTWDlCYUJ2TXhkK1pnbHRpVE9Bd2lSTFdEMldPVWRxVnBC?=
 =?utf-8?B?OHZBaHdTR1B6cWhqcjBIRkJZd09Eb3dmNnk3YThvSGhwZFZsYzc0cVlaRW5p?=
 =?utf-8?B?WmJ6NFY1Sm1xTHU5SGVXdHVoN3ZTTjVQbmRLZ1RTOTluZEdzbjYxSy9mMmYy?=
 =?utf-8?B?enhpRyt1TGNiTXpZTGdsMlFrWkxtNGtibUpvamhFZGxxeG04YjVwbktGbFRS?=
 =?utf-8?B?NHBqVUFmd0IvQ2tLTlZ1MGVIR1RJZUNUMHVwQVZBYkZUaFZ5WXZMTUs0WThK?=
 =?utf-8?B?SDZSZnFwUWFCRngwdFVFNVFVemk4SVpKVkI1MVc2eWw3aTFjSUUwUFllOTB0?=
 =?utf-8?B?MkJpcXdMcWwwNEF3czRFU1VhWVpoK0llYWpiVzREODI0QXVkQlpwWnN5OE5x?=
 =?utf-8?B?QVBQZUxoTXI2NHF1dXkvU3MzZjNhb0NxbXpRKzZOZ3FDdkRIZkp4UkR3UzFk?=
 =?utf-8?B?L2JkTlBnZFpCVFQzVHdDRncya0ZUOXB3NnhPbUxxQlBadTFhK2p5ZGZMOUtw?=
 =?utf-8?B?cVhoa3pVRG1sazVHZkJhcnlON2lkTjhzZ1V1RmdOcXdFa0oxY2E2MTRHTzdi?=
 =?utf-8?B?clZZVmhUejJ6K3RyeElxa2pVVkhoV09KV21rSFRUb0RYUC9MYlRCZjdOeXVH?=
 =?utf-8?B?dms0Tm8yVEFsSldKZWVUSFlycU5jeEVOUWQxYkZaVkoxd0xueTJNaC9vZGxo?=
 =?utf-8?B?bzFNQllxaytDWEQ5eW90ZnRDSHBkam1BWVNVZ3p6U3ZEeGVJeDYrNHRrdnlZ?=
 =?utf-8?B?NnczQm14c0V5d2d6eW03cEZ5VHFLOEpSSGg5TGNRYWVraWU0U1REQTVWcVMz?=
 =?utf-8?B?cTc0QVFWM0t6QnU4Q1g2K3JjVThQbFpGTFZaMTVCcnFkN1RtakpPQmV5Unc4?=
 =?utf-8?B?ZmQ1blBHbG1Nc1ZKNmd1OWZsdUtFWkwyR01RRW9sTmxQNHRmWEZkS05IOWg2?=
 =?utf-8?B?aXlVTmxVVitVSzJ4bE03dTUvTGdGaFBYcnpNWUYrakZaamlJSFRvbjA0alpW?=
 =?utf-8?B?Y3U4K1lZL09wU0pOaEJGUWwwcTNjMVBuWTFUR3d5T3pQNGpzWVA4NjAyREIr?=
 =?utf-8?B?QlVhdml5SDV2VnFYbzNmOVcxR0tOYW9XUHRkMFE3ZXRjOS9sQjZ5bGlrM3VB?=
 =?utf-8?B?RjhEeFZRdzMyVWdxYlpzQU1kZHZCZi9XS0pwazZ5eTE1UmRFZC9Cd25rV2F3?=
 =?utf-8?B?djdzU2h6SWpoK3JtaGoySzByYlBpcmRnOTVHVTJ5c2UxWWNzU1BEVldraEow?=
 =?utf-8?B?a3BRdlVHZEFyU0o0cS9aaCtxYmhEL3JaQVVtNkdNdjJ3ZUhwNjh0VU5jRngv?=
 =?utf-8?B?TmQrd1FsZGVUeUUzRDB2ckZtTm5WcWdwcy8vdWtLSUZGaTBwU20vdUxsdGxs?=
 =?utf-8?B?dU5aMmVrbmUwMHBRdVZKdlJzN3JrSEh1TmRJNXZMMEF1NWU3SUh2THI3djFi?=
 =?utf-8?B?Q0pIVUxUSVFUb0JZME1oa1RXZGtaUnkzUGFwTlZXUFV0SzBLV3ZIUTJybGNY?=
 =?utf-8?B?NmpGa0NHKzUxSndOc1dXaGRiVmZzU3BKaWZQTGVrZUhXNk1EeDZITktlQkVU?=
 =?utf-8?B?VEE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b158036c-76ce-4d6b-d0ed-08da8aa761a4
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 16:47:53.1989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hyS/Ueu6MgBh3W/08omZVokj8jKtoRmfPuY+ZR2YsfqtWrSyzu8FbqKCfRz8uzecRyPcCJgMeLT/SL6mb0bxpqqOdqe0s8wZHhD1YdZldXI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6449
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-30_10,2022-08-30_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 malwarescore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2208300078
X-Proofpoint-ORIG-GUID: 0-VEAfqvpIu0X9OyLi0HhVsqxilOLQfo
X-Proofpoint-GUID: 0-VEAfqvpIu0X9OyLi0HhVsqxilOLQfo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/29/22 8:26 PM, Matthew Wilcox wrote:
> On Mon, Aug 29, 2022 at 04:00:12PM -0700, Sidhartha Kumar wrote:
>>   static void hugetlb_delete_from_page_cache(struct page *page)
>>   {
>> -	ClearPageDirty(page);
>> -	ClearPageUptodate(page);
>> -	delete_from_page_cache(page);
>> +	folio_clear_dirty(folio);
>> +	folio_clear_uptodate(folio);
>> +	filemap_remove_folio(folio);
>>   }
> Did you send the right version of this patch?  It doesn't look like it'll
> compile.
I missed changing the function argument to struct folio while rebasing 
onto Mike's patch,
will fix in a v2.