Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4454923rwe; Tue, 30 Aug 2022 10:19:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR4jADS6u1U6+32djW7t59psq1/kQfoCRfNL4aWVvHnU1wfpAM6ZVEOXWiHkQj9XkjjWEQp9 X-Received: by 2002:a17:90a:9a9:b0:1f6:a38b:e0bc with SMTP id 38-20020a17090a09a900b001f6a38be0bcmr24858884pjo.212.1661879994609; Tue, 30 Aug 2022 10:19:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661879994; cv=none; d=google.com; s=arc-20160816; b=PL0Bp/Jo0CNNHx3cAw+LkpRfwnXmUMY83EXpeOcNTXtDJQMtkfNjCcNNmor/cC5NnO zhScKVnVYrhJ3si8+PonNzzsiil/mrrX2fc4dncY+yNri3bRB9ny5S7lWfQAC0I73Pia WxivI+omDtVz9ULr24LOvQQzpHVYO4MPuxpeEiMyiX8SbJvkT70t1A7T2pI2Q0BqcI2z mmisNQK9+7/dxxlKXiVX7PrXngJ8QMwbn+IDiuX67kEWDzABYQBgw35KbnJTRNRoffEW ZjbAU19I9cEJZVYNCTVIt/JxpvcnXNq5H5o4Wu6pC0B2mRwFNzuecxo0vxVDauKMX3/H GkJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=B/97PHPfgC+kBYwXARiv8dXAX6yOmKTaGPRqHpb/vQc=; b=kt4EdCMhNoJbNDbF+Wr37gimhgIBR7im8yXLr67me89S7U0b3fnhl4dmuliiFyoaJ4 b+VGTfGPcY1GgmvPKZEwcZjf9/0hHKbWOh4Vdmz11jV5EF3G+im+LCPW+5BGEF0klQV6 TRqLk0r0HYWcDnAFLhUl0O8QwMtPDOofU4xJlhRTFZ8FTv/qxSGGtQGaZhK6WjcbnOS8 tJshu9R8sd3l2yNr0SeapY0D0j7AR9ldYa2TBurkBAErA+k3c9jBOX7VvVtAioNcLNE2 RY2iMH3hxWCl4g63Y8nwijdGD4RnbVfsT5uXISt3sedEYK1WLHp21GTbBZVQSF0GKdQh Iqjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LwlC0c0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u3-20020a170902e80300b00174cfdbe39bsi5927076plg.89.2022.08.30.10.19.43; Tue, 30 Aug 2022 10:19:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=LwlC0c0k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbiH3RLr (ORCPT + 99 others); Tue, 30 Aug 2022 13:11:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbiH3RLp (ORCPT ); Tue, 30 Aug 2022 13:11:45 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13326B942D; Tue, 30 Aug 2022 10:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661879505; x=1693415505; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=TsbH8WfVIPK7o9v1IjER2iQuy7ebiON15BiW0wAGgc0=; b=LwlC0c0kzRovhdU7CgL7rRkdvI8RhhD/6Ig8h+Z5BOwjpoE+iMa9n6NE 0u3kuZdxPISeruq1e46fbjbGwUJsn7fFbpvbdiS76ByRQ6mf8D3bCw1sI mawJuL4gbyxlaleqakfaxA9DE4zRGQxIchqUS+154rnjSoaCbFr2bqtA8 z6dfJJ3kHrrZE/c/GK7uG4RMSMPo7XlzGkNUTqdbJvPZX4wo9bzbvr/Ab L/kYX5/+JhpnPgZWBgaq//9wi2OcFATTARfx/TXJeJGS5w7NLIn267/88 9TOIykWOXm4eayMkqxcNzGWVYBn89SkdqtewesQL/y/I+EIQcu7UhUpqv Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10455"; a="296031024" X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="296031024" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2022 10:11:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,275,1654585200"; d="scan'208";a="562734132" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 30 Aug 2022 10:11:42 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 8338AAD; Tue, 30 Aug 2022 20:11:56 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Hans de Goede , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Len Brown , Andy Shevchenko , Mika Westerberg Subject: [PATCH v2 1/3] ACPI: PMIC: Use sizeof() instead of hard coded value Date: Tue, 30 Aug 2022 20:11:53 +0300 Message-Id: <20220830171155.42962-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It's better to use sizeof() of a given buffer than spreading a hard coded value. Signed-off-by: Andy Shevchenko --- v2: updated another driver as well (due to this no tag added) drivers/acpi/pmic/intel_pmic_chtdc_ti.c | 2 +- drivers/acpi/pmic/intel_pmic_xpower.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c index 418eec523025..6c2a6da430ed 100644 --- a/drivers/acpi/pmic/intel_pmic_chtdc_ti.c +++ b/drivers/acpi/pmic/intel_pmic_chtdc_ti.c @@ -87,7 +87,7 @@ static int chtdc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg) { u8 buf[2]; - if (regmap_bulk_read(regmap, reg, buf, 2)) + if (regmap_bulk_read(regmap, reg, buf, sizeof(buf))) return -EIO; /* stored in big-endian */ diff --git a/drivers/acpi/pmic/intel_pmic_xpower.c b/drivers/acpi/pmic/intel_pmic_xpower.c index 61bbe4c24d87..33c5e85294cd 100644 --- a/drivers/acpi/pmic/intel_pmic_xpower.c +++ b/drivers/acpi/pmic/intel_pmic_xpower.c @@ -255,7 +255,7 @@ static int intel_xpower_pmic_get_raw_temp(struct regmap *regmap, int reg) if (ret) return ret; - ret = regmap_bulk_read(regmap, AXP288_GP_ADC_H, buf, 2); + ret = regmap_bulk_read(regmap, AXP288_GP_ADC_H, buf, sizeof(buf)); if (ret == 0) ret = (buf[0] << 4) + ((buf[1] >> 4) & 0x0f); -- 2.35.1