Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91415092-e622-a636-3bc4-d81fb56b2f66@quicinc.com>
Date:   Tue, 30 Aug 2022 11:13:59 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 5/9] usb: dwc3: Avoid unmapping USB requests if endxfer
 is not complete
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     <balbi@kernel.org>, <Thinh.Nguyen@synopsys.com>,
        <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <quic_jackp@quicinc.com>
References: <20220817182359.13550-1-quic_wcheng@quicinc.com>
 <20220817182359.13550-6-quic_wcheng@quicinc.com> <Yw4Z191jbRJc9EuR@kroah.com>
From:   Wesley Cheng <quic_wcheng@quicinc.com>
In-Reply-To: <Yw4Z191jbRJc9EuR@kroah.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Greg,

On 8/30/2022 7:08 AM, Greg KH wrote:
> On Wed, Aug 17, 2022 at 11:23:55AM -0700, Wesley Cheng wrote:
>> If DWC3_EP_DELAYED_STOP is set during stop active transfers, then do not
>> continue attempting to unmap request buffers during dwc3_remove_requests().
>> This can lead to SMMU faults, as the controller has not stopped the
>> processing of the TRB.  Defer this sequence to the EP0 out start, which
>> ensures that there are no pending SETUP transactions before issuing the
>> endxfer.
>>
>> Reviewed-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
>> Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
>> ---
>>   drivers/usb/dwc3/core.h   | 3 +++
>>   drivers/usb/dwc3/ep0.c    | 5 ++++-
>>   drivers/usb/dwc3/gadget.c | 6 +++++-
>>   3 files changed, 12 insertions(+), 2 deletions(-)
>>
> 
> This commit does not apply to my usb-testing branch.  I've taken the
> first 4, please rebase and resend the rest.
> 

Sure resubmit it later today.  Sorry about that and thanks for the heads up.

Thanks
Wesley Cheng