Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 11:06:23 -0700
From:   Martin KaFai Lau <kafai@fb.com>
To:     Quentin Monnet <quentin@isovalent.com>, Hao Luo <haoluo@google.com>
Cc:     linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andrii@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        KP Singh <kpsingh@kernel.org>,
        John Fastabend <john.fastabend@gmail.com>,
        Stanislav Fomichev <sdf@google.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Yosry Ahmed <yosryahmed@google.com>
Subject: Re: [PATCH bpf-next v1] bpftool: Add support for querying
 cgroup_iter link
Message-ID: <20220830180623.hi6ma6nql4by23sr@kafai-mbp.dhcp.thefacebook.com>
References: <20220829231828.1016835-1-haoluo@google.com>
 <016bdefd-ff75-35ca-52a5-0e058e0a5d04@isovalent.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <016bdefd-ff75-35ca-52a5-0e058e0a5d04@isovalent.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?mKpIbAbRFtCmEphYi2VZ9nWOQI7R2bykNKQvkC3lLktndilLf4zt+Uy/5DxF?=
 =?us-ascii?Q?+f9jkOcQ3sRHOljduMkZOn61Hy+8XafuKxaE9qVsd582u6O9C75LRNGsUdEK?=
 =?us-ascii?Q?h4o/n8n6k9xm9WEbLTt7AutY73rNksQDdJoe6CDR28jkEnmVnTtQ+SfNxNFX?=
 =?us-ascii?Q?eISN/c3TP/Wlge03sEY8sft0XZkBVFEx7rtnI4Ut3HBE5KFmjBgJy6lon+Gr?=
 =?us-ascii?Q?h+K/UjEmoNKvPg+cEsq3g7BVSBV9O17I9jP+eUnp6HBIsVADBwWDJx4mFz1Y?=
 =?us-ascii?Q?h0Y7mAxhP52KgtNh9FTKxVJf3t++uXUpjT79UJYxVV+2GiFJuZZ92RkR2QmL?=
 =?us-ascii?Q?TOMnhunvi510E84EPWd5ttltTiLzKrnp9XxE2b2oZlAAHKLUZybVtYITxfbG?=
 =?us-ascii?Q?3Aa0nI6f1fOgV5zUjg/LvB0gagIvxe3kcateZ0ThNTQDp+XZIbFs/Pm8DWpM?=
 =?us-ascii?Q?QnhSVu09rqNhY/TTE0zBiUlAOD0TlMiKbGppm4UIiPh4/CNNPXn4QHB26wFk?=
 =?us-ascii?Q?Zd3lylRUcaOuM0yQl9l5FyB+VzBszxmI0GaHiX0tv7kTU99LU59tX8FUFz8l?=
 =?us-ascii?Q?IbrXoBO5odpid+TaYKFBSwIOjvz1MFXqioBkpepPER4GUuMx2rZFqs4gO5jf?=
 =?us-ascii?Q?lPa65TCBcd4pH4+gEV1sjPetLqhn8plyt9V/8/8nMya15UB+7R9r6DokOrdW?=
 =?us-ascii?Q?VMmQWKhQiyKXu2mI6xFnBK2TFVlaM/gP/Cx0Hx9oQh7Zhbi6DItWgrQZKmRD?=
 =?us-ascii?Q?2h3tCtWLaJbh127T2x7w53ReRjOa/+qAY5P9GcGir2+hIT7eXYy9tjhzA335?=
 =?us-ascii?Q?wsOtyoIRWctd5pnI1s3fa4nyn0JRkq2o5MDxNn4WOSR6DxdugJUa9qXrzIG2?=
 =?us-ascii?Q?KpkQmEOKh24Zh/z8yPlJWKU7zF3kkWFKK4lLtlCwpRDXPzAlr/lIyT+eSONI?=
 =?us-ascii?Q?c7LmZ/+vSSxZ/u41rJFVxLGgWNpYlToQC3x/UR4juSdLxXaS0k7VgcSwKVqs?=
 =?us-ascii?Q?NdzOKS5UxdzYhQ3tzAFy2QTYFEowUjaPAyMmbB5avHe4s2C86d7HSzhm8/IK?=
 =?us-ascii?Q?TfxgHDsKjSG8Ou2NFGWW3Li07hoeDTT4QGUm9iRLBqXuZ1WXLZ2g8WOZpqeZ?=
 =?us-ascii?Q?Sk+juJ5cIECMWhzUyADPDxX8i/QqYCjgmLoCzw8Mfg3+tqRyVZPs3U87kQJu?=
 =?us-ascii?Q?3CPvEYG9LLJdF99HQxkWfvmB10dXViuHvTowA1185Ull4uD4yAhgMdiYZzox?=
 =?us-ascii?Q?OIALMKz/djL2Kd/nHqeY3GsI2rxi9fJfVNXgqsE8XeVumKbjXedhXIHwN/dF?=
 =?us-ascii?Q?Z5VMn3b8jsUe+XFZb+GQZRJrGTo8t7kewYdHQuTDELvGfFfZj4WGjVS22cZT?=
 =?us-ascii?Q?zENAowoUgiPpkD8vSoh0fppu4i2rJ5WM3EHQYfFYciXo3jU5UsF1gMua6fFi?=
 =?us-ascii?Q?O/jE8p8oi0RcjmikxmJwm2K5twrnC3UTbMiD1ZLU1ve20dTq89YQbm4DhkFy?=
 =?us-ascii?Q?5dIYIlU5gdn2jEdbSY2ORpiHFCQ5vAFGdg82FR5iV6hTM/L60II8rWsxzXSB?=
 =?us-ascii?Q?xP73e0gJIbPvlnRRmwvb9rXflX9TeCIjimfMR2WskLxmhu7l0BqWeZYjsI7R?=
 =?us-ascii?Q?eA=3D=3D?=
X-OriginatorOrg: fb.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f61475bb-b5ec-4f9c-296d-08da8ab25b12
X-MS-Exchange-CrossTenant-AuthSource: MW4PR15MB4475.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 18:06:28.9957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4d9uRx7rNnqETulj6DdOrocFleFFWpPC2QCC+hO2Z3vC9WknrQICgnFPYeqfrHLZ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3319
X-Proofpoint-ORIG-GUID: pt-5oBfS3hb4CUsac3OT7Zf9Ei_nRF-Y
X-Proofpoint-GUID: pt-5oBfS3hb4CUsac3OT7Zf9Ei_nRF-Y
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-30_10,2022-08-30_01,2022-06-22_01
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 30, 2022 at 02:33:47PM +0100, Quentin Monnet wrote:
> > +static const char *cgroup_order_string(__u32 order)
> > +{
> > +	switch (order) {
> > +	case BPF_CGROUP_ITER_ORDER_UNSPEC:
> > +		return "order_unspec";
> > +	case BPF_CGROUP_ITER_SELF_ONLY:
> > +		return "self_only";
> > +	case BPF_CGROUP_ITER_DESCENDANTS_PRE:
> > +		return "descendants_pre";
> > +	case BPF_CGROUP_ITER_DESCENDANTS_POST:
> > +		return "descendants_post";
> > +	case BPF_CGROUP_ITER_ANCESTORS_UP:
> > +		return "ancestors_up";
> > +	default: /* won't happen */
> > +		return "";
> 
> I wonder if that one should be "unknown", in case another option is
> added in the future, so we can spot it and address it?
I added "unknown" and applied.