Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 19:21:35 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Wei Yongjun <weiyongjun1@huawei.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org
Subject: Re: [PATCH -next 4/4] spi: mockup: Add documentation
Message-ID: <Yw5VL2MsJ4L6vLRF@sirena.org.uk>
References: <20220826144341.532265-1-weiyongjun1@huawei.com>
 <20220826144341.532265-5-weiyongjun1@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="TvtZemuiz5sCf+Us"
Content-Disposition: inline
In-Reply-To: <20220826144341.532265-5-weiyongjun1@huawei.com>
Precedence: bulk


--TvtZemuiz5sCf+Us
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 26, 2022 at 02:43:41PM +0000, Wei Yongjun wrote:

> +The typical use-case is like this:
> +        1. load this module
> +        2. use bpftool to load BPF program
> +        3. load the target chip driver module

This needs to go into a bit more detail on how one is expected to
obtain a copy of bpftool I think (or point to some good
documentation, I can't seem to find any in tree right now),
things may have changed since the last time I looked into this
but in the past the userspace tooling for BPF had some extremely
ambitious build dependencies which would be a fairly substantial
barrier to entry.

> +Compile your copy of the kernel source. Make sure to configure the spi-mockup
> +and the target chip driver as a module. Prepare a dts described the spi-mockup
> +device.

As I said in another mail the DT part of this appears to be
inappropriate, the driver should just allow the creation of
virtual devices.

--TvtZemuiz5sCf+Us
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMOVS4ACgkQJNaLcl1U
h9Cq6wf9GYh8XeiXuu/caGDq8OMy5MOOjg5WDignKSUxW2jhdMl45BWR9uCfHO/C
oGs5x4l1eLMq9NQ2Z7tOCf78/7XEMwjQ1dBySk89/MvkL2L6fsWOXc44jvkvygR3
rFMJrxDLDW114l7IsLebsctZ2Na7nbjt1tz+ZyfpMF05grdcR1G/ygU/eiJQ4cP5
Mn2vMw34d+UfEMC15ZMzTDfKusk/Z+VbBhBSyDJVROpgNoLAVHPGXnqUfqkuT+s8
z1bGuvyop0hN/e0STh7Ssws0g8bVgBblXGd/Dwr2RYkBMepZVE5gmyIHOfN68g4N
RQfBF/0jr82w58GLL56bT+cjhDzD2Q==
=4dZD
-----END PGP SIGNATURE-----

--TvtZemuiz5sCf+Us--