Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 20:11:47 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Wei Yongjun <weiyongjun1@huawei.com>
Cc:     Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        linux-spi@vger.kernel.org
Subject: Re: [PATCH -next 1/4] spi: mockup: Add SPI controller testing driver
Message-ID: <Yw5g8zalllhRxd9Z@sirena.org.uk>
References: <20220826144341.532265-1-weiyongjun1@huawei.com>
 <20220826144341.532265-2-weiyongjun1@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rAsQXulb1Pv6CUsu"
Content-Disposition: inline
In-Reply-To: <20220826144341.532265-2-weiyongjun1@huawei.com>
Precedence: bulk


--rAsQXulb1Pv6CUsu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 26, 2022 at 02:43:38PM +0000, Wei Yongjun wrote:

> @@ -0,0 +1,221 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * SPI controller Testing Driver
> + *
> + * Copyright(c) 2022 Huawei Technologies Co., Ltd.
> + */

Please make the entire comment a C++ one so things look more
intentional.

> +	master = spi_alloc_master(&pdev->dev, sizeof(struct mockup_spi));
> +	if (!master) {
> +		pr_err("failed to alloc spi master\n");
> +		return -ENOMEM;
> +	}

Please use the new _controller() API, we're trying to remove the
use of outdated terminology.

--rAsQXulb1Pv6CUsu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMOYPIACgkQJNaLcl1U
h9B3Dgf9GwTmEIp7x3InIXeoHPy2V3m9g+OvVUr6fte0ryePE4q1K4Y8FkvlCuhz
rPpAUESzkpdAWhqBeG90GN64cq4vE7Sd9GFzNhiH6B6HJ6dbD7qzisyWZ1jZyaC1
PyqzSWIzH6TIbWUvO5KeKFk3b/MB69UK+ySAkx1cNy8cLDISD66tKC+ik70NFwxj
fP0Rxq17y9l4eIabW5VC54TwwtxMX5IlkqY0qZd4Vq1Qpm/LMojrL4Np3CN8/gYu
V3N1mAvQDIQzegCkdxgwpiZIxngbD/oOh965Xebpu/BRkzXMS5Q+m3SLvUdKSnHr
Up9Frzo2lSXuOU6MgacfB/DjpbhtgQ==
=EOT4
-----END PGP SIGNATURE-----

--rAsQXulb1Pv6CUsu--