Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Vladimir Oltean <olteanv@gmail.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com,
        Colin Foster <colin.foster@in-advantage.com>,
        Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Tobias Waldekranz <tobias@waldekranz.com>,
        =?UTF-8?q?Marek=20Beh=C3=BAn?= <kabel@kernel.org>,
        Ansuel Smith <ansuelsmth@gmail.com>,
        DENG Qingfang <dqfext@gmail.com>,
        =?UTF-8?q?Alvin=20=C5=A0ipraga?= <alsi@bang-olufsen.dk>,
        Linus Walleij <linus.walleij@linaro.org>,
        Luiz Angelo Daros de Luca <luizluca@gmail.com>,
        Felix Fietkau <nbd@nbd.name>, John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>
Subject: [PATCH net-next 1/9] net: introduce iterators over synced hw addresses
Date:   Tue, 30 Aug 2022 22:59:24 +0300
Message-Id: <20220830195932.683432-2-vladimir.oltean@nxp.com>
In-Reply-To: <20220830195932.683432-1-vladimir.oltean@nxp.com>
References: <20220830195932.683432-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+6n6ddAECgAdvap7qsUsgd8hOrkLGVCkilvPmY6+uz4ucwMwqUu3DtMddJbQ?=
 =?us-ascii?Q?L75per88oEXLSwbyhq/R5Don8ZculB5xtF3d32Nt+fETtfVPOPG2x4CPATe9?=
 =?us-ascii?Q?AKxHkA/r8AEj10EGT3BN3/B7GZ2PdwnOJ5AkSTaOAu0IWeSG/JGCDovAlBHB?=
 =?us-ascii?Q?u2spp88aAt+W0wRj8e5hKF5s5ZAiGdGHpaMHwEacylkemDyTRcz/rCxSC1Fc?=
 =?us-ascii?Q?bJmhKIl7Tu/FEt4qa4vySlx1v7xKiBO5zytxaIw3yC7RIHe+UFuWioudjVXh?=
 =?us-ascii?Q?dT45YBep5Hm8aXqbB+ViNIUg6nYhNx3YN9gRzwKDpsWkVbVKRrpo03GsNkVI?=
 =?us-ascii?Q?FV3CzHd1ZuI9kxcn8yQECFMWEKDpYzFbcJhBfV2Gs7h8nTYdRDE6V+1OjiU8?=
 =?us-ascii?Q?aGO1qSVRjsoF40txqMQjoUFLPWwgAm2cZoCmVUFcZTHCWoW+LH0SUkKfDFRH?=
 =?us-ascii?Q?feMQbiJd8jxRSsKsETK6kyiEefMbmSo1uZl+TJ2d3bhor+hAtamTSlrHtXLr?=
 =?us-ascii?Q?r4RBsmHku0GzOqY7Yt5R+2Jcy7VlB1j10xVyZj47BNRvAdDT0RTbiYLBtDtH?=
 =?us-ascii?Q?M/ozrQet4sbt2eYBxdqOT+VYijhLnlNYIgK1yRSLodenhmyC9iWwOw7olFpA?=
 =?us-ascii?Q?BfxRMQQiMSdidSX8ZQ2APBJsTYQl+0qSiGD+ffPS9GzsGW/mWACLPURYyzdu?=
 =?us-ascii?Q?k9PTz1vUSOWVeax3VPbkDkG9fgVgGBTWg5oh0QS65ZeoemI2cFqiQ3eEPC7o?=
 =?us-ascii?Q?Ndh8vpzqxewE9aUvdglaXmdZKPsKiu1Mshd+I3IypW0aqGW+Daq+rVVCEhwG?=
 =?us-ascii?Q?bOZCHz+COfcIGOFApf3PBJuxeXYB9hFZQuO/pEqQSbViZ5iShs9/htpM508P?=
 =?us-ascii?Q?foUkvUsphLwOYoZiOm5g65/2/FZQ3u5Hux0D3AIqx5COYIqoV185gL6TMEse?=
 =?us-ascii?Q?MM2iS8set350tPGiRFM7xd3hT3Q1yHCbQrOu8Jc7ofB4mw5qDhLpvawrIalY?=
 =?us-ascii?Q?853Xn8M8YN80GwoG8bXfcwVjwhu4gK1rPVyt0HT/zFYDzS9KoaKi/5Y2o9rF?=
 =?us-ascii?Q?mWzO+m+Mn1sgRV8uAO26xUX/Tm5iB+ek5l46iUvc+oDC5hy7xpXFsSQg+Qcw?=
 =?us-ascii?Q?F4xqbjFYmUuTnJNMwTncxdFC51Md2eYKTt458fRpnnuyJDRr/5X5TqE6/6mv?=
 =?us-ascii?Q?U+656vZFad0MCoVT0wBZu/yYbqe33CUjIWUTUeEy0e/8XP/vgWpplPUvf8B4?=
 =?us-ascii?Q?tk7tUYh58rkqjL++m2JwEvEJ+aEcFbm3+p2Gk0RjUzuyfkdRgGhVW3ywNHM/?=
 =?us-ascii?Q?OwOk6HwR1IH/l1AtkNadgUtga2BNu59zYf/lnsLcsQrgoGLrrmXhu0Nr4bgY?=
 =?us-ascii?Q?mI9LQXIOBOc+lDaKgwP3oEHb0144KvXWfx0iAHkqx+9je9mecDvwmIO+WkBA?=
 =?us-ascii?Q?T13fTfVG6mUN6mUCV/VcXVD7o7Wx1DIDN1XayVYjKzBUr5iPwtrORqdntFDk?=
 =?us-ascii?Q?2+G0sDGh8wk6VyxBECQh/abKeziwc/j/GIR64xLs34m018G15e+6G+aDJOAw?=
 =?us-ascii?Q?vfAlSPPYxLMf+0g1RMZR4eol3Q+EeGEB5r7y2ZG+f1+HyBKYQf0lhWjSg6+n?=
 =?us-ascii?Q?6Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e3fcd36-97fa-4ec4-2559-08da8ac22ea4
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 19:59:43.9488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5+h8oljntjcF+3hKDuz4UJ5nrDDiyHaEcrVI0uceru6pKNCyx1r9Epdbhz3mCH420u67KFqwWF4Uh+/ybQ1dWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6270
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Some network drivers use __dev_mc_sync()/__dev_uc_sync() and therefore
program the hardware only with addresses with a non-zero sync_cnt.

Some of the above drivers also need to save/restore the address
filtering lists when certain events happen, and they need to walk
through the struct net_device :: uc and struct net_device :: mc lists.
But these lists contain unsynced addresses too.

To keep the appearance of an elementary form of data encapsulation,
provide iterators through these lists that only look at entries with a
non-zero sync_cnt, instead of filtering entries out from device drivers.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
---
 include/linux/netdevice.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index eec35f9b6616..2979293b966c 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -253,11 +253,17 @@ struct netdev_hw_addr_list {
 #define netdev_uc_empty(dev) netdev_hw_addr_list_empty(&(dev)->uc)
 #define netdev_for_each_uc_addr(ha, dev) \
 	netdev_hw_addr_list_for_each(ha, &(dev)->uc)
+#define netdev_for_each_synced_uc_addr(_ha, _dev) \
+	netdev_for_each_uc_addr((_ha), (_dev)) \
+		if ((_ha)->sync_cnt)
 
 #define netdev_mc_count(dev) netdev_hw_addr_list_count(&(dev)->mc)
 #define netdev_mc_empty(dev) netdev_hw_addr_list_empty(&(dev)->mc)
 #define netdev_for_each_mc_addr(ha, dev) \
 	netdev_hw_addr_list_for_each(ha, &(dev)->mc)
+#define netdev_for_each_synced_mc_addr(_ha, _dev) \
+	netdev_for_each_mc_addr((_ha), (_dev)) \
+		if ((_ha)->sync_cnt)
 
 struct hh_cache {
 	unsigned int	hh_len;
-- 
2.34.1