Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220830154500.18165-1-cgzones@googlemail.com>
In-Reply-To: <20220830154500.18165-1-cgzones@googlemail.com>
From:   Paul Moore <paul@paul-moore.com>
Date:   Tue, 30 Aug 2022 17:04:38 -0400
Message-ID: <CAHC9VhTe92h-FR0GOepVrPqWwOgKLPV6NcXxi4sRpAjEbPkt5w@mail.gmail.com>
Subject: Re: [PATCH] selinux: use int arrays for boolean values
To:     =?UTF-8?Q?Christian_G=C3=B6ttsche?= <cgzones@googlemail.com>
Cc:     selinux@vger.kernel.org,
        Stephen Smalley <stephen.smalley.work@gmail.com>,
        Eric Paris <eparis@parisplace.org>,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Aug 30, 2022 at 11:45 AM Christian G=C3=B6ttsche
<cgzones@googlemail.com> wrote:
>
> Do not cast pointers of signed integers to pointers of unsigned integers
> and vice versa.
>
> It should currently not be an issue since they hold SELinux boolean
> values which should only contain either 0's or 1's, which should have
> the same representation.
>
> Reported by sparse:
>
>     security/selinux/selinuxfs.c:1485:30: warning: incorrect type in assi=
gnment (different signedness)
>     security/selinux/selinuxfs.c:1485:30:    expected unsigned int *
>     security/selinux/selinuxfs.c:1485:30:    got int *[addressable] value=
s
>     security/selinux/selinuxfs.c:1402:48: warning: incorrect type in argu=
ment 3 (different signedness)
>     security/selinux/selinuxfs.c:1402:48:    expected int *values
>     security/selinux/selinuxfs.c:1402:48:    got unsigned int *bool_pendi=
ng_values
>
> Signed-off-by: Christian G=C3=B6ttsche <cgzones@googlemail.com>
> ---
> Previous patch proposal: https://patchwork.kernel.org/project/selinux/pat=
ch/20220502135907.31035-1-cgzones@googlemail.com/
> ---
>  security/selinux/selinuxfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Merged into selinux/next, thanks!

--=20
paul-moore.com