Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 17:11:34 -0400
From:   Tom Rini <trini@konsulko.com>
To:     =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH] dt-bindings: nvmem: u-boot,env: add basic NVMEM cells
Message-ID: <20220830211134.GW7942@bill-the-cat>
References: <20220703084843.21922-1-zajec5@gmail.com>
 <39a59ca1-642f-40de-f71d-842f9753372b@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="HdZAANC5GEQnh8Bp"
Content-Disposition: inline
In-Reply-To: <39a59ca1-642f-40de-f71d-842f9753372b@gmail.com>
Precedence: bulk


--HdZAANC5GEQnh8Bp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Aug 16, 2022 at 11:26:37AM +0200, Rafa=C5=82 Mi=C5=82ecki wrote:
> On 3.07.2022 10:48, Rafa=C5=82 Mi=C5=82ecki wrote:
> > U-Boot doesn't have cells at hardcoded addresses. They are stored in
> > internal format. It's still important to define relevant cells in DT so
> > NVMEM consumers can reference them.
> >=20
> > Update binding to allow including basic cells as NVMEM device subnodes.
>=20
> Ping :)
>=20
>=20
> For a reference you can see Broadcom's NVRAM (identical feature):
>=20
> 084973e944bec ("dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells")
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/?id=3D084973e944bec21804f8afb0515b25434438699a
>=20
> c8442f0fb09ca ("ARM: dts: BCM5301X: Add Ethernet MAC address to Luxul XWR=
-3150")
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/?id=3Dc8442f0fb09ca3d842b9b23d1d0650f649fd10f8

Seems fine to me.

Reviewed-by: Tom Rini <trini@konsulko.com>

--=20
Tom

--HdZAANC5GEQnh8Bp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmMOfQIACgkQFHw5/5Y0
tyznWgv+NTLNw1wbSDVBOO1gGdWW3yh53GYCEZ2xidxxzKU+F1L70mWCE/2Zvoyn
SHp+sGXMKpRSOgdAx1DleOd3Bta4PvAYo9+8ldx7o4DH2hGnwsDGkIUisiq/64TN
oavrFlk1IvQgYkLzzW0B+/OYeESfYLx8VWVCDUiFctmOQcH46yzWRPNhufbiSRGW
Wh5XrDIiodOAFo2hVg+2hUUlDuZTF6iyzix/rPmXpwGaHusRxfws7WgCMRkOj24i
YKFgUY/ldLXS94CYVPddnzXZsyrXAiI7YcSunnYlM/nLgFHvSKPMAGjE+QjAME61
TlQJ4fUnjxTmabqxWuAxeGuXM9BH/NsT6qObkJCOCyMGazAMjXl4oo26Gy00CoCk
X/K3zbTetu0tC4UnMGAWJ/wg5tJeqdcdwOCMJ47xXtjy+S2yNZcm7ohRZWBWupKM
EG/plRZ+JNrThu3zMGIkJ8dw19h/5ddfbiudW4v6tRhXdqiH7olLPUIC+Bn15CZ/
mFDm+sF1
=aJlP
-----END PGP SIGNATURE-----

--HdZAANC5GEQnh8Bp--