Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4697299rwe; Tue, 30 Aug 2022 15:20:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ZKz6hNb0wJuhQbt6Xv7R4VTsl561dheUyI5KnBQ4aM8PJZKafX5NLREBpJHilof79HRtb X-Received: by 2002:a63:2a90:0:b0:42f:a7bc:800d with SMTP id q138-20020a632a90000000b0042fa7bc800dmr3249543pgq.447.1661898043742; Tue, 30 Aug 2022 15:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661898043; cv=none; d=google.com; s=arc-20160816; b=lO+Ydfq1UxOfhhUrjjsPuToOvLb8eizzJ1qQBKfrAkGNSjNZypJh/rRAGcVrXMLirc ifmkSa1S1JLhscgKqEcPZnoZTN3qm8AGx2UdcPzOgbnHFLe3NX5sxsRV3F03wv8ip7Wc b3+AdPZD8DMwblYtFKxqrCawnLKtbMhyFi7rJaJ2EBibA78sw78WfvmzTtau5qzXo2u1 BVL/UF4udX/dHDY73XbvcbbDGsZ2CtTbivywHApbH/XYQDOfbPrfM28NXnSlX3FPt5yU R0YDrw7CZEnfJs9SLJMEG9WCvxqtmBSHoU2eKfpk87QXOfV78KGdxreJkNkwIFbxy4rs qzQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yxuPGAgyr2YjlkXSwoWeZko/CUmlXgmDG76kUE3q7zA=; b=Q3wt4y5oM/1EIHotDKecWPYTLTIpNkEgnL7O90hRYmmB8CztytgpWNv7m0k/j6Ssvn 8IYo/WB1BZTKnxAoI7zdNZg0ywxaracBPHcuOvkFw9yb+wkkVzpgiEE+BoAk3kZVl4hz ujamlGmC39MjxG79hWEhG11EFJS0eeaTZwjL8146OclFoKoenDray4BQlMq2en6sSovL Z0RTHk7hw/ogueyOvt03Yejl3aI/E5NXX2aVnlFTSprQ/HWnb3EaeNdUfR4dSRmZBPlj TEYikh1UMwEqfA9PGTrRsONz6i0s5eqIOvRXhA1bb01CM2/HcK9XSWqcHmEoPL3fq8pR qRRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=aH4Waxy1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t1-20020a170902b20100b00174a12d524fsi7058224plr.585.2022.08.30.15.20.32; Tue, 30 Aug 2022 15:20:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=aH4Waxy1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbiH3Vn6 (ORCPT + 99 others); Tue, 30 Aug 2022 17:43:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231669AbiH3Vnl (ORCPT ); Tue, 30 Aug 2022 17:43:41 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D1EC8C45D for ; Tue, 30 Aug 2022 14:43:33 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id f24so9618763plr.1 for ; Tue, 30 Aug 2022 14:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=yxuPGAgyr2YjlkXSwoWeZko/CUmlXgmDG76kUE3q7zA=; b=aH4Waxy1Ly1CTXiseORnUequMFv5g4WKFXKSK01Tg3E5FoZ7Voi3A6YVqRdS/Dd0Yl 1IoVc+nowFtPr5sPbdRIHZ1iyG9u4lJTSJyCUmSP0X7QPDn3TFtRJYxHIeF3+PHo083R QBmouR14BZZWovfe7pvOcUGHQWH546mpL+nAEYCtDfZjacoRQiIDC7mlRqp0vVxvWbG7 QNG0bk3KcvENRkbms8yzQC87X4mXCIxqcG9eNc8FQ43O7QkXjA43sNzxIXJ5HI8HjdL/ ciJz06EE+gFPjAaYrwoEe1da4NDUZ9u5CAwUolpEhve8fC45OLNAdyfxeU4E3Gyyxus2 pZcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=yxuPGAgyr2YjlkXSwoWeZko/CUmlXgmDG76kUE3q7zA=; b=1pf0igiPufFgubYBFEn1g3tnHzRm+Cyz9HP0hkeLhyAiwO8mix69F6oKW5MHo38rYi EDLwYb31XNmFOELhMrML0MN1/WQKnrw+6SRmQ1Nq+1o1+D0IreWt9QmVat9Hc8Zp8t1X VrpvvxRGdRRzB6/nh4RfDpCu3IGkhRLvKoZty5qeHCnDTR5hO9s6CvtvP812sBISbDY1 uXs73GHMDUge7Tmvlw7lrZmKCQroHMitkpYbICtcsOnYhPm6rIBAvat935lvVSXP73/h 1zzpxN/MnsEXheZhlD8ACvCHdycVyM9YvtQMdmUuor7PPrDU15cgJSX7uyZrDTr7J+3w c6cg== X-Gm-Message-State: ACgBeo1B4872vSkcQ9dh181rhif3H8Q6efQo4iJnANIFRItwRQHt7hZl 9GXBVbDHnoPL3RECg7yPRXqw5Q== X-Received: by 2002:a17:902:edd5:b0:174:a6e6:51f4 with SMTP id q21-20020a170902edd500b00174a6e651f4mr13206714plk.82.1661895812536; Tue, 30 Aug 2022 14:43:32 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id j8-20020a170903024800b00172e97382cdsm10404872plh.285.2022.08.30.14.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 14:43:32 -0700 (PDT) Date: Tue, 30 Aug 2022 21:43:28 +0000 From: Sean Christopherson To: Uros Bizjak Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini Subject: Re: [PATCH] KVM/VMX: Avoid stack engine synchronization uop in __vmx_vcpu_run Message-ID: References: <20220816211010.25693-1-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816211010.25693-1-ubizjak@gmail.com> X-Spam-Status: No, score=-14.9 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,FSL_HELO_FAKE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022, Uros Bizjak wrote: > Avoid instructions with explicit uses of the stack pointer between > instructions that implicitly refer to it. The sequence of > POP %reg; ADD $x, %RSP; POP %reg forces emission of synchronization > uop to synchronize the value of the stack pointer in the stack engine > and the out-of-order core. > > Using POP with the dummy register instead of ADD $x, %RSP results in a > smaller code size and faster code. > > The patch also fixes the reference to the wrong register in the > nearby comment. > > Cc: Paolo Bonzini > Cc: Sean Christopherson > Signed-off-by: Uros Bizjak > --- Pushed to branch `for_paolo/6.1` at: https://github.com/sean-jc/linux.git Unless you hear otherwise, it will make its way to kvm/queue "soon". Note, the commit IDs are not guaranteed to be stable.