Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4697352rwe; Tue, 30 Aug 2022 15:20:48 -0700 (PDT) X-Google-Smtp-Source: AA6agR4cB8uc/L1ivZ+0I7eiLGHphprQglR+6cqMrMC8bYpZxTbS0JPcFpYG/43LwVcmpzmYPJYI X-Received: by 2002:a17:907:a412:b0:731:6cc2:adfe with SMTP id sg18-20020a170907a41200b007316cc2adfemr18319268ejc.74.1661898047881; Tue, 30 Aug 2022 15:20:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661898047; cv=none; d=google.com; s=arc-20160816; b=RsXH+8az73KI8ciFAzpr7dcCqUg6CO4GJaeXz6sSzIT+7w0mis6OZwFtCXfNEVs5xN q62VmRZVDBquhRXt3fbJ5wcu8x3Obur2yFzh34KVFJ0Pm/h4v/vzrOJ7aTpYvk66ozBZ 7Kaa+kygbhB/bjID+gRrq1DtljIR5fldqKH3WghY7GD2piab5/pHNKNU4Bi0k2P/HVs8 F74VQ3Mt2CebqeHoqodQ/vY8zZ8rvO2Wqqwfmb7Z78z+41bo2VEfdGCBFs+aEqq/OSmB cHq/BwY+gLpuIcc9GyVcZOk1K8dB5JlpCJzWicBKd9Vzlwx1onFcltN2RYt0AFv0KeZP X5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :from:references:cc:to:subject:dkim-signature:dkim-filter; bh=H4pBLvAI9R+wgPCax8y/jka5mJJpIpyiO8HeYXP4rEw=; b=0L2cvQ+PjD4qcCR7PNrCz2V6m5fbVsPtCTiAIwOD+rww3WKd1rcT7dgqhmKLbkVGs1 WbqkQo/Lxbrxn/B317zoF1lDjzCyf5lOoZ8X4v2KDq7Tv9nbsHhB9CgYKw+NIDF+536q cFZqiEMDlef6wjRjWq8se/vjgS+Rf/o07RRkT9EdpXV9Yw6bj0vvJswOk4X/QNPYyZBg OswlGHzhN5EF3iuxLTb8hFo4KTxdJ9Mfw1Uf3zgZXsO9sfz5NsseXtAs2frbpQBso3Hm BNdLh1Sn4RWu+K5H3aASeEgGngF0U8pXfcTDYRkR+UkPzzE0B6Dp6NqUWPcsoj2W+oAJ Dkdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=TL4+g8Sx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa18-20020a170907869200b007303646197csi10877359ejc.596.2022.08.30.15.20.21; Tue, 30 Aug 2022 15:20:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@candelatech.com header.s=default header.b=TL4+g8Sx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=candelatech.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbiH3V2U (ORCPT + 99 others); Tue, 30 Aug 2022 17:28:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbiH3V2S (ORCPT ); Tue, 30 Aug 2022 17:28:18 -0400 Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FDFA85FC5; Tue, 30 Aug 2022 14:28:17 -0700 (PDT) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.64.219]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 25A481A0073; Tue, 30 Aug 2022 21:28:16 +0000 (UTC) Received: from mail3.candelatech.com (mail2.candelatech.com [208.74.158.173]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 33301780070; Tue, 30 Aug 2022 21:28:15 +0000 (UTC) Received: from [192.168.100.195] (50-251-239-81-static.hfc.comcastbusiness.net [50.251.239.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail3.candelatech.com (Postfix) with ESMTPSA id 6D97413C2B0; Tue, 30 Aug 2022 14:28:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 mail3.candelatech.com 6D97413C2B0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=candelatech.com; s=default; t=1661894894; bh=Xw+SMBDS75GqlWjS1K/WS221CfX1aJCpqfyBYoK8CUs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TL4+g8Sx4JnxhkJ0rvMhWCpI6es867RIqoK4q9sUEH7pCCf34TziUjq17tX3uFa+q EBT5eSboFg+Xr+ZV3EZP2F2KHl6ST82xyBvxt5j8UCkrJYsvnw0mgt96PRhVJ6oHtZ iSU+kfeDOW306ca6fTSs0K4fFyf8t5MDLW+hPJgI= Subject: Re: [PATCH 5.4 182/389] PCI/portdrv: Dont disable AER reporting in get_port_device_capability() To: =?UTF-8?Q?Pali_Roh=c3=a1r?= Cc: Greg Kroah-Hartman , bjorn@helgaas.com, LKML , stable@vger.kernel.org, Stefan Roese , Bjorn Helgaas , "Rafael J. Wysocki" , Bharat Kumar Gogada , Michal Simek , Yao Hongbo , Naveen Naidu , Sasha Levin References: <20220823080115.331990024@linuxfoundation.org> <20220823080123.228828362@linuxfoundation.org> <47b775c5-57fa-5edf-b59e-8a9041ffbee7@candelatech.com> <20220830205832.g3lyysmgkarijkvj@pali> From: Ben Greear Organization: Candela Technologies Message-ID: <00735f18-11f9-c6c6-4abf-002d378957df@candelatech.com> Date: Tue, 30 Aug 2022 14:28:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20220830205832.g3lyysmgkarijkvj@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-MDID: 1661894896-V-WlHjyAQeBY X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/22 1:58 PM, Pali Rohár wrote: > On Tuesday 30 August 2022 13:47:48 Ben Greear wrote: >> On 8/23/22 11:41 PM, Greg Kroah-Hartman wrote: >>> On Tue, Aug 23, 2022 at 07:20:14AM -0500, Bjorn Helgaas wrote: >>>> On Tue, Aug 23, 2022, 6:35 AM Greg Kroah-Hartman >>>> wrote: >>>> >>>>> From: Stefan Roese >>>>> >>>>> [ Upstream commit 8795e182b02dc87e343c79e73af6b8b7f9c5e635 ] >>>>> >>>> >>>> There's an open regression related to this commit: >>>> >>>> https://bugzilla.kernel.org/show_bug.cgi?id=216373 >>> >>> This is already in the following released stable kernels: >>> 5.10.137 5.15.61 5.18.18 5.19.2 >>> >>> I'll go drop it from the 4.19 and 5.4 queues, but when this gets >>> resolved in Linus's tree, make sure there's a cc: stable on the fix so >>> that we know to backport it to the above branches as well. Or at the >>> least, a "Fixes:" tag. >> >> This is still in 5.19.5. We saw some funny iwlwifi crashes in 5.19.3+ >> that we did not see in 5.19.0+. I just bisected the scary looking AER errors to this >> patch, though I do not know for certain if it causes the iwlwifi related crashes yet. >> >> In general, from reading the commit msg, this patch doesn't seem to be a great candidate >> for stable in general. Does it fix some important problem? >> >> In case it helps, here is example of what I see in dmesg. The kernel crashes in iwlwifi >> had to do with rx messages from the firmware, and some warnings lead me to believe that >> pci messages were slow coming back and/or maybe duplicated. So maybe this AER patch changes >> timing or otherwise screws up the PCI adapter boards we use... > > From that log I have feeling that issue is in that intel wifi card and > it was there also before that commit. Card is crashing (or something > other happens on PCIe bus) and because kernel had disabled Error > Reporting for this card, nobody spotted any issue. And that commit just > opened eye to kernel to see those errors. > > I think this issue should be reported to intel wifi card developers, > maybe they comment it, why card is reporting errors. My main concern is not that AER messages started showing up, but that there started being kernel NPE and WARNINGS showing up sometime after 5.19.0. Possibly this AER thing is mis-direction and the real bug is elsewhere, but since the bugzilla also indicated (different) driver crashes, then I am suspicious this changes things more significantly, at least in a subset of hardware out there. Also, any idea what this error in my logs is actually indicating? Thanks, Ben > >> >> [ 50.905809] iwlwifi 0000:04:00.0: AER: can't recover (no error_detected callback) >> [ 50.905830] pcieport 0000:03:01.0: AER: device recovery failed >> [ 50.905831] pcieport 0000:00:1c.0: AER: Uncorrected (Non-Fatal) error received: 0000:03:01.0 >> [ 50.905845] pcieport 0000:03:01.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 50.915679] pcieport 0000:03:01.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 50.922735] pcieport 0000:03:01.0: [20] UnsupReq (First) >> [ 50.928230] pcieport 0000:03:01.0: AER: TLP Header: 34000000 04001f10 00000000 88c888c8 >> [ 50.935126] iwlwifi 0000:04:00.0: AER: can't recover (no error_detected callback) >> [ 50.935133] pcieport 0000:03:01.0: AER: device recovery failed >> [ 50.935134] pcieport 0000:00:1c.0: AER: Multiple Uncorrected (Non-Fatal) error received: 0000:03:01.0 >> [ 50.935222] pcieport 0000:03:01.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 50.945059] pcieport 0000:03:01.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 50.952120] pcieport 0000:03:01.0: [20] UnsupReq (First) >> [ 50.957614] pcieport 0000:03:01.0: AER: TLP Header: 34000000 04001f10 00000000 88c888c8 >> [ 50.964492] pcieport 0000:03:01.0: AER: Error of this Agent is reported first >> [ 50.970519] pcieport 0000:03:02.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 50.980344] pcieport 0000:03:02.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 50.987399] pcieport 0000:03:02.0: [20] UnsupReq (First) >> [ 50.992891] pcieport 0000:03:02.0: AER: TLP Header: 34000000 05001f10 00000000 88c888c8 >> [ 50.999785] pcieport 0000:03:03.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.009611] pcieport 0000:03:03.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.016665] pcieport 0000:03:03.0: [20] UnsupReq (First) >> [ 51.022161] pcieport 0000:03:03.0: AER: TLP Header: 34000000 06001f10 00000000 88c888c8 >> [ 51.029052] pcieport 0000:03:05.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.038881] pcieport 0000:03:05.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.045931] pcieport 0000:03:05.0: [20] UnsupReq (First) >> [ 51.051430] pcieport 0000:03:05.0: AER: TLP Header: 34000000 07001f10 00000000 88c888c8 >> [ 51.058320] pcieport 0000:03:07.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.068147] pcieport 0000:03:07.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.075200] pcieport 0000:03:07.0: [20] UnsupReq (First) >> [ 51.080696] pcieport 0000:03:07.0: AER: TLP Header: 34000000 08001f10 00000000 88c888c8 >> [ 51.087589] iwlwifi 0000:04:00.0: AER: can't recover (no error_detected callback) >> [ 51.087598] pcieport 0000:03:01.0: AER: device recovery failed >> [ 51.087611] iwlwifi 0000:05:00.0: AER: can't recover (no error_detected callback) >> [ 51.087615] pcieport 0000:03:02.0: AER: device recovery failed >> [ 51.087628] iwlwifi 0000:06:00.0: AER: can't recover (no error_detected callback) >> [ 51.087631] pcieport 0000:03:03.0: AER: device recovery failed >> [ 51.087643] iwlwifi 0000:07:00.0: AER: can't recover (no error_detected callback) >> [ 51.087646] pcieport 0000:03:05.0: AER: device recovery failed >> [ 51.087659] iwlwifi 0000:08:00.0: AER: can't recover (no error_detected callback) >> [ 51.087662] pcieport 0000:03:07.0: AER: device recovery failed >> [ 51.103761] pcieport 0000:00:1c.0: AER: Uncorrected (Non-Fatal) error received: 0000:03:0f.0 >> [ 51.103778] pcieport 0000:03:0f.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.113608] pcieport 0000:03:0f.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.120658] pcieport 0000:03:0f.0: [20] UnsupReq (First) >> [ 51.126152] pcieport 0000:03:0f.0: AER: TLP Header: 34000000 0f001f10 00000000 88c888c8 >> [ 51.133044] iwlwifi 0000:0f:00.0: AER: can't recover (no error_detected callback) >> [ 51.133068] pcieport 0000:03:0f.0: AER: device recovery failed >> [ 51.168925] pcieport 0000:00:1c.0: AER: Uncorrected (Non-Fatal) error received: 0000:03:0f.0 >> [ 51.168940] pcieport 0000:03:0f.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.178773] pcieport 0000:03:0f.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.185823] pcieport 0000:03:0f.0: [20] UnsupReq (First) >> [ 51.191318] pcieport 0000:03:0f.0: AER: TLP Header: 34000000 0f001f10 00000000 88c888c8 >> [ 51.198211] iwlwifi 0000:0f:00.0: AER: can't recover (no error_detected callback) >> [ 51.198234] pcieport 0000:03:0f.0: AER: device recovery failed >> [ 51.260695] pcieport 0000:00:1c.0: AER: Uncorrected (Non-Fatal) error received: 0000:03:0f.0 >> [ 51.260710] pcieport 0000:03:0f.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.270548] pcieport 0000:03:0f.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.277605] pcieport 0000:03:0f.0: [20] UnsupReq (First) >> [ 51.283103] pcieport 0000:03:0f.0: AER: TLP Header: 34000000 0f001f10 00000000 88c888c8 >> [ 51.290009] iwlwifi 0000:0f:00.0: AER: can't recover (no error_detected callback) >> [ 51.290033] pcieport 0000:03:0f.0: AER: device recovery failed >> [ 51.328514] pcieport 0000:00:1c.0: AER: Uncorrected (Non-Fatal) error received: 0000:03:0f.0 >> [ 51.328530] pcieport 0000:03:0f.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) >> [ 51.331638] ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001) >> [ 51.338363] pcieport 0000:03:0f.0: device [10b5:8619] error status/mask=00100000/00000000 >> [ 51.338364] pcieport 0000:03:0f.0: [20] UnsupReq (First) >> [ 51.345413] ACPI: \: failed to evaluate _DSM bf0212f2-788f-c64d-a5b3-1f738e285ade (0x1001) >> [ 51.350900] pcieport 0000:03:0f.0: AER: TLP Header: 34000000 0f001f10 00000000 88c888c8 >> [ 51.350927] iwlwifi 0000:0f:00.0: AER: can't recover (no error_detected callback) >> >> >> Thanks, >> Ben >> >> -- >> Ben Greear >> Candela Technologies Inc http://www.candelatech.com >> > -- Ben Greear Candela Technologies Inc http://www.candelatech.com