Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <64498c9f-a6e1-6379-ca8e-d751fb239bec@intel.com>
Date:   Tue, 30 Aug 2022 15:57:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH 6/6] selftests/sgx: Add a bpftrace script for tracking
 allocation errors
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Shuah Khan" <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
References: <20220830031206.13449-1-jarkko@kernel.org>
 <20220830031206.13449-7-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220830031206.13449-7-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1FUeTFnaFl1MlFPelBaYzJWOW1Kd2tKaTBLZExGSUovUDJTR25ZcFlPUCtV?=
 =?utf-8?B?dm92V0w1T0M5OVNpZjNNblNpM0F0QlJWbUJxVVY1SEZvWlBXRWdMdkZSYkMx?=
 =?utf-8?B?QmJPcENqSE9yMzBtZll0L09NMnhia2RkZGJTRDdhRHBqTVFlMFRsektLMnRa?=
 =?utf-8?B?alNOdUdaTXgvVE9ONHZFTy9DamVhbmpqY3EwWVFiUUpYTEpDNlhtRGZvUm82?=
 =?utf-8?B?ZncyeWkwbkRmRWx0UUQzNkx3bHdrTUhoUXozZkErTmlsaHFsRlZMR1lYUTVF?=
 =?utf-8?B?akFPeWI1ZXdzNko1cUFyeU1JalZyUEN4Wm1ENm9hMzhCcTZreWJRWDRmeHFX?=
 =?utf-8?B?d2x0dURzbG1UM2xZM2t3MGNFWTZuV2g2TDRHSjlGSkZtVFIrNnh2ejdkbmFQ?=
 =?utf-8?B?cjhTb0s5WlE0dm5EUEF0Q0JSK0pMQ05JemdENXhoUklQeC9yWWltVTZlZG9O?=
 =?utf-8?B?RVNGRkV1TXdxZEpxdmtMaUVDbnB0MDUxcGltVkxKZ0QwOXcvbTQyV3pGZzRZ?=
 =?utf-8?B?eWk0V000NGIxcDdJSmlMb25VV3NyTHdBUTRIVkZaTCtXNW5xYndpaVl1M1dU?=
 =?utf-8?B?QklrYkswTTliTnUyUnRIcHllMFVMdEg1S0p2WXNXYm5ITFhRUkxQZG5WZEFy?=
 =?utf-8?B?dkNvZzdPY2lLbEplOWpSekJ3a2tyNVh6WXZFTytydU1WYW9MVG43eXg4aEF2?=
 =?utf-8?B?dVRtczk1RDRMZ0FiZEU5V2VDZkN2RWh6R21pWFQrUk02VFg3STZtOTNUWWZF?=
 =?utf-8?B?OTA2K0QvWDdUb1BJODZBY2xYajQyendBYngzMk1QUG94dHgxWUZJbDlyeUlT?=
 =?utf-8?B?ekVsVEI4UDFqQm9YR0svVE1EbkwrUkxIY1pnODFEdG9LUWpOSmtMcTBkajc2?=
 =?utf-8?B?TFF4d2NoZXRmWnJSWU1JZUlTUVo0WnBDMmdTRnM2dW1yYVRzUEVLamJHNkVR?=
 =?utf-8?B?SFZlWmp4YWZQc3RwWUlNaGNYVUFZbExVaTVJRUZXazFETUlkRHBwYVJGU3NG?=
 =?utf-8?B?dlRpZlh2d0Ntamd0S3JSUXFFem9wdlpKZHcxUGcrV3pkWVhOQTVST1MveVQ0?=
 =?utf-8?B?MjdGS1pPZFR3RUpEOGVOOE42TURvM2tNaGdUb3pEU1dEV0Y0OXFXVGtMeTVp?=
 =?utf-8?B?VEtxcDZCSHk4ZmdtditWSzUzbWl4QSs3VTFrUnZKKzlFRElpeE4vS2lMdlZw?=
 =?utf-8?B?cVpFVkZkTTYrTmo3TjBMM2FMWGZicXkvakpMQ1FybVlvYkZhdE4vVVZXK2VI?=
 =?utf-8?B?NmVxMDY5QjJ0YmRqS2FKUmZieW1uMDBEeGZhWXdPcW5Nek9aNlVla1dBd0JW?=
 =?utf-8?B?RWROYmhqNzdieEgyUXlFcU1SSVdIeFdtRW9DdkgzU2pJTXl5NEhVUFJEb0FQ?=
 =?utf-8?B?S055STlvdVpIeUdaUVNlK0YrbEZZSW1KdDl2UEV4VjJNNkpwZGlZQ1dtazhZ?=
 =?utf-8?B?SXdMdE42TXMyMnVkN3RJTHdTTmJPekVGSE1OckV6S0VwdHJUQXpsdWdGS21O?=
 =?utf-8?B?ZGJ3U1laV3dHT3FGUlpvY3pxRlY4NnYySGVwSCtiUUxyM3BRTW8yVkhlQUlP?=
 =?utf-8?B?d0ozQm5sQkdLR3Ava2JLUmUwRTRKaFU1UldTR2xXaCtRS0FhSGhxWkdSbFh6?=
 =?utf-8?B?RHYwZnJqWFRlOU9LZkFaSjhSSXFwMGJ6a21ZYzRwSGNtdjZTMnE0OVNXdG13?=
 =?utf-8?B?ZFc4R1hJajRvSW5FaWNhU3ZNRzk5ZTE4Y205SkFzNTVkdlJKZkhmQVVHT2ZJ?=
 =?utf-8?B?N0g2Qm9ndS9zVTl3TTlkclAyUTV6bGlqMGUwZ3FQanFzSktqSnNLU2E3czFy?=
 =?utf-8?B?bGp6WjhoTlk5eUgyUTZsN0J0eXA2R1dhL3NTQ3U4NGRMMGVyQTEzRktQZ2th?=
 =?utf-8?B?djgzcHVvellaL3ZqRWlFTlEvb2kydk5WNitYOU1rWFoycm5CMDJmTTV3eGNh?=
 =?utf-8?B?d1MrRHVPNXpkVGJTZmkyb083YkM3bjJxYWpMZldDQVFhM2RuaWhIVVlpOWVZ?=
 =?utf-8?B?THgwa00wN3grRlU5eEhySVhpSW5jU2FFMUljUVMvY1IyRnFhenFqd1RvWlRi?=
 =?utf-8?B?c2hsU2F3R1krd3dneGhjUFhkWVZsVDBFQjloT3Awem9CV1dhZUd0eWpFQjcv?=
 =?utf-8?B?czFrYTByYks0S3JYL1B4MW5mUjMrWEV0aGpHK3BkQmlpUzJVMFFIQU1aK3hQ?=
 =?utf-8?B?a2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5938e17b-92f1-4e6c-41da-08da8adb026d
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2022 22:57:27.0625
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: znA3njhY0ecmgw5imU9NLAv1Rpw2Siem1GyI/v0Rn19hUD6S0pg6ixrK5zwPxzQxbxcJZG4BXAkq9LriAdwPO4sOnxZWhb+Kw6szHUKD/KI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3487
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 8/29/2022 8:12 PM, Jarkko Sakkinen wrote:
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
>  tools/testing/selftests/sgx/alloc-error.bt | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 tools/testing/selftests/sgx/alloc-error.bt
> 
> diff --git a/tools/testing/selftests/sgx/alloc-error.bt b/tools/testing/selftests/sgx/alloc-error.bt
> new file mode 100644
> index 000000000000..9268d50dea29
> --- /dev/null
> +++ b/tools/testing/selftests/sgx/alloc-error.bt
> @@ -0,0 +1,7 @@
> +kr:sgx_alloc_epc_page /(uint64)retval >= (uint64)(-4095)/ {
> +		 printf("sgx_alloc_epc_page: retval=%d\n", (int64)retval);
> +}
> +
> +kr:sgx_encl_page_alloc /(uint64)retval >= (uint64)(-4095)/ {
> +		 printf("sgx_encl_page_alloc: retval=%d\n", (int64)retval);
> +}


Could there be a snippet of comments in this new file to guide users
on how to use this script?

Reinette