Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74683697-df9f-6f8f-00eb-4bb25e1a1638@infradead.org>
Date:   Tue, 30 Aug 2022 16:58:45 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.1.2
Subject: Re: [PATCH -next] fs/hfsplus: Fix some kernel-doc comments
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, axboe@kernel.dk
Cc:     hch@lst.de, bvanassche@acm.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220830074223.20281-1-yang.lee@linux.alibaba.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220830074223.20281-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/30/22 00:42, Yang Li wrote:
> Add the description of @opf and remove @op and @op_flags in
> hfsplus_submit_bio() kernel-doc comment.
> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2013
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>


Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  fs/hfsplus/wrapper.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c
> index 0b791adf02e5..6202e877f459 100644
> --- a/fs/hfsplus/wrapper.c
> +++ b/fs/hfsplus/wrapper.c
> @@ -30,8 +30,7 @@ struct hfsplus_wd {
>   * @sector: block to read or write, for blocks of HFSPLUS_SECTOR_SIZE bytes
>   * @buf: buffer for I/O
>   * @data: output pointer for location of requested data
> - * @op: direction of I/O
> - * @op_flags: request op flags
> + * @opf: operation and flags for bio
>   *
>   * The unit of I/O is hfsplus_min_io_size(sb), which may be bigger than
>   * HFSPLUS_SECTOR_SIZE, and @buf must be sized accordingly. On reads

-- 
~Randy