Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Naohiro Aota <Naohiro.Aota@wdc.com>
To:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "x86@kernel.org" <x86@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH] x86/mm: disable instrumentations of mm/pgprot.c
Thread-Topic: [PATCH] x86/mm: disable instrumentations of mm/pgprot.c
Thread-Index: AQHYt5Z2kef1viI8JUehS9q9jOvbzq3IMSAA
Date:   Wed, 31 Aug 2022 00:25:20 +0000
Message-ID: <20220831002520.czdegytklq7xudnr@naota-xeon>
References: <20220824084726.2174758-1-naohiro.aota@wdc.com>
In-Reply-To: <20220824084726.2174758-1-naohiro.aota@wdc.com>
Accept-Language: ja-JP, en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?SfaU/LIxG2BXc6jMJcltcdKJMyysvwzzGe1Rc4Ju/DfwI8fLLLmwGfHB15V0?=
 =?us-ascii?Q?eVPQLeAx5zdA/HPiGkne/N/h9/ZVW1ntwriJEP2HArm58FPjvgmp5TSvJrFy?=
 =?us-ascii?Q?Hj4T+iDz/ufIlzXlakQedLvESYuWPCEMs+ThYdSmQ9BC10TtAbBj9hWKoHTa?=
 =?us-ascii?Q?i2dGTTu3HFtDmi7jbBxsbhIsfVB6P9Yio3vX8Bju4tp8SJBsMdFLQ9Vue7+J?=
 =?us-ascii?Q?eTundpdWMXh4DASOScKdlTlwpaFPIXOGitcuZ5O2SnARo8HmZ1pEJ4dNPQKT?=
 =?us-ascii?Q?NNJSC/O879bhZyhzrq0QnOIQrPNTzkNc8U3TMw8rWzGwgaR1Ahc3/myCA3oB?=
 =?us-ascii?Q?LGJPYx3KZvml7aFcfgvcMfe4yqHslVT+zk8EsLI6eo3/rj6PbeFoP6i/bT36?=
 =?us-ascii?Q?qVc7bi5PqomMxoVgh/EHrMkbl+vsA2XZgsnJCov+hNWcvrsuDg6XZrZ7YNYu?=
 =?us-ascii?Q?L3v+/2UtBA403P4vJnYqvzgJGApKKXiaP72ahHhrfW93F3xwAJhJo0D/J3KC?=
 =?us-ascii?Q?d8xx4JWU8Nd0eTXe+uLlLJt8bt2XnPBVcjw0/JIAjgsTwuaf8xasyRjP4aFu?=
 =?us-ascii?Q?3eHujNeO1uKx9U8Owa2jz2FMkLqecB8Dzt+cK6+cT7zc9elw4cmZGbT+4+ps?=
 =?us-ascii?Q?qNy9ynCG1oAp1EztsKGmMeXZdsGSUbxrF3zav1cFWE3OUpNU9ojT6UFRnr8t?=
 =?us-ascii?Q?W/fGlhfFmK86f4SJlw7ZRPFNt2imXyV2A5dJhQrypQqN2KNgrCUY8r1NcZLm?=
 =?us-ascii?Q?3S5JqT6jzubmf/8TbByb2awGoiLm6X2tlGkSzE5ViEOMR71wghJVlWmKVBAS?=
 =?us-ascii?Q?VGR8IvLIjvOL7BOq4ubQEsfJA8ebnCC0/G3dE9GVp97QxuIkZEnl39ZEAVNY?=
 =?us-ascii?Q?vDZ1SrvSjnu9OdRZFzRIvAIcJOJC1jqqf2ko7jIpUkwpKa8v7tMC/lnWFnvd?=
 =?us-ascii?Q?KEDmCgEPkPPYJ6u6/e47HtZQ0l7eRVuFtsRHsd7CaLvEhj/sNY5Ykzk94d28?=
 =?us-ascii?Q?K3U52ArhdGgcLpKu6DspbgjCrsYvoWccUw/w5pp3G8HtbtKhHHpkMHUq3BHP?=
 =?us-ascii?Q?6w1z4xWI2rHdI4T7WFUcHvWKyFdD8UQ9v2ZpifwQfx0z6adVIFOm4ffvqvdT?=
 =?us-ascii?Q?ugpJBGUGGFfommrNrsY3rVYZexZOo48Tk60Emcz23DoZE0vZOxhr/nl99RF5?=
 =?us-ascii?Q?E75v/A0jcmcR+DRWizHSfJyc/d86zPzjiQ0pgBAMgnjrJNtUgA5hH7sre16k?=
 =?us-ascii?Q?RYkSDAzFsvBEFqIgrzfrHYSbQSG4S+iuIC0HDKdJdmyeEZYxUjv8Mq5n/CkU?=
 =?us-ascii?Q?U2BKw/LVUayZer9+mHzm830eZ2fm5Cy9B70FwMmALIyKgIGuY6viyLgpeDjM?=
 =?us-ascii?Q?84kPLoY+jS3s3ZUC1CMvq3ONL4r/34OOD/0ceRbDfrxH/6hc4ANbF6MkQQJV?=
 =?us-ascii?Q?fRe7y1/mSgSjGMuNFRtGworMwGPxejHF4iwvAiQDwfmThDnajA9//vGxaO6d?=
 =?us-ascii?Q?6Nm+bUO8IwCcArQ7ZCFzKvcBKgN2ilDkqDHePpVhXR7FnN7/btMW3Dh7KvYb?=
 =?us-ascii?Q?QdbRR3l2/JfeJbl8znjZO76aWCRwZFEJC3BIdaMQnJxUF0xMd/IR3all5GgR?=
 =?us-ascii?Q?Xw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F60745089FD96B458216DD4613928436@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB7776.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e43a5717-0961-46f2-4133-08da8ae749f9
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 00:25:20.9183
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0qi1Q19vVS05bT7VWbC5dRLojdI+SeSv70bGNVW6OFLFTN66vjrmjslFGveh5TR6b1kQThwCz4lsKRVtgk9y6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6486
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 24, 2022 at 05:47:26PM +0900, Naohiro Aota wrote:
> The commit 4867fbbdd6b3 ("x86/mm: move protection_map[] inside the
> platform") moved accesses to protection_map[] from mem_encrypt_amd.c to
> pgprot.c. As a result, the accesses are now targets of KASAN (and other
> instrumentations), leading to the crash during the boot process.
>=20
> Disable the instrumentations for pgprot.c like commit 67bb8e999e0a
> ("x86/mm: Disable various instrumentations of mm/mem_encrypt.c and
> mm/tlb.c").
>=20
> Before this patch, my AMD machine cannot boot since v6.0-rc1 with KASAN
> enabled, without anything printed. After the change, it successfully boot=
s
> up.
>=20
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
> ---
>  arch/x86/mm/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/arch/x86/mm/Makefile b/arch/x86/mm/Makefile
> index f8220fd2c169..829c1409ffbd 100644
> --- a/arch/x86/mm/Makefile
> +++ b/arch/x86/mm/Makefile
> @@ -4,10 +4,12 @@ KCOV_INSTRUMENT_tlb.o			:=3D n
>  KCOV_INSTRUMENT_mem_encrypt.o		:=3D n
>  KCOV_INSTRUMENT_mem_encrypt_amd.o	:=3D n
>  KCOV_INSTRUMENT_mem_encrypt_identity.o	:=3D n
> +KCOV_INSTRUMENT_pgprot.o		:=3D n
> =20
>  KASAN_SANITIZE_mem_encrypt.o		:=3D n
>  KASAN_SANITIZE_mem_encrypt_amd.o	:=3D n
>  KASAN_SANITIZE_mem_encrypt_identity.o	:=3D n
> +KASAN_SANITIZE_pgprot.o		:=3D n
> =20
>  # Disable KCSAN entirely, because otherwise we get warnings that some fu=
nctions
>  # reference __initdata sections.
> @@ -17,6 +19,7 @@ ifdef CONFIG_FUNCTION_TRACER
>  CFLAGS_REMOVE_mem_encrypt.o		=3D -pg
>  CFLAGS_REMOVE_mem_encrypt_amd.o		=3D -pg
>  CFLAGS_REMOVE_mem_encrypt_identity.o	=3D -pg
> +CFLAGS_REMOVE_pgprot.o			=3D -pg
>  endif
> =20
>  obj-y				:=3D  init.o init_$(BITS).o fault.o ioremap.o extable.o mmap.o =
\
> --=20
> 2.37.2
>=20

Hello, maintainers.

Gentle ping on this patch. I need this patch to boot up my AMD machine with
KASAN enabled.=