Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220831000721.4066617-1-seanjc@google.com>
In-Reply-To: <20220831000721.4066617-1-seanjc@google.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Tue, 30 Aug 2022 17:28:50 -0700
Message-ID: <CALMp9eToxFXZVz=8ZXWdrZAdQRn9V54g0VEaKDmmpqvPrYXQoA@mail.gmail.com>
Subject: Re: [PATCH] KVM: nVMX: Reword comments about generating nested CR0/4
 read shadows
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jason Wang <wangborong@cdjrlc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 30, 2022 at 5:07 PM Sean Christopherson <seanjc@google.com> wrote:
>
> Reword the comments that (attempt to) document nVMX's overrides of the
> CR0/4 read shadows for L2 after calling vmx_set_cr0/4().  The important
> behavior that needs to be documented is that KVM needs to override the
> shadows to account for L1's masks even though the shadows are set by the
> common helpers (and that setting the shadows first would result in the
> correct shadows being clobbered).
>
> This also fixes a repeated "we we" reported by Jason.
>
> Cc: Jason Wang <wangborong@cdjrlc.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
Reviewed-by: Jim Mattson <jmattson@google.com>