Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220826084001.3341215-1-badhri@google.com> <20220826084001.3341215-3-badhri@google.com>
 <Yw4J9wv1N2Z5/qbN@kroah.com>
In-Reply-To: <Yw4J9wv1N2Z5/qbN@kroah.com>
From:   Badhri Jagan Sridharan <badhri@google.com>
Date:   Tue, 30 Aug 2022 17:20:10 -0700
Message-ID: <CAPTae5KFmEXKLJD+A-adb7LpFVY3fDKjNXR8W_wBxDaBZkCa9g@mail.gmail.com>
Subject: Re: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function
 for register reads
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        USB <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Kyle Tso <kyletso@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Thanks for the feedback ! Brain fade moment of not including commit message.
Not exporting symbols anymore and I have squashed the patch as well into
"[PATCH v2 3/3] usb: typec: maxim_contaminant: Implement
check_contaminant callback"
which I just sent out.

On Tue, Aug 30, 2022 at 6:00 AM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Fri, Aug 26, 2022 at 01:40:00AM -0700, Badhri Jagan Sridharan wrote:
> > Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>
>
> As Heikki pointed out, I can not accept changes with no changelog text
> at all, you know this.
>
> Please write a good changelog text that explains why you are doing this
> so we can properly review it.  As it is, we have no idea what is going
> on here at all.
>
> thanks,
>
> greg k-h