Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4810704rwe; Tue, 30 Aug 2022 18:07:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR5ZvifcAxDrFxqbor0RAtuB7YBi0RRORPPV/tfCdS1N1J5qtexAACFic4BVhgyhIPTRnQh4 X-Received: by 2002:a05:6402:138b:b0:447:9f18:dbc5 with SMTP id b11-20020a056402138b00b004479f18dbc5mr22863824edv.113.1661908025053; Tue, 30 Aug 2022 18:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661908025; cv=none; d=google.com; s=arc-20160816; b=tvPsDMsQElBQfOvkayUDoRyKp1lcKIFGapaV0WpSfEtvPGmoYXQdhSntI8TVJ1xd5W MWx3O3Py0CrcWNc+XSCdh1PgzDQqKcncLbLXHyAzOJUu6Pshh7O2abUnYZDTYuq2sgZa P74yxVljz4QmEwF4npOt2zJtO80zJ9ZOOEur+2+gaw7PnfapLrq3+Z1xNQ4gH70Zq7By vIZhXiEmghahXbbJ1iS+u/9WVr53oF1rJr2x8PBXHK7obq0yqIC3401OKcPOguM4z8OX o80mcUqzG5BYlgxLlzNnjncFaZRzx52p66g1aIwd475jxOg2+pMG3Kqlkju+GtDdjnWU r/CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=f2yyx5PdwBNAJtWy9YajfZK5XlLmND+uHQ91twwAAJo=; b=RenN2gmyP+71CbTTjglaoHPI2VIMAJICLAIIubqCdMrcYXzP6EYwfGfofMu28kFLzd ZI4lo4NHC1wRhP1XJufZ7pE63w9n3rIZbtlUbfBXnOtOByKuYQItxy6No+J49oBF12aR pxGsDJ+UhF8vtGdiuPd2pZYaYe9PitxayQIA7wlKFQufTnwa8MKeZrc9orPWLP0nqXmo guCpgPuhONLcDf38o4bExmv4Ez6NJfBVzxztCXoXpa1m09sQ9iKXsFD53pKXEXBs9KEI tX83+9n4wpwoedgO7T3qwFUOTqp7fGh+Lr3wJcnoIgI8/x9baI58A29TmD8FUwuaAFPW AK+w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g5-20020a056402428500b0043e42b0f87asi9153758edc.306.2022.08.30.18.06.39; Tue, 30 Aug 2022 18:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230020AbiHaAtF (ORCPT + 99 others); Tue, 30 Aug 2022 20:49:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231992AbiHaAtA (ORCPT ); Tue, 30 Aug 2022 20:49:00 -0400 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE44DA4054; Tue, 30 Aug 2022 17:48:53 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=liusong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VNoHDv4_1661906930; Received: from 30.227.181.248(mailfrom:liusong@linux.alibaba.com fp:SMTPD_---0VNoHDv4_1661906930) by smtp.aliyun-inc.com; Wed, 31 Aug 2022 08:48:51 +0800 Message-ID: Date: Wed, 31 Aug 2022 08:48:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [RFC PATCH] blk-mq: change bio_set_ioprio to inline To: Chaitanya Kulkarni Cc: "linux-block@vger.kernel.org" , "axboe@kernel.dk" , "linux-kernel@vger.kernel.org" References: <1661852746-117244-1-git-send-email-liusong@linux.alibaba.com> <0001ab1d-b4c0-2ac1-f902-c61216204aef@nvidia.com> From: Liu Song In-Reply-To: <0001ab1d-b4c0-2ac1-f902-c61216204aef@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/30 20:48, Chaitanya Kulkarni wrote: > On 8/30/22 02:45, Liu Song wrote: >> From: Liu Song >> >> Change "bio_set_ioprio" to inline to avoid calling overhead. >> >> Signed-off-by: Liu Song > for performance overhead please provide quantitative data > > -ck > This is a small adjustment, and even if performance comparison data is obtained for targeted design use cases, it is not universal. If the inline by the compiler is successful, the number of instructions will be reduced. Thanks >