Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp4828691rwe; Tue, 30 Aug 2022 18:35:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR7SXksp1/EV5h6Tf+dbvdFBM4mMVgvF5N5uzSwzmuHN534A/yknl0VxVNwcv/FS7gTE8mLC X-Received: by 2002:a05:6a00:14c5:b0:536:7d2f:883e with SMTP id w5-20020a056a0014c500b005367d2f883emr23458452pfu.36.1661909727995; Tue, 30 Aug 2022 18:35:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661909727; cv=none; d=google.com; s=arc-20160816; b=zTsnxwl+vLdlOXrO0mhIDQacvgyZ2NO1H3lZj8A7CHtluczlv+XLv7gTYuCeE/l7LY U1S5b8Gv8AReEOZ7a2z3daW6UTQq5SMbfMpF4x9xn63FlEGTxNJxt2kTWczAVSPv9HR3 noLsYFChNhlKl9e5Tcj+N9JPNbcmXF967l9mQmKeb21WH/+scb9dHVe3YEvViBz+0NOA J7ZjbGbyD9GT5Lt/GPDjhzgRV5fPiY98FKi/e9Y91Lmf3jWH3o8Ja4T81WZRV134cdUp LbtWgCi4dj3l2CUJv7xCrk7UH7+svkZT33yNy9SgyAD12swKK7q0oUZod7gzzlQzogx+ Lidg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c0FJw7LLBKzZ9BAQVj7sdve+f9M7Ki+7/qyGyj2VEc4=; b=zByy/aQDztmOritLmpPHX8sSSLIY8FK0RCz83NOAw0Jb6f2R9qMPCeDUpxYhaVYKyx E8/dnreP5RJMuMNIv6mCf4vVI6dILqTspZer8h3UeJ7Z4b2dnAmZ1sMqyyTvpUI9i6Oc +4e61Wnb9Oln8XZL5Ut7slD4rUolOUnhpsJptmiFUMIqQf3yXk388ooRXHPxLmUSCSBT XiB+ipGF1/1z5f67oun3DaMYrh6SNnTMouBkG2ubOoKnKWszF1iXvwBgVazpAu5+EhWy QH3mC4svREmwjczacBDjYUbSDKlHDQWWC1Fns94+NbPx2v4Szw8/p8eabJw5+LwyYPBI iA4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B1AcHRz2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e16-20020a17090301d000b0016f16417f6dsi14559481plh.16.2022.08.30.18.35.11; Tue, 30 Aug 2022 18:35:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B1AcHRz2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230083AbiHaBTH (ORCPT + 99 others); Tue, 30 Aug 2022 21:19:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbiHaBTF (ORCPT ); Tue, 30 Aug 2022 21:19:05 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B42CAC248 for ; Tue, 30 Aug 2022 18:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661908743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c0FJw7LLBKzZ9BAQVj7sdve+f9M7Ki+7/qyGyj2VEc4=; b=B1AcHRz21mEItGmT/ipll9q5L95AZxB8dKQkMb0mWxiURk8fOINZJOLyEUm0IYoS4DCEOg 4fxdd8PZ/k11bOCscdP4YwwBCjao/DPcgrpmt6j01DYYmTVa6QD6CQXuIK4Ntj/qTl/WrP kHzIcnWlfunVzlHxXuqs52pB1e+HJ1w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-458-djM3oyxSOLaVWSWEQ3DKwQ-1; Tue, 30 Aug 2022 21:19:00 -0400 X-MC-Unique: djM3oyxSOLaVWSWEQ3DKwQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8625F811E76; Wed, 31 Aug 2022 01:18:59 +0000 (UTC) Received: from localhost (ovpn-13-50.pek2.redhat.com [10.72.13.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B73561121314; Wed, 31 Aug 2022 01:18:58 +0000 (UTC) Date: Wed, 31 Aug 2022 09:18:55 +0800 From: Baoquan He To: Yun Levi Cc: Catalin Marinas , will@kernel.org, nramas@linux.microsoft.com, thunder.leizhen@huawei.com, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , kexec@lists.infradead.org Subject: Re: [PATCH v2] arm64/kexec: Fix missing extra range for crashkres_low. Message-ID: References: <20220830092839.3197-1-ppbuk5246@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/31/22 at 09:38am, Yun Levi wrote: > > Reviewed-by: Catalin Marinas > > > > Does this need a Fixes tag and cc stable? > > > > -- > > Catalin > > IMHO, it seems good to add two tags like: > Fixes: 3751e728cef29 ("arm64: kexec_file: add crash dump support") > Cc: stable@vger.kernel.org No, I don't think the Fixes commit is right. It should fix the commit where crashkernel,low is introduced. Before that, no issue caused. So the tags should be: Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X") Cc: stable@vger.kernel.org