Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp50295rwe; Tue, 30 Aug 2022 20:47:12 -0700 (PDT) X-Google-Smtp-Source: AA6agR7eiEPWq9kwd3ASM6Ed1R6JGRUZH56X8UA3KYCYwOicaTvBFmmgHKe3TB2wLMFfuSiGyzQz X-Received: by 2002:a17:90b:264a:b0:1fd:f88d:dbad with SMTP id pa10-20020a17090b264a00b001fdf88ddbadmr1257629pjb.93.1661917632280; Tue, 30 Aug 2022 20:47:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661917632; cv=none; d=google.com; s=arc-20160816; b=yr2K0WhsVIczzmMXRYub9nDclo22wLUMYpQoZTGFzVm+WluOelnGfLzQrKIFlh1wJr CY9DQzGO+EDeT7PkWVfAd4PMs7LtpHY8XzDVGQchSjor63B9cr4zxy8sV1fs1TFi08fd 5h7DqmJdAZr/n8xIBQdkUsiKVQChM6mg8E32lFtNvOXpiH48t9nHLovg0Rg63xTIut22 Qh1gZgdUQUbP0LJBrZPZWiKqe6HXCkeum2SNvfTaPZnWN4rmAAOFXeyzIEmDW9uVhpwA rONgheaJQi/TMdvZRHSdjcUxtbKngXXnaY3dn9DRnx72SAHW9cYuCzmGU88TOsqxVVzO zB9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=SIkOhpnSgF12O0JnM4QFh38Ot/jDR9kAJ4qYsNIujk4=; b=LmnwdfrnCcVsdOniRpwqCkBRWfkNK/C6IErXiQK6/cHc1/NFowxMGu14QCn5nPImCM nmy64wt3XuG8GKHzHXV3BUUua/sLC38oA5DCVM19q5Gjz0uOXzEt8QBdv4Cc7omdDjLN eTxnTlU40DSVUHlA+PlxOPCGS2NTXdQXZvgxwGsxsgNxKEJ3pEBOck9HCfzfX3LLIm+X CDcI8KgtC2lUOAqdvCgYUmyVNca0EtrazqqALCJLmdOtRO6syRhBoCXgDieSagjPOkMU oneLPatgMBy3z9dmUTj1WCiaoK8habuAxFPQQBVzPPcMkxTIiBj3BTzScsoum8E2mRyT 5dQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eIygtkBW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a9-20020a656049000000b0042aca53ca84si3853543pgp.418.2022.08.30.20.47.00; Tue, 30 Aug 2022 20:47:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=eIygtkBW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232273AbiHaDfw (ORCPT + 99 others); Tue, 30 Aug 2022 23:35:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232261AbiHaDfq (ORCPT ); Tue, 30 Aug 2022 23:35:46 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6432473324; Tue, 30 Aug 2022 20:35:38 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id b196so2728483pga.7; Tue, 30 Aug 2022 20:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=SIkOhpnSgF12O0JnM4QFh38Ot/jDR9kAJ4qYsNIujk4=; b=eIygtkBWAQmAnn7mDNLw0of/85QWNnSdr415QP9X5+//LjjnDzLKCpsBBmv0yOooFh LnowY3AunE6UFHvA4cX/K83phl4F/5Ehf7zkkgkWqjyHHWuBK9GUGO5eWOiPxe7TnUgx Dtpzwh6izT6zykxRx5FDpTX3AGnrqaY00QB4hy1OgmJGuGThmeurDjMNCjl446YbXTNh FHITG4J+RkHsODf459Cunkt1omY/wdntktgydSvtr5eltdnybivHRr+qCK9KqaI7faV7 mk4goy1bfGUsT6O5iUN0aFHc9EXecgkTSrdxc/zYSfHgu6ZGdZ1fUzgaeh4yT1Yp4RsY MtQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=SIkOhpnSgF12O0JnM4QFh38Ot/jDR9kAJ4qYsNIujk4=; b=WP5i9CpnpGnTYJFJOtFkDNXS6hsmv/QRTwL3ZGof7lWFreUukD/fzDOhCV6WVT5mL4 fw6H/Lkd8rr71qPUmM0LbQt8JumILCTOcDdTsDep63JSJ8vq0EIKH/w3y0B28lYBK4gL 2pSvEW0VY8yubeolTT+4fkZp3Q1dLe40Sz7AI88kmlDOxhP98MBGhnfac7tyIkkPuH+M i1ytayETPM7hT924o85Bsh+Ce44Ev/W7yw+DcpjbhEYt8zDSAKuu4jdh5h4/WfzkNy4E B9Z8fsC4ANe0rLg1OVsZbi72bl6LjzrHzM7SY3u1bIphSZJeO0xpXRphefSkR06Lt0q5 3P0Q== X-Gm-Message-State: ACgBeo0rorrxzxXCQydXPVnjdsimhTK0iAa8x6T+CgBnjA7mGXuHtISX oEz58RfrOsk6ZaZwkdck88ZxPLkzft0= X-Received: by 2002:a63:4a47:0:b0:42b:e4a4:3aec with SMTP id j7-20020a634a47000000b0042be4a43aecmr12585562pgl.512.1661916937608; Tue, 30 Aug 2022 20:35:37 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id z29-20020a630a5d000000b0042b291a89bfsm2307733pgk.11.2022.08.30.20.35.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Aug 2022 20:35:37 -0700 (PDT) From: cgel.zte@gmail.com X-Google-Original-From: ye.xingchen@zte.com.cn To: jejb@linux.ibm.com Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, ye xingchen , Zeal Robot Subject: [PATCH linux-next] scsi: scsi_error.c: Remove the unneeded result variable Date: Wed, 31 Aug 2022 03:35:28 +0000 Message-Id: <20220831033528.302249-1-ye.xingchen@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ye xingchen Return the value scsi_device_online() directly instead of storing it in another redundant variable. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/scsi/scsi_error.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index 448748e3fba5..6840bb4ab55f 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -377,13 +377,9 @@ enum blk_eh_timer_return scsi_timeout(struct request *req) */ int scsi_block_when_processing_errors(struct scsi_device *sdev) { - int online; - wait_event(sdev->host->host_wait, !scsi_host_in_recovery(sdev->host)); - online = scsi_device_online(sdev); - - return online; + return scsi_device_online(sdev); } EXPORT_SYMBOL(scsi_block_when_processing_errors); -- 2.25.1