Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 30 Aug 2022 21:46:34 -0700 (PDT)
From:   Ilkka Koskinen <ilkka@os.amperecomputing.com>
To:     Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>
cc:     Ilkka Koskinen <ilkka@os.amperecomputing.com>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        patches@amperecomputing.com
Subject: Re: [PATCH 1/1] perf/arm-cmn: Add more bits to child node address
 offset field
In-Reply-To: <f2ccc321-c892-0e35-3760-1d0ed5b5dbf3@arm.com>
Message-ID: <alpine.DEB.2.22.394.2208302136090.3584@ubuntu200401>
References: <20220808195455.79277-1-ilkka@os.amperecomputing.com> <f2ccc321-c892-0e35-3760-1d0ed5b5dbf3@arm.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Content-Type: text/plain; charset=US-ASCII; format=flowed
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/vYWrFZJbAMlg88Cm/RALcXmOjCYUYVgDfZ3vaBc8kMWUx3kn3Jv0uucFTDV?=
 =?us-ascii?Q?sLIJ8sPjU9pgp3iPalX/zIx7m1yw8T3qB89RgoQizh7pIHq9LRQyT10xzQF2?=
 =?us-ascii?Q?/IMuWp0vOmVvBNA1PMT8OmVRKOf1OGIPABb7uyKpZ/ChnOWrKacSd6vLIi//?=
 =?us-ascii?Q?ilCaeFTo+SDNNiQrC9eVaRDMvWH/lZvcCKKgTTRTeHKlGO/bfzWRK2Hmk3O1?=
 =?us-ascii?Q?/6UcXnpVdM52mybcYbbjuv2iVjZJnsy16rkRFD6VoQmF2BXgRhVRnkbLlj8k?=
 =?us-ascii?Q?2UCHZhLd8bSAqCu1Iw+UEYZloewuJdOK+rxX4/ZiEb6jRVHJld0vscY70y/v?=
 =?us-ascii?Q?x8kIS7EsRElOWT/LVl5GVIo0VEPwifiV7M5ipnfdFcWFY5S3fGsKwIOKYcEM?=
 =?us-ascii?Q?yvN7D7EOOzbVxkrmcJ8DaGM1hzyrP/TCFeezUNbv3ARMehUvP9oyM4+7iG8K?=
 =?us-ascii?Q?FKGKRDx+v8QlJCjUg64UqFtJ0f1U1SMJzj5Hro34nMzk7tQVedEDXznAnFo6?=
 =?us-ascii?Q?Apq8zp6gl+3qbM6BgwWKlFv4jnMNFydSa+zwhYyxXUCBPAzegVM8e+O2V+f9?=
 =?us-ascii?Q?C7NSGI+YphCUbA9FDC10RIt1jOcGWumHYfHB5Epo9MYpBnYHG5cO6oLK+HuE?=
 =?us-ascii?Q?tE2np4/Z5lNrW2FdWYITDIJKoWHhUt5js+tCWwbTN4GrxSqyaqQymiv9G0cY?=
 =?us-ascii?Q?QKeobXX4W0HjKxzBIe8/+u8QXJBBbgolV6PmrgI6dW2HBzf9IcYD8vMwt87o?=
 =?us-ascii?Q?n3dq/VcxefDDxXASfo976jKwzBDLeVoXOJSBvnHniihnD8sVWe64HETeoc7G?=
 =?us-ascii?Q?50rLAnzcMho0hcZtlIfxrAHgyFEJVkXIp27jI9hdSgBjfKgm2H5DQCc8GaqY?=
 =?us-ascii?Q?dsLMv8qwkmUPpAJTlS6wK/6x/9wnN1OvBXLiZ7VuACuvKXoTtI4UOMuUMVkC?=
 =?us-ascii?Q?r717dse9Gvf3jcKMRvEVVZmDXSvpdJQq44oSELAg5rXXtHwGs1xa+zdTgDyt?=
 =?us-ascii?Q?xrdHCoBPUfyMkiBzJR2VAt+xwq+iHtM2dAYzBuzfP516jGzyDvClyzFbwXZU?=
 =?us-ascii?Q?wztY4J7PYgc32ZHdtegpaD4Bey4ezH8cA09QIWiufi919dS+9vgCx8ywNbYI?=
 =?us-ascii?Q?U1JI3wALo10ev0vb2ed7EHo/FrTuviryfzn90KTXJdR+LG/Jcp9Is2sjSsS9?=
 =?us-ascii?Q?mFRvh4i25C4Kr4/tRZOS21JKkTsw1pLwsmzW0L+tVeIxNYP0WaCkxXqYNlUN?=
 =?us-ascii?Q?crl55pded1IUC4RF1a4b9sPqyR1s4Mollm8ybi48b55jwkChxF3y16+QlxCM?=
 =?us-ascii?Q?JXNn/AejvyJpIkPZkq2/sZxMZBhrAQDxvxSXw5mejdmdoEZU54Rv08uFmE4C?=
 =?us-ascii?Q?p1+wHKXiQYZnEu1Z2w3klH09VwpRQuCUnasFH/3HsuPxLZr/9stG6R5Gp3YJ?=
 =?us-ascii?Q?qsaP2WrhQT2NpjSL0nGt+efbO+X+OvouM08udemowXm+9DamyBom2Gsz399W?=
 =?us-ascii?Q?++BZkpbZMxOz4CBAzYMH9Gl+K4yMXJxe9mv5t4yBTk4lB2KJLpdi5z9kAHLy?=
 =?us-ascii?Q?oj4SFWHM6FpQLcXRV6wAP5Ou9+egO1BmtY1NteBMfGYqg/C94OivQeZZHd5M?=
 =?us-ascii?Q?Ow=3D=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a3341b26-a416-4099-a790-08da8b0c35b3
X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 04:49:38.5056
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /oC7g3czpn+4KGqxnDVgzLdK4A0GZy2NAnsArBJ6idJiVZUDZBmUX4PwQlJ/SewgCIKm9QHlhnWsD+SRcOOmaNNYYw+muqpkyXori1g6Ry0EPOdfeW3hjZ2efJYuN05W
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR01MB4997
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Will,

Would you need something more or could you pick up this patch?

Cheers, Ilkka

On Tue, 9 Aug 2022, Robin Murphy wrote:
> On 2022-08-08 20:54, Ilkka Koskinen wrote:
>> CMN-600 uses bits [27:0] for child node address offset while bits [30:28]
>> are required to be zero.
>> 
>> For CMN-650, the child node address offset field has been increased
>> to include bits [29:0] while leaving only bit 30 set to zero.
>> 
>> Let's include the missing two bits and assume older implementations
>> comply with the spec and set bits [29:28] to 0.
>
> Ah, I don't think it ever even crossed my mind to look for changes here, but 
> of course if the node regions have grown from 16KB to 64KB then it's only 
> natural that offsets grow to match. I expect the CMN-700 config that we 
> tested on internally would have been small enough for this not to make a 
> difference. Thanks for the catch!
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
>
>> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
>> ---
>> 
>> I have tested this patch on CMN-600 and CMN-650.
>> 
>> drivers/perf/arm-cmn.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
>> index 80d8309652a4..b80a9b74662b 100644
>> --- a/drivers/perf/arm-cmn.c
>> +++ b/drivers/perf/arm-cmn.c
>> @@ -36,7 +36,7 @@
>>   #define CMN_CI_CHILD_COUNT		GENMASK_ULL(15, 0)
>>   #define CMN_CI_CHILD_PTR_OFFSET		GENMASK_ULL(31, 16)
>>   -#define CMN_CHILD_NODE_ADDR		GENMASK(27, 0)
>> +#define CMN_CHILD_NODE_ADDR		GENMASK(29, 0)
>>   #define CMN_CHILD_NODE_EXTERNAL		BIT(31)
>>     #define CMN_MAX_DIMENSION		12
>