Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp105247rwe; Tue, 30 Aug 2022 22:22:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR7tjRXPaxIq5vlYZeF0NgW3CAwq2CkOI1i7gubpj+Jx/hXOWPZ2a8WpxoFbKIfHa6NMqCiu X-Received: by 2002:a17:907:7388:b0:741:966f:c1e5 with SMTP id er8-20020a170907738800b00741966fc1e5mr8578442ejc.345.1661923375602; Tue, 30 Aug 2022 22:22:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661923375; cv=none; d=google.com; s=arc-20160816; b=U/W2oEqKtWPSMrBzChPYSKM7XStVP5HPrA2eTI+WwkxaWf6aMrBuzwcvAEOCV/ULNt 2lASJMN5/UlbRkgeLXAReoTF78w+8hWEDjL81sYbr303EYS7RHaSelgVO62PD/QfYEsy LiOI3R6+1qkavyKLf3SZggbpjSRzI51MYb/dVxN4iHmOVHeIXdGL8HTosDKDzaVbnfw0 InsK/T4whqdE+/sM7mQyQXljM6+dX3gQZDUxdZVek7qKXqI6NYmLHFTBRGNxkKqy+boV LOujDC0sg+Rzy0vuPUp8tBk4ge0xSZGW0aPwxOlbcdsZM8oJqqQExj7uCvwLLB+Wa4fJ 8P4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-signature; bh=KataSHdVbvWABEj97XAiIHYuZ9jV0NRG8s8F6co+jV0=; b=Q277Rq8fM0/0VyHdQcacTxPlX8Wb164fgL1wz8lYwajyDK3rFyR0g85eySvTxeYS3b HJZtrLauZ20GdxOJEtYWGOHEbEClTupELRl+4XMNTSU1SjbAbqLzvcL2SNDNBO2rhjJL yfI0Xbbc2enU8ImcxSNSC1hqqdJOUv0X4py9wvD/w82ih3r37ZVJH7jSrwIaWWBiB9/O rFUWIRgVWYaT3Z/tLNTTFev4GB1dEMWfa9hTOJW0EKS8CXA7X8lJF5dX9EZoKFjrDbl2 mJaxrqlam92npGK5BXaWyphym4YhGonIDbZE3sKUuxX34Xn1Tons4JVrtGmrAQV4kQQ8 c1LA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="OcEO/1f+"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a056402525200b0043e1ec7a427si9506941edd.570.2022.08.30.22.22.30; Tue, 30 Aug 2022 22:22:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="OcEO/1f+"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231823AbiHaFG1 (ORCPT + 99 others); Wed, 31 Aug 2022 01:06:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230072AbiHaFGZ (ORCPT ); Wed, 31 Aug 2022 01:06:25 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66326B6017 for ; Tue, 30 Aug 2022 22:06:24 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3A3501FE31; Wed, 31 Aug 2022 05:06:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1661922382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KataSHdVbvWABEj97XAiIHYuZ9jV0NRG8s8F6co+jV0=; b=OcEO/1f+554YWDZMwINqfmbZql2+FPLF2k7C5sBYRr4bB59v1ghYHGk/9B4LnG+n9//4Au vloyCQPP74nhb50HTZ1JmME2OLNMkRuvp2rkRhGko8W9x+EyJkosNBCsoAvlBdsquSSf5i 9dYpcSgU4Mrd+vtsDNSGrn5dtdaCRMA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1661922382; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KataSHdVbvWABEj97XAiIHYuZ9jV0NRG8s8F6co+jV0=; b=f/OzrdGEPEHpd86j6N0e0Yi/NwvmNMxNVhP6Javn5s8a5HJi7oN20BB5rcUW1DLtaZkt/i FoowjQdML/HOvWCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CB4021332D; Wed, 31 Aug 2022 05:06:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DBaiLk3sDmP7XAAAMHmgww (envelope-from ); Wed, 31 Aug 2022 05:06:21 +0000 Date: Wed, 31 Aug 2022 07:06:20 +0200 From: Oscar Salvador To: Kefeng Wang Cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: kill is_memblock_offlined() Message-ID: References: <20220827112043.187028-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220827112043.187028-1-wangkefeng.wang@huawei.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 27, 2022 at 07:20:43PM +0800, Kefeng Wang wrote: > Directly check state of struct memory_block, no need a single function. > > Signed-off-by: Kefeng Wang Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs