Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <119e0cec-7fe0-4516-f419-22bf1b62058b@roeck-us.net>
Date:   Tue, 30 Aug 2022 22:31:50 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-US
To:     "Farber, Eliav" <farbere@amazon.com>, jdelvare@suse.com,
        robh+dt@kernel.org, p.zabel@pengutronix.de, rtanwar@maxlinear.com,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     talel@amazon.com, hhhawa@amazon.com, jonnyc@amazon.com,
        hanochu@amazon.com, ronenk@amazon.com, itamark@amazon.com,
        shellykz@amazon.com, shorer@amazon.com, amitlavi@amazon.com,
        almogbs@amazon.com, dkl@amazon.com, andriy.shevchenko@intel.com
References: <20220830192212.28570-1-farbere@amazon.com>
 <20220830192212.28570-4-farbere@amazon.com>
 <3a059f0d-708a-91b9-16a0-722c8227d311@roeck-us.net>
 <6413740a-aeed-8696-b5bf-1d96df15d2cc@amazon.com>
From:   Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v3 03/19] hwmon: (mr75203) update pvt->v_num to the actual
 number of used sensors
In-Reply-To: <6413740a-aeed-8696-b5bf-1d96df15d2cc@amazon.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 8/30/22 21:50, Farber, Eliav wrote:
> On 8/31/2022 5:41 AM, Guenter Roeck wrote:
>> On 8/30/22 12:21, Eliav Farber wrote:
>>> This issue is relevant when "intel,vm-map" is set in device-tree, and
>>> defines a lower number of VMs than actually supported.
>>>
>>> This change is needed for all places that use pvt->v_num later on in the
>>> code.
>>>
>>> Signed-off-by: Eliav Farber <farbere@amazon.com>
>>> ---
>>>   drivers/hwmon/mr75203.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
>>> index 0e29877a1a9c..f89f7bb5d698 100644
>>> --- a/drivers/hwmon/mr75203.c
>>> +++ b/drivers/hwmon/mr75203.c
>>> @@ -605,6 +605,7 @@ static int mr75203_probe(struct platform_device *pdev)
>>>                                       break;
>>>
>>>                       vm_num = i;
>>> +                     pvt->v_num = i;
>>
>> How about the existing assignment in the probe function ? 
> The probe function uses a local variable vm_num which is also updated
> (just one line earlier in code) in the previous patch.
> 

I meant
	pvt->v_num = vm_num;
at line 536 of the current code, but I guess the idea is to overwrite that.

Thanks,
Guenter