Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp132316rwe; Tue, 30 Aug 2022 23:08:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR6grUSz2oGEepWj6fiN/FZuiuU6+RCCkzNqNf04gid6fZCOXB+iSP/PVs1DsZ5ELX+scolP X-Received: by 2002:a17:907:1ca2:b0:741:cb75:78e5 with SMTP id nb34-20020a1709071ca200b00741cb7578e5mr5775483ejc.384.1661926091453; Tue, 30 Aug 2022 23:08:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661926091; cv=none; d=google.com; s=arc-20160816; b=t2Z6Nd3PN61/v9TUOLuQyy4F7aYKEe7ZC0RdX9/hZaJJJinKAME4V+92N1JKPk6EJN MpUUz8EntbNx+YVuphKTDnn2kD31fcv9rmBTeckkQrplcoMyhNU7QQ9SLvOERpjS6Eze 7XKVoI7DNv4FYYWXpm87wBppyHzDrlh83ALwLrEJjD5l7/CMcPTTpgU7KLX3GMva5opp TFr1nCR2ZdkBPclbeWv7r44+QUGk/uDSlSl0K1GY/X+vDJdF7QAHR5ZN7bynz3MWB6t9 oZ91qsZAzNOFzCQCwWY5g5DdUPaULQqu8kATZCXs2WUsWFRe03Y0zHASTMS9okNrBjru UN6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nS2n+rFugvX0b4oJczXpJ9ic9xndIVnIcUVXQTf9dLw=; b=x2UWNm4Dr5wAkZsxhOgAHePmGAEbvvvuC3wTXvjpNq0Wc77Ufis61U2nPgPL2F5bm/ /RI1EYpEntl0877zwso9n+qDO7HSj5aZiqcpksSJxEZ8p26YnpW+9VAnSc8w2u71xy1O uVd90zCMNmVlbh4L/qbl8ctdjpZhiXDEP34yIeqEYB0dYP/QvK2tcubjEtcDhSr1ZyqK RWofY3cGHJjibIPObei4ciB56G1ekZTxMO8KhpR+90/U54nRXxzoq7xylguT92HMmy26 OAkYZwLgle5kDhgPO3ix4DyaIGItbKFUhAYectR/5Q0hW8VuS1iVi27tlABz/KaovNSJ Z5GQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lg6WJEPR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g15-20020a056402320f00b00447eb58b921si10596646eda.38.2022.08.30.23.07.45; Tue, 30 Aug 2022 23:08:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lg6WJEPR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbiHaGF1 (ORCPT + 99 others); Wed, 31 Aug 2022 02:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbiHaGFY (ORCPT ); Wed, 31 Aug 2022 02:05:24 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A81531226; Tue, 30 Aug 2022 23:05:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA758616FF; Wed, 31 Aug 2022 06:05:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1DEEC433C1; Wed, 31 Aug 2022 06:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661925921; bh=1o734kbPT2aSPyWXx6uaFvK3CaaLOF8FTwNTJ7jLcj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lg6WJEPRuwERlCGI5pF5z5HBjJMfJZkC+RDVNKs4tio92gfSZSK3HC4zTfoZNKU0o afnSltf1KXT4QifNdqzeW81TgCyvkGAj+PONyfedDeD7c3+CBvYSp9Q9AlMnSz1QvV rSE6Cvgg7oIMTIkEG+dEg+SJ0JdiM2ajoZzBlnuwrKuHLX5o89mZjRJzBeXB6bd6b6 UsEKHThSKtOU25YnrehSDy2I4/utXOAm7EnCOe3s8WLec3DnAGQvP08io4/+QFNexx vfDQeBT8pcpfRhuL0dI1h3w0YlPSR54RWqntCiO327X+2m9txc2JknjTM4eUbRbtFg Tf0UXbE8qanDw== Date: Tue, 30 Aug 2022 23:05:19 -0700 From: Jakub Kicinski To: cgel.zte@gmail.com Cc: idosch@nvidia.com, petrm@nvidia.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jinpeng Cui , Zeal Robot Subject: Re: [PATCH linux-next] mlxsw: remove redundant err variable Message-ID: <20220830230519.4e92813a@kernel.org> In-Reply-To: <20220829105454.266509-1-cui.jinpeng2@zte.com.cn> References: <20220829105454.266509-1-cui.jinpeng2@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 29 Aug 2022 10:54:55 +0000 cgel.zte@gmail.com wrote: > + return mlxsw_core_bus_device_register(mlxsw_core->bus_info, > mlxsw_core->bus, > mlxsw_core->bus_priv, true, > devlink, extack); Please realign continuation lines so that their starts match the opening bracket. Please keep the review tags you received.